Remove extra semicolons (#2979)

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>

sdk/core/azure-core-test/inc/azure/core/test/playback_http_client.hpp

@@ -37,7 +37,7 @@ namespace Azure { namespace Core { namespace Test {
     size_t OnRead(uint8_t* buffer, size_t count, Azure::Core::Context const& context) override
     {
       return m_streamer.Read(buffer, count, context);
-    };
+    }
 
   public:
     // Forbid constructor for rval so we don't end up storing dangling ptr

sdk/core/azure-core/README.md

@@ -59,7 +59,7 @@ while (!operation.IsDone())
   // You can also try to abort the operation if it doesn't complete in time.
 
   std::this_thread::sleep_for(std::chrono::milliseconds(1000));
-};
+}
 
 auto finalResult = operation.Value();
 

sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp

@@ -33,7 +33,7 @@ namespace Azure { namespace Core { namespace Cryptography { namespace _internal
      * @brief Cleanup any state when destroying the instance of #Sha256Hash.
      *
      */
-    ~Sha256Hash(){};
+    ~Sha256Hash() {}
 
   private:
     /**
@@ -85,7 +85,7 @@ namespace Azure { namespace Core { namespace Cryptography { namespace _internal
      * @brief Cleanup any state when destroying the instance of #Sha384Hash.
      *
      */
-    ~Sha384Hash(){};
+    ~Sha384Hash() {}
 
   private:
     /**
@@ -137,7 +137,7 @@ namespace Azure { namespace Core { namespace Cryptography { namespace _internal
      * @brief Cleanup any state when destroying the instance of #Sha512Hash.
      *
      */
-    ~Sha512Hash(){};
+    ~Sha512Hash() {}
 
   private:
     /**

sdk/core/azure-core/inc/azure/core/internal/io/null_body_stream.hpp

@@ -24,7 +24,7 @@ namespace Azure { namespace Core { namespace IO { namespace _internal {
       (void)buffer;
       (void)count;
       return 0;
-    };
+    }
 
   public:
     /// Constructor.

sdk/core/azure-core/inc/azure/core/io/body_stream.hpp

@@ -69,7 +69,7 @@ namespace Azure { namespace Core { namespace IO {
           "The specified BodyStream doesn't support Rewind which is required to guarantee fault "
           "tolerance when retrying any operation. Consider creating a MemoryBodyStream or "
           "FileBodyStream, which are rewindable.");
-    };
+    }
 
     /**
      * @brief Read portion of data into a buffer.
@@ -90,7 +90,7 @@ namespace Azure { namespace Core { namespace IO {
 
       context.ThrowIfCancelled();
       return OnRead(buffer, count, context);
-    };
+    }
 
     /**
      * @brief Read #Azure::Core::IO::BodyStream into a buffer until the buffer is filled, or until
@@ -235,7 +235,7 @@ namespace Azure { namespace Core { namespace IO {
       // Rewind seeks back to 0
       void Rewind() override { this->m_offset = 0; }
 
-      int64_t Length() const override { return this->m_length; };
+      int64_t Length() const override { return this->m_length; }
     };
 
   } // namespace _internal

sdk/core/azure-core/inc/azure/core/operation.hpp

@@ -133,7 +133,7 @@ namespace Azure { namespace Core {
         throw std::runtime_error("The raw response was not yet set for the Operation.");
       }
       return *m_rawResponse;
-    };
+    }
 
     /**
      * @brief Gets the current #Azure::Core::OperationStatus of the long-running operation.

sdk/core/azure-core/inc/azure/core/url.hpp

@@ -229,7 +229,7 @@ namespace Azure { namespace Core {
      * @brief Gets the URL scheme.
      *
      */
-    const std::string& GetScheme() const { return m_scheme; };
+    const std::string& GetScheme() const { return m_scheme; }
 
     /**
      * @brief Gets the path and query parameters.

sdk/core/azure-core/src/environment_log_level_listener.cpp

@@ -113,7 +113,7 @@ inline std::string const& LogLevelToConsoleString(Logger::Level logLevel)
 
     default:
       return UnknownText;
-  };
+  }
 }
 } // namespace
 

sdk/core/azure-core/src/http/curl/curl.cpp

@@ -515,7 +515,7 @@ CURLcode CurlConnection::SendBuffer(
           return sendResult;
         }
       }
-    };
+    }
   }
 #if defined(AZ_PLATFORM_WINDOWS)
   WinSocketSetBuffSize(m_curlSocket);

sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp

@@ -121,7 +121,7 @@ namespace Azure { namespace Core { namespace Http { namespace _detail {
 
     // Makes possible to know the number of current connections in the connection pool for an
     // index
-    size_t ConnectionsOnPool(std::string const& host) { return ConnectionPoolIndex[host].size(); };
+    size_t ConnectionsOnPool(std::string const& host) { return ConnectionPoolIndex[host].size(); }
 
     std::thread m_cleanThread;
   };

sdk/core/azure-core/src/http/curl/curl_connection_private.hpp

@@ -106,14 +106,14 @@ namespace Azure { namespace Core { namespace Http {
      * @remark A connection won't be returned to the connection pool if it was shut it down.
      *
      */
-    virtual void Shutdown() { m_isShutDown = true; };
+    virtual void Shutdown() { m_isShutDown = true; }
 
     /**
      * @brief Check if the the connection was shut it down.
      *
      * @return `true` is the connection was shut it down; otherwise, `false`.
      */
-    bool IsShutdown() const { return m_isShutDown; };
+    bool IsShutdown() const { return m_isShutDown; }
   };
 
   /**

sdk/core/azure-core/src/http/telemetry_policy.cpp

@@ -31,7 +31,7 @@ namespace Azure { namespace Core { namespace _internal {
     HKEY m_value = nullptr;
 
   public:
-    explicit HkeyHolder() noexcept : m_value(nullptr){};
+    explicit HkeyHolder() noexcept : m_value(nullptr) {}
 
     ~HkeyHolder() noexcept
     {

sdk/core/azure-core/test/ut/bearer_token_authentication_policy_test.cpp

@@ -34,12 +34,12 @@ public:
       Azure::Core::Context const&) const override
   {
     return nullptr;
-  };
+  }
 
   std::unique_ptr<HttpPolicy> Clone() const override
   {
     return std::make_unique<TestTransportPolicy>(*this);
-  };
+  }
 };
 
 } // namespace

sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp

@@ -38,7 +38,7 @@ protected:
 #endif
   }
 
-  void TearDown() override { SetLogLevel(m_previousValue); };
+  void TearDown() override { SetLogLevel(m_previousValue); }
 
 private:
   std::string m_previousValue;

sdk/core/azure-core/test/ut/log_policy_test.cpp

@@ -119,7 +119,7 @@ bool EndsWith(std::string const& str, std::string const& with)
   if (str.size() < with.size())
   {
     return false;
-  };
+  }
 
   return str.substr(str.size() - with.size(), with.size()) == with;
 }

sdk/core/azure-core/test/ut/retry_policy_test.cpp

@@ -26,12 +26,12 @@ public:
       Azure::Core::Context const&) const override
   {
     return m_send();
-  };
+  }
 
   std::unique_ptr<HttpPolicy> Clone() const override
   {
     return std::make_unique<TestTransportPolicy>(*this);
-  };
+  }
 };
 
 class RetryPolicyTest final : public RetryPolicy {
@@ -62,7 +62,7 @@ public:
   std::unique_ptr<HttpPolicy> Clone() const override
   {
     return std::make_unique<RetryPolicyTest>(*this);
-  };
+  }
 
 protected:
   bool ShouldRetryOnTransportFailure(
@@ -320,8 +320,8 @@ TEST(RetryPolicy, ShouldRetryOnTransportFailure)
 
 namespace {
 class RetryLogic final : private RetryPolicy {
-  RetryLogic() : RetryPolicy(RetryOptions()){};
-  ~RetryLogic(){};
+  RetryLogic() : RetryPolicy(RetryOptions()) {}
+  ~RetryLogic() {}
 
   static RetryLogic const g_retryPolicy;
 

sdk/core/azure-core/test/ut/telemetry_policy_test.cpp

@@ -25,12 +25,9 @@ private:
     (void)nextPolicy;
 
     return std::unique_ptr<RawResponse>();
-  };
+  }
 
-  std::unique_ptr<HttpPolicy> Clone() const override
-  {
-    return std::make_unique<NoOpPolicy>(*this);
-  };
+  std::unique_ptr<HttpPolicy> Clone() const override { return std::make_unique<NoOpPolicy>(*this); }
 };
 
 } // namespace

sdk/core/perf/inc/azure/perf/base_test.hpp

@@ -31,7 +31,7 @@ namespace Azure { namespace Perf {
      * only once.
      *
      */
-    virtual void GlobalSetup(){};
+    virtual void GlobalSetup() {}
 
     /**
      * @brief Run one time per each test thread.
@@ -40,7 +40,7 @@ namespace Azure { namespace Perf {
      * thead.
      *
      */
-    virtual void Setup(){};
+    virtual void Setup() {}
 
     /**
      * @brief Defines the test specific options.
@@ -54,7 +54,7 @@ namespace Azure { namespace Perf {
     virtual std::vector<Azure::Perf::TestOption> GetTestOptions()
     {
       return std::vector<Azure::Perf::TestOption>();
-    };
+    }
 
     /**
      * @brief Define the main test case.
@@ -70,12 +70,12 @@ namespace Azure { namespace Perf {
      *
      * @remark The clean up can be skipped by setting the option `NoCleanup`.
      */
-    virtual void Cleanup(){};
+    virtual void Cleanup() {}
 
     /**
      * @brief Run only once before the test application ends.
      *
      */
-    virtual void GlobalCleanup(){};
+    virtual void GlobalCleanup() {}
   };
 }} // namespace Azure::Perf

sdk/identity/azure-identity/samples/azure/service/client.hpp

@@ -51,7 +51,7 @@ namespace Azure { namespace Service {
 
       static_cast<void>(authenticationToken); // to suppress the "unused variable" warning.
 #endif
-    };
+    }
   };
 
 }} // namespace Azure::Service

sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp

@@ -200,7 +200,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
      * @brief Gets the name of the key to create.
      *
      */
-    std::string const& GetName() const { return m_name; };
+    std::string const& GetName() const { return m_name; }
 
     /**
      * @brief Gets the key type to create, including Ec and EcHsm.
@@ -272,7 +272,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
      * @brief Gets the name of the key to create.
      *
      */
-    std::string const& GetName() const { return m_name; };
+    std::string const& GetName() const { return m_name; }
 
     /**
      * @brief Gets the key type to create, including Rsa and RsaHsm.
@@ -336,7 +336,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
      * @brief Gets the name of the key to create.
      *
      */
-    std::string const& GetName() const { return m_name; };
+    std::string const& GetName() const { return m_name; }
 
     /**
      * @brief Gets the key type to create, including Oct and OctHsm.

sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp

@@ -95,7 +95,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { nam
       std::sprintf(result, fakeKey, keyType.c_str());
       return result;
     }
-  }; // namespace Test
+  };
 
   // A derived class with no credential and authentication
   class KeyClientWithNoAuthenticationPolicy final

sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret.hpp

@@ -60,7 +60,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
       {
         throw std::invalid_argument("Value cannot be empty");
       }
-    };
+    }
 
   private:
     KeyVaultSecret(std::string name) : Name(std::move(name))

sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret_properties.hpp

@@ -133,7 +133,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
       {
         throw std::invalid_argument("Name cannot be empty");
       }
-    };
+    }
 
     /**
      * @brief Construct a new secret Properties object.

sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp

@@ -69,7 +69,9 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
      * @param keyClient An existing key vault key client.
      */
     explicit SecretClient(SecretClient const& keyClient)
-        : m_protocolClient(keyClient.m_protocolClient){};
+        : m_protocolClient(keyClient.m_protocolClient)
+    {
+    }
 
     ~SecretClient() = default;
 

sdk/storage/azure-storage-blobs/src/blob_responses.cpp

@@ -58,7 +58,7 @@ namespace Azure { namespace Storage { namespace Blobs {
       }
 
       std::this_thread::sleep_for(period);
-    };
+    }
   }
 
   void ListBlobContainersPagedResponse::OnNextPage(const Azure::Core::Context& context)

sdk/storage/azure-storage-blobs/test/perf/inc/azure/storage/blobs/test/blob_base_test.hpp

@@ -56,7 +56,7 @@ namespace Azure { namespace Storage { namespace Blobs { namespace Test {
           m_containerClient->GetBlockBlobClient(m_blobName));
     }
 
-    void Cleanup() override { m_containerClient->DeleteIfExists(); };
+    void Cleanup() override { m_containerClient->DeleteIfExists(); }
 
     /**
      * @brief Construct a new BlobsTest test.

sdk/storage/azure-storage-files-shares/src/share_responses.cpp

@@ -58,7 +58,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
       }
 
       std::this_thread::sleep_for(period);
-    };
+    }
   }
 
   void ListSharesPagedResponse::OnNextPage(const Azure::Core::Context& context)