diff --git a/sdk/core/azure-core-test/inc/azure/core/test/playback_http_client.hpp b/sdk/core/azure-core-test/inc/azure/core/test/playback_http_client.hpp index 51b567741..67770815e 100644 --- a/sdk/core/azure-core-test/inc/azure/core/test/playback_http_client.hpp +++ b/sdk/core/azure-core-test/inc/azure/core/test/playback_http_client.hpp @@ -37,7 +37,7 @@ namespace Azure { namespace Core { namespace Test { size_t OnRead(uint8_t* buffer, size_t count, Azure::Core::Context const& context) override { return m_streamer.Read(buffer, count, context); - }; + } public: // Forbid constructor for rval so we don't end up storing dangling ptr diff --git a/sdk/core/azure-core/README.md b/sdk/core/azure-core/README.md index 06bc3c51a..c27ac1cb8 100644 --- a/sdk/core/azure-core/README.md +++ b/sdk/core/azure-core/README.md @@ -59,7 +59,7 @@ while (!operation.IsDone()) // You can also try to abort the operation if it doesn't complete in time. std::this_thread::sleep_for(std::chrono::milliseconds(1000)); -}; +} auto finalResult = operation.Value(); diff --git a/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp b/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp index d7a31c91f..446243fe6 100644 --- a/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp +++ b/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp @@ -33,7 +33,7 @@ namespace Azure { namespace Core { namespace Cryptography { namespace _internal * @brief Cleanup any state when destroying the instance of #Sha256Hash. * */ - ~Sha256Hash(){}; + ~Sha256Hash() {} private: /** @@ -85,7 +85,7 @@ namespace Azure { namespace Core { namespace Cryptography { namespace _internal * @brief Cleanup any state when destroying the instance of #Sha384Hash. * */ - ~Sha384Hash(){}; + ~Sha384Hash() {} private: /** @@ -137,7 +137,7 @@ namespace Azure { namespace Core { namespace Cryptography { namespace _internal * @brief Cleanup any state when destroying the instance of #Sha512Hash. * */ - ~Sha512Hash(){}; + ~Sha512Hash() {} private: /** diff --git a/sdk/core/azure-core/inc/azure/core/internal/io/null_body_stream.hpp b/sdk/core/azure-core/inc/azure/core/internal/io/null_body_stream.hpp index 89d4a6cb2..3b8ce86ef 100644 --- a/sdk/core/azure-core/inc/azure/core/internal/io/null_body_stream.hpp +++ b/sdk/core/azure-core/inc/azure/core/internal/io/null_body_stream.hpp @@ -24,7 +24,7 @@ namespace Azure { namespace Core { namespace IO { namespace _internal { (void)buffer; (void)count; return 0; - }; + } public: /// Constructor. diff --git a/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp b/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp index 845877a22..d805ab203 100644 --- a/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp +++ b/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp @@ -69,7 +69,7 @@ namespace Azure { namespace Core { namespace IO { "The specified BodyStream doesn't support Rewind which is required to guarantee fault " "tolerance when retrying any operation. Consider creating a MemoryBodyStream or " "FileBodyStream, which are rewindable."); - }; + } /** * @brief Read portion of data into a buffer. @@ -90,7 +90,7 @@ namespace Azure { namespace Core { namespace IO { context.ThrowIfCancelled(); return OnRead(buffer, count, context); - }; + } /** * @brief Read #Azure::Core::IO::BodyStream into a buffer until the buffer is filled, or until @@ -235,7 +235,7 @@ namespace Azure { namespace Core { namespace IO { // Rewind seeks back to 0 void Rewind() override { this->m_offset = 0; } - int64_t Length() const override { return this->m_length; }; + int64_t Length() const override { return this->m_length; } }; } // namespace _internal diff --git a/sdk/core/azure-core/inc/azure/core/operation.hpp b/sdk/core/azure-core/inc/azure/core/operation.hpp index 6547dea87..21336fcae 100644 --- a/sdk/core/azure-core/inc/azure/core/operation.hpp +++ b/sdk/core/azure-core/inc/azure/core/operation.hpp @@ -133,7 +133,7 @@ namespace Azure { namespace Core { throw std::runtime_error("The raw response was not yet set for the Operation."); } return *m_rawResponse; - }; + } /** * @brief Gets the current #Azure::Core::OperationStatus of the long-running operation. diff --git a/sdk/core/azure-core/inc/azure/core/url.hpp b/sdk/core/azure-core/inc/azure/core/url.hpp index ae1cf43c6..4058e626c 100644 --- a/sdk/core/azure-core/inc/azure/core/url.hpp +++ b/sdk/core/azure-core/inc/azure/core/url.hpp @@ -229,7 +229,7 @@ namespace Azure { namespace Core { * @brief Gets the URL scheme. * */ - const std::string& GetScheme() const { return m_scheme; }; + const std::string& GetScheme() const { return m_scheme; } /** * @brief Gets the path and query parameters. diff --git a/sdk/core/azure-core/src/environment_log_level_listener.cpp b/sdk/core/azure-core/src/environment_log_level_listener.cpp index 68faf51fe..0f187924b 100644 --- a/sdk/core/azure-core/src/environment_log_level_listener.cpp +++ b/sdk/core/azure-core/src/environment_log_level_listener.cpp @@ -113,7 +113,7 @@ inline std::string const& LogLevelToConsoleString(Logger::Level logLevel) default: return UnknownText; - }; + } } } // namespace diff --git a/sdk/core/azure-core/src/http/curl/curl.cpp b/sdk/core/azure-core/src/http/curl/curl.cpp index 70d6aa5c1..e2d062b29 100644 --- a/sdk/core/azure-core/src/http/curl/curl.cpp +++ b/sdk/core/azure-core/src/http/curl/curl.cpp @@ -515,7 +515,7 @@ CURLcode CurlConnection::SendBuffer( return sendResult; } } - }; + } } #if defined(AZ_PLATFORM_WINDOWS) WinSocketSetBuffSize(m_curlSocket); diff --git a/sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp b/sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp index 9ea0202fd..fdf133436 100644 --- a/sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp +++ b/sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp @@ -121,7 +121,7 @@ namespace Azure { namespace Core { namespace Http { namespace _detail { // Makes possible to know the number of current connections in the connection pool for an // index - size_t ConnectionsOnPool(std::string const& host) { return ConnectionPoolIndex[host].size(); }; + size_t ConnectionsOnPool(std::string const& host) { return ConnectionPoolIndex[host].size(); } std::thread m_cleanThread; }; diff --git a/sdk/core/azure-core/src/http/curl/curl_connection_private.hpp b/sdk/core/azure-core/src/http/curl/curl_connection_private.hpp index 7a26ac76c..5b5c8bd10 100644 --- a/sdk/core/azure-core/src/http/curl/curl_connection_private.hpp +++ b/sdk/core/azure-core/src/http/curl/curl_connection_private.hpp @@ -106,14 +106,14 @@ namespace Azure { namespace Core { namespace Http { * @remark A connection won't be returned to the connection pool if it was shut it down. * */ - virtual void Shutdown() { m_isShutDown = true; }; + virtual void Shutdown() { m_isShutDown = true; } /** * @brief Check if the the connection was shut it down. * * @return `true` is the connection was shut it down; otherwise, `false`. */ - bool IsShutdown() const { return m_isShutDown; }; + bool IsShutdown() const { return m_isShutDown; } }; /** diff --git a/sdk/core/azure-core/src/http/telemetry_policy.cpp b/sdk/core/azure-core/src/http/telemetry_policy.cpp index 70fdf5f47..0a012d5ef 100644 --- a/sdk/core/azure-core/src/http/telemetry_policy.cpp +++ b/sdk/core/azure-core/src/http/telemetry_policy.cpp @@ -31,7 +31,7 @@ namespace Azure { namespace Core { namespace _internal { HKEY m_value = nullptr; public: - explicit HkeyHolder() noexcept : m_value(nullptr){}; + explicit HkeyHolder() noexcept : m_value(nullptr) {} ~HkeyHolder() noexcept { diff --git a/sdk/core/azure-core/test/ut/bearer_token_authentication_policy_test.cpp b/sdk/core/azure-core/test/ut/bearer_token_authentication_policy_test.cpp index fe7424e49..62babc19e 100644 --- a/sdk/core/azure-core/test/ut/bearer_token_authentication_policy_test.cpp +++ b/sdk/core/azure-core/test/ut/bearer_token_authentication_policy_test.cpp @@ -34,12 +34,12 @@ public: Azure::Core::Context const&) const override { return nullptr; - }; + } std::unique_ptr Clone() const override { return std::make_unique(*this); - }; + } }; } // namespace diff --git a/sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp b/sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp index 374648216..19c42ec7e 100644 --- a/sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp +++ b/sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp @@ -38,7 +38,7 @@ protected: #endif } - void TearDown() override { SetLogLevel(m_previousValue); }; + void TearDown() override { SetLogLevel(m_previousValue); } private: std::string m_previousValue; diff --git a/sdk/core/azure-core/test/ut/log_policy_test.cpp b/sdk/core/azure-core/test/ut/log_policy_test.cpp index 012c19a43..c4e905f71 100644 --- a/sdk/core/azure-core/test/ut/log_policy_test.cpp +++ b/sdk/core/azure-core/test/ut/log_policy_test.cpp @@ -119,7 +119,7 @@ bool EndsWith(std::string const& str, std::string const& with) if (str.size() < with.size()) { return false; - }; + } return str.substr(str.size() - with.size(), with.size()) == with; } diff --git a/sdk/core/azure-core/test/ut/retry_policy_test.cpp b/sdk/core/azure-core/test/ut/retry_policy_test.cpp index 30339a65a..5bf51ba71 100644 --- a/sdk/core/azure-core/test/ut/retry_policy_test.cpp +++ b/sdk/core/azure-core/test/ut/retry_policy_test.cpp @@ -26,12 +26,12 @@ public: Azure::Core::Context const&) const override { return m_send(); - }; + } std::unique_ptr Clone() const override { return std::make_unique(*this); - }; + } }; class RetryPolicyTest final : public RetryPolicy { @@ -62,7 +62,7 @@ public: std::unique_ptr Clone() const override { return std::make_unique(*this); - }; + } protected: bool ShouldRetryOnTransportFailure( @@ -320,8 +320,8 @@ TEST(RetryPolicy, ShouldRetryOnTransportFailure) namespace { class RetryLogic final : private RetryPolicy { - RetryLogic() : RetryPolicy(RetryOptions()){}; - ~RetryLogic(){}; + RetryLogic() : RetryPolicy(RetryOptions()) {} + ~RetryLogic() {} static RetryLogic const g_retryPolicy; diff --git a/sdk/core/azure-core/test/ut/telemetry_policy_test.cpp b/sdk/core/azure-core/test/ut/telemetry_policy_test.cpp index f783d3c90..ad5c061b5 100644 --- a/sdk/core/azure-core/test/ut/telemetry_policy_test.cpp +++ b/sdk/core/azure-core/test/ut/telemetry_policy_test.cpp @@ -25,12 +25,9 @@ private: (void)nextPolicy; return std::unique_ptr(); - }; + } - std::unique_ptr Clone() const override - { - return std::make_unique(*this); - }; + std::unique_ptr Clone() const override { return std::make_unique(*this); } }; } // namespace diff --git a/sdk/core/perf/inc/azure/perf/base_test.hpp b/sdk/core/perf/inc/azure/perf/base_test.hpp index 05d91725c..75a504828 100644 --- a/sdk/core/perf/inc/azure/perf/base_test.hpp +++ b/sdk/core/perf/inc/azure/perf/base_test.hpp @@ -31,7 +31,7 @@ namespace Azure { namespace Perf { * only once. * */ - virtual void GlobalSetup(){}; + virtual void GlobalSetup() {} /** * @brief Run one time per each test thread. @@ -40,7 +40,7 @@ namespace Azure { namespace Perf { * thead. * */ - virtual void Setup(){}; + virtual void Setup() {} /** * @brief Defines the test specific options. @@ -54,7 +54,7 @@ namespace Azure { namespace Perf { virtual std::vector GetTestOptions() { return std::vector(); - }; + } /** * @brief Define the main test case. @@ -70,12 +70,12 @@ namespace Azure { namespace Perf { * * @remark The clean up can be skipped by setting the option `NoCleanup`. */ - virtual void Cleanup(){}; + virtual void Cleanup() {} /** * @brief Run only once before the test application ends. * */ - virtual void GlobalCleanup(){}; + virtual void GlobalCleanup() {} }; }} // namespace Azure::Perf diff --git a/sdk/identity/azure-identity/samples/azure/service/client.hpp b/sdk/identity/azure-identity/samples/azure/service/client.hpp index de865eb82..960d3b6b1 100644 --- a/sdk/identity/azure-identity/samples/azure/service/client.hpp +++ b/sdk/identity/azure-identity/samples/azure/service/client.hpp @@ -51,7 +51,7 @@ namespace Azure { namespace Service { static_cast(authenticationToken); // to suppress the "unused variable" warning. #endif - }; + } }; }} // namespace Azure::Service diff --git a/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp b/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp index edcb5d358..31ddce378 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp +++ b/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_options.hpp @@ -200,7 +200,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { * @brief Gets the name of the key to create. * */ - std::string const& GetName() const { return m_name; }; + std::string const& GetName() const { return m_name; } /** * @brief Gets the key type to create, including Ec and EcHsm. @@ -272,7 +272,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { * @brief Gets the name of the key to create. * */ - std::string const& GetName() const { return m_name; }; + std::string const& GetName() const { return m_name; } /** * @brief Gets the key type to create, including Rsa and RsaHsm. @@ -336,7 +336,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { * @brief Gets the name of the key to create. * */ - std::string const& GetName() const { return m_name; }; + std::string const& GetName() const { return m_name; } /** * @brief Gets the key type to create, including Oct and OctHsm. diff --git a/sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp b/sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp index d939eaff7..759cd1110 100644 --- a/sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp +++ b/sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp @@ -95,7 +95,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { nam std::sprintf(result, fakeKey, keyType.c_str()); return result; } - }; // namespace Test + }; // A derived class with no credential and authentication class KeyClientWithNoAuthenticationPolicy final diff --git a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret.hpp b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret.hpp index 634c15f9d..d1a059fd2 100644 --- a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret.hpp +++ b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret.hpp @@ -60,7 +60,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets { { throw std::invalid_argument("Value cannot be empty"); } - }; + } private: KeyVaultSecret(std::string name) : Name(std::move(name)) diff --git a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret_properties.hpp b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret_properties.hpp index d3f7d1d71..0973d53e0 100644 --- a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret_properties.hpp +++ b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/keyvault_secret_properties.hpp @@ -133,7 +133,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets { { throw std::invalid_argument("Name cannot be empty"); } - }; + } /** * @brief Construct a new secret Properties object. diff --git a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp index 09103c673..b2c3f69c4 100644 --- a/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp +++ b/sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp @@ -69,7 +69,9 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets { * @param keyClient An existing key vault key client. */ explicit SecretClient(SecretClient const& keyClient) - : m_protocolClient(keyClient.m_protocolClient){}; + : m_protocolClient(keyClient.m_protocolClient) + { + } ~SecretClient() = default; diff --git a/sdk/storage/azure-storage-blobs/src/blob_responses.cpp b/sdk/storage/azure-storage-blobs/src/blob_responses.cpp index ac248fed2..7a52c5fe9 100644 --- a/sdk/storage/azure-storage-blobs/src/blob_responses.cpp +++ b/sdk/storage/azure-storage-blobs/src/blob_responses.cpp @@ -58,7 +58,7 @@ namespace Azure { namespace Storage { namespace Blobs { } std::this_thread::sleep_for(period); - }; + } } void ListBlobContainersPagedResponse::OnNextPage(const Azure::Core::Context& context) diff --git a/sdk/storage/azure-storage-blobs/test/perf/inc/azure/storage/blobs/test/blob_base_test.hpp b/sdk/storage/azure-storage-blobs/test/perf/inc/azure/storage/blobs/test/blob_base_test.hpp index 9efd913d8..7a506ff7e 100644 --- a/sdk/storage/azure-storage-blobs/test/perf/inc/azure/storage/blobs/test/blob_base_test.hpp +++ b/sdk/storage/azure-storage-blobs/test/perf/inc/azure/storage/blobs/test/blob_base_test.hpp @@ -56,7 +56,7 @@ namespace Azure { namespace Storage { namespace Blobs { namespace Test { m_containerClient->GetBlockBlobClient(m_blobName)); } - void Cleanup() override { m_containerClient->DeleteIfExists(); }; + void Cleanup() override { m_containerClient->DeleteIfExists(); } /** * @brief Construct a new BlobsTest test. diff --git a/sdk/storage/azure-storage-files-shares/src/share_responses.cpp b/sdk/storage/azure-storage-files-shares/src/share_responses.cpp index af3ef935b..4799a5f45 100644 --- a/sdk/storage/azure-storage-files-shares/src/share_responses.cpp +++ b/sdk/storage/azure-storage-files-shares/src/share_responses.cpp @@ -58,7 +58,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares { } std::this_thread::sleep_for(period); - }; + } } void ListSharesPagedResponse::OnNextPage(const Azure::Core::Context& context)