github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove DateTime::operator Duration() (#967)

Browse Source 
No need for it, other than the unit tests, which still can get it by subtracting epoch.
(https://github.com/Azure/azure-sdk-for-cpp/pull/938/files#r522344899)
This commit is contained in:
Anton Kolesnyk 2020-11-12 12:09:00 -08:00 committed by GitHub
parent 78e34a2189
commit bbfffc5e46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sdk/core/azure-core/CHANGELOG.md
View File

@ -2,6 +2,9 @@
## 1.0.0-beta.4 (Unreleased)
### Breaking Changes
- Removed `DateTime::operator Duration()`.
## 1.0.0-beta.3 (2020-11-11)

7
sdk/core/azure-core/inc/azure/core/datetime.hpp
View File

@ -223,13 +223,6 @@ namespace Azure { namespace Core {
return (*this == other) || (*this < other);
}
/**
* @brief Get this @DateTime representation as a @Duration from the start of the
* implementation-defined epoch.
* @return @Duration since the start of the implementation-defined epoch.
*/
constexpr explicit operator Duration() const { return m_since1601; }
private:
// Private constructor. Use static methods to create an instance.
explicit DateTime(Duration const& since1601) : m_since1601(since1601) {}

14
sdk/core/azure-core/test/ut/datetime.cpp
View File

@ -17,7 +17,7 @@ TEST(DateTime, ParseDateAndTimeBasic)
{
auto dt1 = DateTime::Parse("20130517T00:00:00Z", DateTime::DateFormat::Rfc3339);
auto dt2 = DateTime::Parse("Fri, 17 May 2013 00:00:00 GMT", DateTime::DateFormat::Rfc1123);
EXPECT_NE(0, static_cast<DateTime::Duration>(dt2).count());
EXPECT_NE(0, (dt2 - Year1601).count());
EXPECT_EQ(dt1, dt2);
}
@ -25,10 +25,10 @@ TEST(DateTime, ParseDateAndTimeBasic)
TEST(DateTime, ParseDateAndTimeExtended)
{
auto dt1 = DateTime::Parse("2013-05-17T00:00:00Z", DateTime::DateFormat::Rfc3339);
EXPECT_NE(0, static_cast<DateTime::Duration>(dt1).count());
EXPECT_NE(0, (dt1 - Year1601).count());
auto dt2 = DateTime::Parse("Fri, 17 May 2013 00:00:00 GMT", DateTime::DateFormat::Rfc1123);
EXPECT_NE(0, static_cast<DateTime::Duration>(dt2).count());
EXPECT_NE(0, (dt2 - Year1601).count());
EXPECT_EQ(dt1, dt2);
}
@ -37,7 +37,7 @@ TEST(DateTime, ParseDateBasic)
{
{
auto dt = DateTime::Parse("20130517", DateTime::DateFormat::Rfc3339);
EXPECT_NE(0, static_cast<DateTime::Duration>(dt).count());
EXPECT_NE(0, (dt - Year1601).count());
}
}
@ -45,7 +45,7 @@ TEST(DateTime, ParseDateExtended)
{
{
auto dt = DateTime::Parse("2013-05-17", DateTime::DateFormat::Rfc3339);
EXPECT_NE(0, static_cast<DateTime::Duration>(dt).count());
EXPECT_NE(0, (dt - Year1601).count());
}
}
@ -167,7 +167,7 @@ namespace {
void TestRfc1123IsTimeT(char const* str, int64_t t)
{
auto const dt = DateTime::Parse(str, DateTime::DateFormat::Rfc1123);
int64_t interval = static_cast<DateTime::Duration>(dt).count();
int64_t interval = (dt - Year1601).count();
EXPECT_EQ(0, interval % 10000000);
interval /= 10000000;
@ -521,7 +521,7 @@ TEST(DateTime, ParseDatesBefore1900)
auto dt3 = DateTime::Parse("1601-01-01T00:00:00Z", DateTime::DateFormat::Rfc3339);
auto dt4 = DateTime::Parse("Mon, 1 Jan 1601 00:00:00 GMT", DateTime::DateFormat::Rfc1123);
EXPECT_EQ(dt3, dt4);
EXPECT_EQ(0, static_cast<DateTime::Duration>(dt3).count());
EXPECT_EQ(0, (dt3 - Year1601).count());
}
TEST(DateTime, ConstructorAndDuration)