From bbfffc5e468826226185bb4d4c956279241e0c73 Mon Sep 17 00:00:00 2001
From: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Date: Thu, 12 Nov 2020 12:09:00 -0800
Subject: [PATCH] Remove DateTime::operator Duration() (#967)

No need for it, other than the unit tests, which still can get it by subtracting epoch.
(https://github.com/Azure/azure-sdk-for-cpp/pull/938/files#r522344899)
---
 sdk/core/azure-core/CHANGELOG.md                |  3 +++
 sdk/core/azure-core/inc/azure/core/datetime.hpp |  7 -------
 sdk/core/azure-core/test/ut/datetime.cpp        | 14 +++++++-------
 3 files changed, 10 insertions(+), 14 deletions(-)

diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md
index 227ca3ef1..4a2ed4546 100644
--- a/sdk/core/azure-core/CHANGELOG.md
+++ b/sdk/core/azure-core/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 1.0.0-beta.4 (Unreleased)
 
+### Breaking Changes
+- Removed `DateTime::operator Duration()`.
+
 
 ## 1.0.0-beta.3 (2020-11-11)
 
diff --git a/sdk/core/azure-core/inc/azure/core/datetime.hpp b/sdk/core/azure-core/inc/azure/core/datetime.hpp
index 146633324..3bea1ea04 100644
--- a/sdk/core/azure-core/inc/azure/core/datetime.hpp
+++ b/sdk/core/azure-core/inc/azure/core/datetime.hpp
@@ -223,13 +223,6 @@ namespace Azure { namespace Core {
       return (*this == other) || (*this < other);
     }
 
-    /**
-     * @brief Get this @DateTime representation as a @Duration from the start of the
-     * implementation-defined epoch.
-     * @return @Duration since the start of the implementation-defined epoch.
-     */
-    constexpr explicit operator Duration() const { return m_since1601; }
-
   private:
     // Private constructor. Use static methods to create an instance.
     explicit DateTime(Duration const& since1601) : m_since1601(since1601) {}
diff --git a/sdk/core/azure-core/test/ut/datetime.cpp b/sdk/core/azure-core/test/ut/datetime.cpp
index 9970d11d1..8367300fe 100644
--- a/sdk/core/azure-core/test/ut/datetime.cpp
+++ b/sdk/core/azure-core/test/ut/datetime.cpp
@@ -17,7 +17,7 @@ TEST(DateTime, ParseDateAndTimeBasic)
 {
   auto dt1 = DateTime::Parse("20130517T00:00:00Z", DateTime::DateFormat::Rfc3339);
   auto dt2 = DateTime::Parse("Fri, 17 May 2013 00:00:00 GMT", DateTime::DateFormat::Rfc1123);
-  EXPECT_NE(0, static_cast<DateTime::Duration>(dt2).count());
+  EXPECT_NE(0, (dt2 - Year1601).count());
 
   EXPECT_EQ(dt1, dt2);
 }
@@ -25,10 +25,10 @@ TEST(DateTime, ParseDateAndTimeBasic)
 TEST(DateTime, ParseDateAndTimeExtended)
 {
   auto dt1 = DateTime::Parse("2013-05-17T00:00:00Z", DateTime::DateFormat::Rfc3339);
-  EXPECT_NE(0, static_cast<DateTime::Duration>(dt1).count());
+  EXPECT_NE(0, (dt1 - Year1601).count());
 
   auto dt2 = DateTime::Parse("Fri, 17 May 2013 00:00:00 GMT", DateTime::DateFormat::Rfc1123);
-  EXPECT_NE(0, static_cast<DateTime::Duration>(dt2).count());
+  EXPECT_NE(0, (dt2 - Year1601).count());
 
   EXPECT_EQ(dt1, dt2);
 }
@@ -37,7 +37,7 @@ TEST(DateTime, ParseDateBasic)
 {
   {
     auto dt = DateTime::Parse("20130517", DateTime::DateFormat::Rfc3339);
-    EXPECT_NE(0, static_cast<DateTime::Duration>(dt).count());
+    EXPECT_NE(0, (dt - Year1601).count());
   }
 }
 
@@ -45,7 +45,7 @@ TEST(DateTime, ParseDateExtended)
 {
   {
     auto dt = DateTime::Parse("2013-05-17", DateTime::DateFormat::Rfc3339);
-    EXPECT_NE(0, static_cast<DateTime::Duration>(dt).count());
+    EXPECT_NE(0, (dt - Year1601).count());
   }
 }
 
@@ -167,7 +167,7 @@ namespace {
 void TestRfc1123IsTimeT(char const* str, int64_t t)
 {
   auto const dt = DateTime::Parse(str, DateTime::DateFormat::Rfc1123);
-  int64_t interval = static_cast<DateTime::Duration>(dt).count();
+  int64_t interval = (dt - Year1601).count();
 
   EXPECT_EQ(0, interval % 10000000);
   interval /= 10000000;
@@ -521,7 +521,7 @@ TEST(DateTime, ParseDatesBefore1900)
   auto dt3 = DateTime::Parse("1601-01-01T00:00:00Z", DateTime::DateFormat::Rfc3339);
   auto dt4 = DateTime::Parse("Mon, 1 Jan 1601 00:00:00 GMT", DateTime::DateFormat::Rfc1123);
   EXPECT_EQ(dt3, dt4);
-  EXPECT_EQ(0, static_cast<DateTime::Duration>(dt3).count());
+  EXPECT_EQ(0, (dt3 - Year1601).count());
 }
 
 TEST(DateTime, ConstructorAndDuration)