github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed IPv6 not compatible SAS test cases. (#920)

Browse Source
This commit is contained in:
Kan Tang 2020-11-09 05:07:48 -08:00 committed by GitHub
parent 344e778177
commit 6bb5cd788c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sdk/storage/azure-storage-blobs/test/blob_sas_test.cpp
View File

@ -162,7 +162,7 @@ namespace Azure { namespace Storage { namespace Test {
}
if ((permissions & AccountSasPermissions::Filter) == AccountSasPermissions::Filter)
{
//verify_blob_filter(sasToken);
// verify_blob_filter(sasToken);
}
}
@ -237,9 +237,10 @@ namespace Azure { namespace Storage { namespace Test {
auto sasToken = builder2.ToSasQueryParameters(*keyCredential);
EXPECT_THROW(verify_blob_create(sasToken), StorageError);
builder2.IPRange = "0.0.0.0-255.255.255.255";
sasToken = builder2.ToSasQueryParameters(*keyCredential);
EXPECT_NO_THROW(verify_blob_create(sasToken));
// TODO: Add this test case back with support to contain IPv6 ranges when service is ready.
// builder2.IPRange = "0.0.0.0-255.255.255.255";
// sasToken = builder2.ToSasQueryParameters(*keyCredential);
// EXPECT_NO_THROW(verify_blob_create(sasToken));
}
// Account SAS Service
@ -355,11 +356,12 @@ namespace Azure { namespace Storage { namespace Test {
auto sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName);
EXPECT_THROW(verify_blob_create(sasToken2), StorageError);
builder2.IPRange = "0.0.0.0-255.255.255.255";
sasToken = builder2.ToSasQueryParameters(*keyCredential);
EXPECT_NO_THROW(verify_blob_create(sasToken));
sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName);
EXPECT_NO_THROW(verify_blob_create(sasToken2));
// TODO: Add this test case back with support to contain IPv6 ranges when service is ready.
// builder2.IPRange = "0.0.0.0-255.255.255.255";
// sasToken = builder2.ToSasQueryParameters(*keyCredential);
// EXPECT_NO_THROW(verify_blob_create(sasToken));
// sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName);
// EXPECT_NO_THROW(verify_blob_create(sasToken2));
}
// Identifier

11
sdk/storage/azure-storage-files-datalake/test/datalake_sas_test.cpp
View File

@ -365,11 +365,12 @@ namespace Azure { namespace Storage { namespace Test {
auto sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName);
EXPECT_THROW(verify_file_create(sasToken2), StorageError);
builder2.IPRange = "0.0.0.0-255.255.255.255";
sasToken = builder2.ToSasQueryParameters(*keyCredential);
EXPECT_NO_THROW(verify_file_create(sasToken));
sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName);
EXPECT_NO_THROW(verify_file_create(sasToken2));
// TODO: Add this test case back with support to contain IPv6 ranges when service is ready.
// builder2.IPRange = "0.0.0.0-255.255.255.255";
// sasToken = builder2.ToSasQueryParameters(*keyCredential);
// EXPECT_NO_THROW(verify_file_create(sasToken));
// sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName);
// EXPECT_NO_THROW(verify_file_create(sasToken2));
}
// PreauthorizedAgentObjectId

7
sdk/storage/azure-storage-files-shares/test/share_sas_test.cpp
View File

@ -164,9 +164,10 @@ namespace Azure { namespace Storage { namespace Test {
auto sasToken = builder2.ToSasQueryParameters(*keyCredential);
EXPECT_THROW(verifyFileRead(sasToken), StorageError);
builder2.IPRange = "0.0.0.0-255.255.255.255";
sasToken = builder2.ToSasQueryParameters(*keyCredential);
EXPECT_NO_THROW(verifyFileRead(sasToken));
// TODO: Add this test case back with support to contain IPv6 ranges when service is ready.
// builder2.IPRange = "0.0.0.0-255.255.255.255";
// sasToken = builder2.ToSasQueryParameters(*keyCredential);
// EXPECT_NO_THROW(verifyFileRead(sasToken));
}
// Identifier