From 6bb5cd788cd8f7e034a9fc65b121d7963ee07e48 Mon Sep 17 00:00:00 2001 From: Kan Tang Date: Mon, 9 Nov 2020 05:07:48 -0800 Subject: [PATCH] Removed IPv6 not compatible SAS test cases. (#920) --- .../test/blob_sas_test.cpp | 20 ++++++++++--------- .../test/datalake_sas_test.cpp | 11 +++++----- .../test/share_sas_test.cpp | 7 ++++--- 3 files changed, 21 insertions(+), 17 deletions(-) diff --git a/sdk/storage/azure-storage-blobs/test/blob_sas_test.cpp b/sdk/storage/azure-storage-blobs/test/blob_sas_test.cpp index a28659373..9d11df623 100644 --- a/sdk/storage/azure-storage-blobs/test/blob_sas_test.cpp +++ b/sdk/storage/azure-storage-blobs/test/blob_sas_test.cpp @@ -162,7 +162,7 @@ namespace Azure { namespace Storage { namespace Test { } if ((permissions & AccountSasPermissions::Filter) == AccountSasPermissions::Filter) { - //verify_blob_filter(sasToken); + // verify_blob_filter(sasToken); } } @@ -237,9 +237,10 @@ namespace Azure { namespace Storage { namespace Test { auto sasToken = builder2.ToSasQueryParameters(*keyCredential); EXPECT_THROW(verify_blob_create(sasToken), StorageError); - builder2.IPRange = "0.0.0.0-255.255.255.255"; - sasToken = builder2.ToSasQueryParameters(*keyCredential); - EXPECT_NO_THROW(verify_blob_create(sasToken)); + // TODO: Add this test case back with support to contain IPv6 ranges when service is ready. + // builder2.IPRange = "0.0.0.0-255.255.255.255"; + // sasToken = builder2.ToSasQueryParameters(*keyCredential); + // EXPECT_NO_THROW(verify_blob_create(sasToken)); } // Account SAS Service @@ -355,11 +356,12 @@ namespace Azure { namespace Storage { namespace Test { auto sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName); EXPECT_THROW(verify_blob_create(sasToken2), StorageError); - builder2.IPRange = "0.0.0.0-255.255.255.255"; - sasToken = builder2.ToSasQueryParameters(*keyCredential); - EXPECT_NO_THROW(verify_blob_create(sasToken)); - sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName); - EXPECT_NO_THROW(verify_blob_create(sasToken2)); + // TODO: Add this test case back with support to contain IPv6 ranges when service is ready. + // builder2.IPRange = "0.0.0.0-255.255.255.255"; + // sasToken = builder2.ToSasQueryParameters(*keyCredential); + // EXPECT_NO_THROW(verify_blob_create(sasToken)); + // sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName); + // EXPECT_NO_THROW(verify_blob_create(sasToken2)); } // Identifier diff --git a/sdk/storage/azure-storage-files-datalake/test/datalake_sas_test.cpp b/sdk/storage/azure-storage-files-datalake/test/datalake_sas_test.cpp index 9e5555bac..0c46add06 100644 --- a/sdk/storage/azure-storage-files-datalake/test/datalake_sas_test.cpp +++ b/sdk/storage/azure-storage-files-datalake/test/datalake_sas_test.cpp @@ -365,11 +365,12 @@ namespace Azure { namespace Storage { namespace Test { auto sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName); EXPECT_THROW(verify_file_create(sasToken2), StorageError); - builder2.IPRange = "0.0.0.0-255.255.255.255"; - sasToken = builder2.ToSasQueryParameters(*keyCredential); - EXPECT_NO_THROW(verify_file_create(sasToken)); - sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName); - EXPECT_NO_THROW(verify_file_create(sasToken2)); + // TODO: Add this test case back with support to contain IPv6 ranges when service is ready. + // builder2.IPRange = "0.0.0.0-255.255.255.255"; + // sasToken = builder2.ToSasQueryParameters(*keyCredential); + // EXPECT_NO_THROW(verify_file_create(sasToken)); + // sasToken2 = builder2.ToSasQueryParameters(userDelegationKey, accountName); + // EXPECT_NO_THROW(verify_file_create(sasToken2)); } // PreauthorizedAgentObjectId diff --git a/sdk/storage/azure-storage-files-shares/test/share_sas_test.cpp b/sdk/storage/azure-storage-files-shares/test/share_sas_test.cpp index 25c087f11..d24f4e75e 100644 --- a/sdk/storage/azure-storage-files-shares/test/share_sas_test.cpp +++ b/sdk/storage/azure-storage-files-shares/test/share_sas_test.cpp @@ -164,9 +164,10 @@ namespace Azure { namespace Storage { namespace Test { auto sasToken = builder2.ToSasQueryParameters(*keyCredential); EXPECT_THROW(verifyFileRead(sasToken), StorageError); - builder2.IPRange = "0.0.0.0-255.255.255.255"; - sasToken = builder2.ToSasQueryParameters(*keyCredential); - EXPECT_NO_THROW(verifyFileRead(sasToken)); + // TODO: Add this test case back with support to contain IPv6 ranges when service is ready. + // builder2.IPRange = "0.0.0.0-255.255.255.255"; + // sasToken = builder2.ToSasQueryParameters(*keyCredential); + // EXPECT_NO_THROW(verifyFileRead(sasToken)); } // Identifier