cert-manager/pkg/controller/clusterissuers/sync_test.go
Ashley Davis c67c2c4f47
static analysis: pkg/controller
fixes the following issues:

pkg/controller/acmeorders/util.go:84:6 deadcode `hashChallenge` is unused
pkg/controller/certificaterequests/approver/approver.go:72:14 staticcheck SA4021: x = append(y) is equivalent to x = y
pkg/controller/certificaterequests/vault/vault_test.go:535:21 errcheck Error return value of `controller.Register` is not checked
pkg/controller/certificates/trigger/policies/policies.go:121:26 gosimple S1039: unnecessary use of fmt.Sprintf
pkg/controller/clusterissuers/sync_test.go:55:12 errcheck Error return value of `c.Register` is not checked
pkg/controller/ingress-shim/sync.go:301:2 gosimple S1005: unnecessary assignment to the blank identifier

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-05-21 12:03:47 +01:00

154 lines
4.0 KiB
Go

/*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package clusterissuers
import (
"context"
"reflect"
"runtime/debug"
"testing"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
clientgotesting "k8s.io/client-go/testing"
v1 "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1"
cmmeta "github.com/jetstack/cert-manager/pkg/apis/meta/v1"
testpkg "github.com/jetstack/cert-manager/pkg/controller/test"
)
func newFakeIssuerWithStatus(name string, status v1.IssuerStatus) *v1.ClusterIssuer {
return &v1.ClusterIssuer{
ObjectMeta: metav1.ObjectMeta{
Name: name,
},
Status: status,
}
}
func TestSync(t *testing.T) {
}
func TestUpdateIssuerStatus(t *testing.T) {
b := &testpkg.Builder{
T: t,
}
b.Init()
defer b.Stop()
c := &controller{}
if _, _, err := c.Register(b.Context); err != nil {
t.Errorf("failed to register context against controller: %v", err)
return
}
b.Start()
fakeClient := b.FakeCMClient()
assertNumberOfActions(t, fatalf, filter(fakeClient.Actions()), 0)
originalIssuer := newFakeIssuerWithStatus("test", v1.IssuerStatus{})
issuer, err := fakeClient.CertmanagerV1().ClusterIssuers().Create(context.TODO(), originalIssuer, metav1.CreateOptions{})
assertErrIsNil(t, fatalf, err)
assertNumberOfActions(t, fatalf, filter(fakeClient.Actions()), 1)
newStatus := v1.IssuerStatus{
Conditions: []v1.IssuerCondition{
{
Type: v1.IssuerConditionReady,
Status: cmmeta.ConditionTrue,
},
},
}
issuerCopy := issuer.DeepCopy()
issuerCopy.Status = newStatus
_, err = c.updateIssuerStatus(context.TODO(), issuer, issuerCopy)
assertErrIsNil(t, fatalf, err)
actions := filter(fakeClient.Actions())
assertNumberOfActions(t, fatalf, actions, 2)
action := actions[1]
updateAction := assertIsUpdateAction(t, errorf, action)
obj := updateAction.GetObject()
issuer = assertIsClusterIssuer(t, errorf, obj)
assertDeepEqual(t, errorf, newStatus, issuer.Status)
}
func assertIsUpdateAction(t *testing.T, f failfFunc, action clientgotesting.Action) clientgotesting.UpdateAction {
updateAction, ok := action.(clientgotesting.UpdateAction)
if !ok {
f(t, "action %#v does not implement interface UpdateAction")
}
return updateAction
}
func assertNumberOfActions(t *testing.T, f failfFunc, actions []clientgotesting.Action, number int) {
if len(actions) != number {
f(t, "expected %d actions, but got %d", number, len(actions))
}
}
func assertErrIsNil(t *testing.T, f failfFunc, err error) {
if err != nil {
f(t, err.Error())
}
}
func assertIsClusterIssuer(t *testing.T, f failfFunc, obj runtime.Object) *v1.ClusterIssuer {
issuer, ok := obj.(*v1.ClusterIssuer)
if !ok {
f(t, "expected runtime.Object to be of type *v1.Issuer, but it was %#v", obj)
}
return issuer
}
func assertDeepEqual(t *testing.T, f failfFunc, left, right interface{}) {
if !reflect.DeepEqual(left, right) {
f(t, "object '%#v' does not equal '%#v'", left, right)
}
}
func filter(in []clientgotesting.Action) []clientgotesting.Action {
var out []clientgotesting.Action
for _, i := range in {
if i.GetVerb() != "list" && i.GetVerb() != "watch" {
out = append(out, i)
}
}
return out
}
// failfFunc is a type that defines the common signatures of T.Fatalf and
// T.Errorf.
type failfFunc func(t *testing.T, msg string, args ...interface{})
func fatalf(t *testing.T, msg string, args ...interface{}) {
t.Log(string(debug.Stack()))
t.Fatalf(msg, args...)
}
func errorf(t *testing.T, msg string, args ...interface{}) {
t.Log(string(debug.Stack()))
t.Errorf(msg, args...)
}