17ec9ea8e7
see also https://github.com/jetstack/cert-manager/issues/4142 EncodeX509Chain checked for self-signed certs by comparing the subject and issuer of the cert in question, which is invalid since it's perfectly fine for those to match. the correct behavior is to use cert.CheckSignatureFrom(cert). this bug was exposed in 1.4 when ParseSingleCertificateChain started using EncodeX509Chain in the critical path of several issuers; when end-users had leaf certificates with subjects matching their issuer's subject, the bug was triggered. includes newly written tests for EncodeX509Chain and a test for ParseSingleCertificateChain Signed-off-by: Ashley Davis <ashley.davis@jetstack.io> |
||
|---|---|---|
| .. | ||
| acme | ||
| api | ||
| apis | ||
| client | ||
| controller | ||
| ctl | ||
| feature | ||
| internal | ||
| issuer | ||
| logs | ||
| metrics | ||
| scheduler | ||
| util | ||
| webhook | ||