cert-manager/make/test.mk
Ashley Davis 7ea4496dcb
Gracefully handle 404s when fetching old CRDs
If we're in the middle of a cert-manager release we'll have a git tag
created for that release, but won't have a GitHub release created yet.
That means that an attempt to download old CRDs for our versionchecker
test will fail for that version, with a 404 error.

An alternative approach would be to use the GitHub API to query for
existing non-draft releases - but that introduces a new point of failure
whereby we can easily hit a rate limit, or else introduces the need for
a GitHub API token.

The GitHub API also has the issue that it doesn't present every release
in one API call, which complicates fetching releases using curl and uses
even more rate-limit capacity.

The approach here is simple; we ignore tags for which the release 404s,
download manifests for which the release gives a 200, and bubble up any
other errors.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-03-30 15:16:17 +01:00

102 lines
4.3 KiB
Makefile

export KUBEBUILDER_ASSETS=$(PWD)/bin/tools
# WHAT can be used to control which unit tests are run by "make test"; defaults to running all
# tests except e2e tests (which require more significant setup)
# For example: make WHAT=./pkg/util/pki test-pretty to only run the PKI utils tests
WHAT ?= ./pkg/... ./cmd/... ./internal/... ./test/...
.PHONY: test
## Test is the workhorse test command which by default runs all unit and
## integration tests. Configured through WHAT, e.g.:
##
## make test WHAT=./pkg/...
##
## @category Development
test: setup-integration-tests bin/tools/gotestsum bin/tools/etcd bin/tools/kubectl bin/tools/kube-apiserver
$(GOTESTSUM) -- $(WHAT)
.PHONY: test-ci
# test-ci runs all unit and integration tests and writes a JUnit report of
# the results. WHAT also works here.
#
# The reason we are hiding the fuzz tests is because there are over 50,000
# XML lines with fuzz test cases, which means the Prow UI struggles
# displaying the JUnit results. We are hiding lines that look like this:
#
# <testcase classname="internal/controller/certificates" name="Test_serializeApplyStatus/fuzz_8358"></testcase>
#
test-ci: setup-integration-tests bin/tools/gotestsum bin/tools/etcd bin/tools/kubectl bin/tools/kube-apiserver
@mkdir -p $(ARTIFACTS)
$(GOTESTSUM) --junitfile $(ARTIFACTS)/junit_make-test-ci.xml \
--post-run-command $$'bash -c "awk \'$$1 \!~ /\\/fuzz_\\d+// { print $$2 }\' - $$GOTESTSUM_JUNITFILE >/tmp/$$$$ && mv /tmp/$$$$ $$GOTESTSUM_JUNITFILE"' \
--junitfile-testsuite-name short --junitfile-testcase-classname relative -- $(WHAT)
.PHONY: unit-test
## Same as `test` but only runs the unit tests. By "unit tests", we mean tests
## that are quick to run and don't require dependencies like a Kubernetes, etcd,
## or an apiserver.
##
## @category Development
unit-test: bin/tools/gotestsum
$(GOTESTSUM) ./cmd/... ./pkg/... ./internal/...
.PHONY: setup-integration-tests
setup-integration-tests: test/integration/versionchecker/testdata/test_manifests.tar templated-crds
@$(eval GIT_TAGS_FILE := bin/scratch/git/upstream-tags.txt)
@echo -e "\033[0;33mLatest known tag for integration tests is $(shell tail -1 $(GIT_TAGS_FILE)); if that seems out-of-date,\npull latest tags, run 'rm $(GIT_TAGS_FILE)' and retest\033[0m"
.PHONY: integration-test
## Same as `test` but only run the integration tests. By "integration tests",
## we mean the tests that require a live apiserver and etcd to run, but don't
## require a full Kubernetes cluster.
##
## @category Development
integration-test: setup-integration-tests bin/tools/gotestsum bin/tools/etcd bin/tools/kubectl bin/tools/kube-apiserver
$(GOTESTSUM) ./test/...
.PHONY: e2e
## Run the end-to-end tests. Before running this, you need to run:
##
## make -j e2e-setup
##
## To run a specific test instead of the whole suite, run:
##
## make e2e GINKGO_FOCUS='.*call the dummy webhook'
##
## For more information about GINKGO_FOCUS, see "make/e2e.sh --help".
##
## @category Development
e2e: bin/scratch/kind-exists bin/tools/kubectl bin/tools/ginkgo
make/e2e.sh
.PHONY: e2e-ci
e2e-ci: e2e-setup-kind e2e-setup
$(MAKE) --no-print-directory e2e FLAKE_ATTEMPTS=2 K8S_VERSION="$(K8S_VERSION)" || ($(MAKE) kind-logs && exit 1)
test/integration/versionchecker/testdata/test_manifests.tar: bin/scratch/oldcrds.tar bin/yaml/cert-manager.yaml
@# Remove the temp files if they exist
rm -f bin/scratch/versionchecker-test-manifests.tar bin/scratch/$(RELEASE_VERSION).yaml
@# Copy the old CRDs tar and append the currentl release version to it
cp bin/scratch/oldcrds.tar bin/scratch/versionchecker-test-manifests.tar
cp bin/yaml/cert-manager.yaml bin/scratch/$(RELEASE_VERSION).yaml
tar --append -f bin/scratch/versionchecker-test-manifests.tar -C bin/scratch ./$(RELEASE_VERSION).yaml
cp bin/scratch/versionchecker-test-manifests.tar $@
bin/scratch/oldcrds.tar: bin/scratch/git/upstream-tags.txt | bin/scratch/oldcrds
@# First, download the CRDs for all releases listed in upstream-tags.txt
<bin/scratch/git/upstream-tags.txt xargs -I% -P5 \
./hack/fetch-old-crd.sh \
"https://github.com/cert-manager/cert-manager/releases/download/%/cert-manager.yaml" \
bin/scratch/oldcrds/%.yaml
@# Next, tar up the old CRDs together
tar cf $@ -C bin/scratch/oldcrds .
bin/scratch/oldcrds:
@mkdir -p $@
bin/test:
@mkdir -p $@
bin/testlogs:
@mkdir -p $@