216 lines
7.6 KiB
Go
216 lines
7.6 KiB
Go
/*
|
|
Copyright 2020 The cert-manager Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package selfsigned
|
|
|
|
import (
|
|
"context"
|
|
"crypto"
|
|
"crypto/x509"
|
|
"errors"
|
|
"fmt"
|
|
|
|
corev1 "k8s.io/api/core/v1"
|
|
k8sErrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/client-go/tools/cache"
|
|
"k8s.io/client-go/tools/record"
|
|
"k8s.io/client-go/util/workqueue"
|
|
|
|
"github.com/cert-manager/cert-manager/internal/controller/feature"
|
|
internalinformers "github.com/cert-manager/cert-manager/internal/informers"
|
|
apiutil "github.com/cert-manager/cert-manager/pkg/api/util"
|
|
cmapi "github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1"
|
|
controllerpkg "github.com/cert-manager/cert-manager/pkg/controller"
|
|
"github.com/cert-manager/cert-manager/pkg/controller/certificaterequests"
|
|
crutil "github.com/cert-manager/cert-manager/pkg/controller/certificaterequests/util"
|
|
"github.com/cert-manager/cert-manager/pkg/issuer"
|
|
logf "github.com/cert-manager/cert-manager/pkg/logs"
|
|
cmerrors "github.com/cert-manager/cert-manager/pkg/util/errors"
|
|
utilfeature "github.com/cert-manager/cert-manager/pkg/util/feature"
|
|
"github.com/cert-manager/cert-manager/pkg/util/kube"
|
|
"github.com/cert-manager/cert-manager/pkg/util/pki"
|
|
"github.com/go-logr/logr"
|
|
)
|
|
|
|
const (
|
|
CRControllerName = "certificaterequests-issuer-selfsigned"
|
|
emptyDNMessage = "Certificate will be issued with an empty Issuer DN, which contravenes RFC 5280 and could break some strict clients"
|
|
)
|
|
|
|
type signingFn func(*x509.Certificate, *x509.Certificate, crypto.PublicKey, interface{}) ([]byte, *x509.Certificate, error)
|
|
|
|
type SelfSigned struct {
|
|
issuerOptions controllerpkg.IssuerOptions
|
|
secretsLister internalinformers.SecretLister
|
|
|
|
reporter *crutil.Reporter
|
|
recorder record.EventRecorder
|
|
|
|
// Used for testing to get reproducible resulting certificates
|
|
signingFn signingFn
|
|
}
|
|
|
|
func init() {
|
|
// create certificate request controller for selfsigned issuer
|
|
controllerpkg.Register(CRControllerName, func(ctx *controllerpkg.ContextFactory) (controllerpkg.Interface, error) {
|
|
return controllerpkg.NewBuilder(ctx, CRControllerName).
|
|
For(certificaterequests.New(
|
|
apiutil.IssuerSelfSigned,
|
|
NewSelfSigned,
|
|
|
|
// Handle informed Secrets which may be referenced by the
|
|
// "cert-manager.io/private-key-secret-name" annotation.
|
|
func(ctx *controllerpkg.Context, log logr.Logger, queue workqueue.RateLimitingInterface) ([]cache.InformerSynced, error) {
|
|
secretInformer := ctx.KubeSharedInformerFactory.Secrets().Informer()
|
|
certificateRequestLister := ctx.SharedInformerFactory.Certmanager().V1().CertificateRequests().Lister()
|
|
helper := issuer.NewHelper(
|
|
ctx.SharedInformerFactory.Certmanager().V1().Issuers().Lister(),
|
|
ctx.SharedInformerFactory.Certmanager().V1().ClusterIssuers().Lister(),
|
|
)
|
|
secretInformer.AddEventHandler(&controllerpkg.BlockingEventHandler{
|
|
WorkFunc: handleSecretReferenceWorkFunc(log, certificateRequestLister, helper, queue),
|
|
})
|
|
return []cache.InformerSynced{
|
|
secretInformer.HasSynced,
|
|
ctx.SharedInformerFactory.Certmanager().V1().Issuers().Informer().HasSynced,
|
|
ctx.SharedInformerFactory.Certmanager().V1().ClusterIssuers().Informer().HasSynced,
|
|
}, nil
|
|
},
|
|
)).
|
|
Complete()
|
|
})
|
|
}
|
|
|
|
func NewSelfSigned(ctx *controllerpkg.Context) certificaterequests.Issuer {
|
|
return &SelfSigned{
|
|
issuerOptions: ctx.IssuerOptions,
|
|
secretsLister: ctx.KubeSharedInformerFactory.Secrets().Lister(),
|
|
reporter: crutil.NewReporter(ctx.Clock, ctx.Recorder),
|
|
recorder: ctx.Recorder,
|
|
signingFn: pki.SignCertificate,
|
|
}
|
|
}
|
|
|
|
func (s *SelfSigned) Sign(ctx context.Context, cr *cmapi.CertificateRequest, issuerObj cmapi.GenericIssuer) (*issuer.IssueResponse, error) {
|
|
log := logf.FromContext(ctx, "sign")
|
|
|
|
resourceNamespace := s.issuerOptions.ResourceNamespace(issuerObj)
|
|
|
|
secretName, ok := cr.ObjectMeta.Annotations[cmapi.CertificateRequestPrivateKeyAnnotationKey]
|
|
if !ok || secretName == "" {
|
|
message := fmt.Sprintf("Annotation %q missing or reference empty",
|
|
cmapi.CertificateRequestPrivateKeyAnnotationKey)
|
|
err := errors.New("secret name missing")
|
|
|
|
s.reporter.Failed(cr, err, "MissingAnnotation", message)
|
|
log.Error(err, message)
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
privatekey, err := kube.SecretTLSKey(ctx, s.secretsLister, cr.Namespace, secretName)
|
|
if k8sErrors.IsNotFound(err) {
|
|
message := fmt.Sprintf("Referenced secret %s/%s not found", cr.Namespace, secretName)
|
|
|
|
s.reporter.Pending(cr, err, "MissingSecret", message)
|
|
log.Error(err, message)
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
if cmerrors.IsInvalidData(err) {
|
|
message := fmt.Sprintf("Failed to get key %q referenced in annotation %q",
|
|
secretName, cmapi.CertificateRequestPrivateKeyAnnotationKey)
|
|
|
|
s.reporter.Pending(cr, err, "ErrorParsingKey", message)
|
|
log.Error(err, message)
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
if err != nil {
|
|
// We are probably in a network error here so we should backoff and retry
|
|
message := fmt.Sprintf("Failed to get certificate key pair from secret %s/%s", resourceNamespace, secretName)
|
|
s.reporter.Pending(cr, err, "ErrorGettingSecret", message)
|
|
log.Error(err, message)
|
|
return nil, err
|
|
}
|
|
|
|
var template *x509.Certificate
|
|
if !utilfeature.DefaultMutableFeatureGate.Enabled(feature.DisallowInsecureCSRUsageDefinition) {
|
|
template, err = pki.DeprecatedCertificateTemplateFromCertificateRequestAndAllowInsecureCSRUsageDefinition(cr)
|
|
} else {
|
|
template, err = pki.CertificateTemplateFromCertificateRequest(cr)
|
|
}
|
|
if err != nil {
|
|
message := "Error generating certificate template"
|
|
s.reporter.Failed(cr, err, "ErrorGenerating", message)
|
|
log.Error(err, message)
|
|
return nil, nil
|
|
}
|
|
|
|
template.CRLDistributionPoints = issuerObj.GetSpec().SelfSigned.CRLDistributionPoints
|
|
|
|
if template.Subject.String() == "" {
|
|
// RFC 5280 (https://tools.ietf.org/html/rfc5280#section-4.1.2.4) says that:
|
|
// "The issuer field MUST contain a non-empty distinguished name (DN)."
|
|
// Since we're creating a self-signed cert, the issuer will match whatever is
|
|
// in the template's subject DN.
|
|
log.V(logf.DebugLevel).Info("issued cert will have an empty issuer DN, which contravenes RFC 5280. emitting warning event")
|
|
s.recorder.Event(cr, corev1.EventTypeWarning, "BadConfig", emptyDNMessage)
|
|
}
|
|
|
|
// extract the public component of the key
|
|
publickey, err := pki.PublicKeyForPrivateKey(privatekey)
|
|
if err != nil {
|
|
message := "Failed to get public key from private key"
|
|
s.reporter.Failed(cr, err, "ErrorPublicKey", message)
|
|
log.Error(err, message)
|
|
return nil, nil
|
|
}
|
|
|
|
ok, err = pki.PublicKeysEqual(publickey, template.PublicKey)
|
|
if err != nil || !ok {
|
|
|
|
if err == nil {
|
|
err = errors.New("CSR not signed by referenced private key")
|
|
}
|
|
|
|
message := "Error generating certificate template"
|
|
s.reporter.Failed(cr, err, "ErrorKeyMatch", message)
|
|
log.Error(err, message)
|
|
|
|
return nil, nil
|
|
}
|
|
|
|
// sign and encode the certificate
|
|
certPem, _, err := s.signingFn(template, template, publickey, privatekey)
|
|
if err != nil {
|
|
message := "Error signing certificate"
|
|
s.reporter.Failed(cr, err, "ErrorSigning", message)
|
|
log.Error(err, message)
|
|
return nil, nil
|
|
}
|
|
|
|
log.V(logf.DebugLevel).Info("self signed certificate issued")
|
|
|
|
// We set the CA to the returned certificate here since this is self signed.
|
|
return &issuer.IssueResponse{
|
|
Certificate: certPem,
|
|
CA: certPem,
|
|
}, nil
|
|
}
|