Commit Graph

246 Commits

Author SHA1 Message Date
James Munnelly
fe2fcd4e83 go fmt
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 15:00:39 +00:00
James Munnelly
14a1b5373f Update bazel files
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:36:07 +00:00
James Munnelly
1f48f3d1d4 gofmt
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:56 +00:00
James Munnelly
bbd73477cd Fixes after rebasing
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:56 +00:00
James Munnelly
324e8319b6 Add basic Certificate unit tests
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:55 +00:00
James Munnelly
cee0e28a05 Add initial unit test for certificate controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:55 +00:00
James Munnelly
0bde3dacba Create pkg/api/util and re-arrange controller instantiation code
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:54 +00:00
James Munnelly
3a19501e26 Add initial unit test framework for Certificates controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:22:36 +00:00
James Munnelly
804240da9d Switch Certificate controller to use Helper struct
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:22:36 +00:00
jetstack-bot
eafda2a31a
Merge pull request #1307 from munnerz/helper-everywhere
Use Helper structure to call GetGenericIssuer everywhere
2019-02-13 13:48:37 +00:00
jetstack-bot
1476aed737
Merge pull request #1293 from munnerz/test-builder-logger
Plumb testing.T through to test Builder
2019-02-13 13:48:26 +00:00
jetstack-bot
cb532cc3b8
Merge pull request #1325 from DanielMorsing/caaCheck
Extend ACME self check to check CAA records
2019-02-12 16:53:11 +00:00
Daniel Morsing
a01514ad63 use configured nameservers for CAA validation
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-11 12:05:18 +00:00
James Munnelly
1c4f160169 Use Helper structure to call GetGenericIssuer everywhere
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-07 22:35:17 +00:00
jetstack-bot
fd9567f1e4
Merge pull request #1318 from munnerz/crt-ctrl-use-lister
Use secretLister in updateSecret
2019-02-06 16:39:55 +00:00
James Munnelly
094ae3e50c Fix CLI flag not being respected
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-06 16:11:37 +00:00
James Munnelly
fac0a32c7e Fix bug causing certficates to be re-issued with misconfigured renewBefore/duration
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-06 15:43:59 +00:00
James Munnelly
e53312463d Use secretLister in updateSecret
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-05 17:56:16 +00:00
Daniel Morsing
bb853e5e79 first draft CAA checking
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-05 14:25:10 +00:00
jetstack-bot
22b0863801
Merge pull request #1128 from lrolaz/certificate-ip-sans
Add IP Address in CSR
2019-01-31 23:05:25 +00:00
James Munnelly
d055d370bb Plumb testing.T through to test Builder
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-31 20:20:20 +00:00
Laurent ROLAZ
ed82465df5 Refactoring
Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>
2019-01-30 13:04:28 +01:00
Laurent Rolaz
18daea16ae Remove duplicate IPAddressesToString
Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>
2019-01-25 18:50:16 +01:00
Laurent Rolaz
c5fa202239 Fix some GO Style
Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com> (+2 squashed commits)
Squashed commits:
[ce6cc2eb] Fix some GO Style

Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>
[563b7275] Fix some GO Style

Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>
2019-01-25 18:50:16 +01:00
Laurent Rolaz
531c26061c GO Format
Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>

Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>
2019-01-25 18:38:12 +01:00
Laurent Rolaz
6dcc408741 Add IP Address in CSR
Signed-off-by: Laurent Rolaz <laurent.rolaz@gmail.com>
2019-01-25 18:38:12 +01:00
James Munnelly
948a2cf77c Add more OWNERS files with auto-labels
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-24 19:38:31 +00:00
jetstack-bot
e930bd3ca7
Merge pull request #1244 from DanielMorsing/self-check-errs
Surface self-check errors in challenge resource
2019-01-23 14:50:16 +00:00
Daniel Morsing
99c16b77dc fix other test
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-21 13:33:34 +00:00
Daniel Morsing
b0a9b8276c surface self-check errors in challenge resource
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-21 11:49:46 +00:00
jetstack-bot
438d0a6775
Merge pull request #1240 from munnerz/expired-orders-no-cert
Update order status if state changes while retrieving an existing certificate
2019-01-18 14:28:23 +00:00
James Munnelly
3d1183a169 Fix nil map panic when writing to an empty existing Secret
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-18 11:16:44 +00:00
James Munnelly
c91833f43a Update order status if state changes will retrieving an existing certificate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-17 18:29:55 +00:00
Daniel Morsing
88d811b34c change Check function signature
This makes the check function into a simple precondition

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-17 16:45:03 +00:00
James Munnelly
e88e4f4406 If an Order is already valid, attempt to retrieve existing certificate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-17 13:19:04 +00:00
jetstack-bot
5f96b378e6
Merge pull request #1184 from tlmiller/feature/authnss
Control authoritative dns01 server check.
2019-01-12 15:25:07 +00:00
Thomas Miller
dacd0b45cb Control authoritative dns01 server check.
Adds cmd flag for controlling if authoritative dns servers are used to
check RR propagation or just normal resolvers.

This change is added so that constrained enviornments can control more
aspects of DNS queries performed.

- Applying PR feedback

Signed-off-by: Thomas Miller <thomas@tlm.id.au>
2019-01-12 20:17:28 +10:00
jetstack-bot
2fc68d9b33
Merge pull request #1197 from munnerz/acme-retain-challenges
Retain Challenge resources for debugging if an Order enters an invalid state
2019-01-11 17:22:11 +00:00
jetstack-bot
c512319bfb
Merge pull request #1188 from kragniz/controller-namespace
Add --namespace flag
2019-01-11 15:14:11 +00:00
James Munnelly
b1df71dd66 Retain Challenge resources for debugging if an Order enters an invalid state
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-11 14:04:23 +00:00
James Munnelly
21c7b2e13f Increase ACME control loop max back-off. Increase create order back-off to 1h. Fire Event when Order fails.
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-10 22:07:48 +00:00
jetstack-bot
95f63313a9
Merge pull request #1192 from DanielMorsing/add-reason
Add reason when an order/challenge gets marked invalid
2019-01-10 15:25:23 +00:00
Daniel Morsing
cc946c0b45 Populate reason field regardless
If we have an error, then tell people about it.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:54:43 +00:00
Daniel Morsing
1b921b1583 remove more strict validation
Turns out the ACME server can respond with different codes than the ones listed

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:35:30 +00:00
Daniel Morsing
ba240bbe4e Add reason when an order/challenge gets marked invalid
When an ACME server tells us that a challenge or an order is invalid, it's helpful to get some information on why that's the case. Populate the reason field with the error information so that these issues can be more easily debugged.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:05:15 +00:00
Louis Taylor
40b68a3e10 Fix more references to clusterIssuer
Signed-off-by: Louis Taylor <louis@kragniz.eu>
2019-01-10 13:52:52 +00:00
Louis Taylor
bbda87b3c8 Add --namespace flag
Signed-off-by: Louis Taylor <louis@kragniz.eu>
2019-01-10 13:52:52 +00:00
James Munnelly
22342b61b3 Fix use of SecretTLSKeyPair in certificates controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-09 11:39:48 +00:00
James Munnelly
3ac4d19874 Fix bug in challenge scheduler causing invalid results
Previously, we shared a single backing slice when
performing filter operations on slices, causing issues
when we perform sorting operations on that same
underlying slice.

Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-08 13:53:58 +00:00
James Munnelly
0fcc0c666c Update copyright header year
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-07 15:07:55 +00:00