Commit Graph

322 Commits

Author SHA1 Message Date
jetstack-bot
f3bc4fad79
Merge pull request #1705 from cheukwing/issue-912
Add the removal of unrequired certificates
2019-06-18 12:01:04 +01:00
jetstack-bot
043a88cdd8
Merge pull request #1689 from cheukwing/issue-1558
Validate that only one Certificate is using a secretName per namespace
2019-06-17 20:21:57 +01:00
jetstack-bot
48cd58b23f
Merge pull request #1722 from cheukwing/issue-1003
Add BaseController as a refactoring of common controller code
2019-06-17 19:27:57 +01:00
Michael Tsang
9934593714 Add test and documentation regarding clockskew on notBefore
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-06-17 12:53:48 +01:00
Michael Tsang
202d72c8c6 Add todo on certificate selector
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-06-07 10:01:06 +01:00
Michael Tsang
9b8e72aa6e Add test for deletion of unrequired certificates
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-06-07 10:01:06 +01:00
Michael Tsang
82f658e078 Implement removal of unrequired certificates
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-06-07 09:29:15 +01:00
jetstack-bot
0a7a181808
Merge pull request #1670 from cheukwing/issue-1520
Ensure only the sole owner of a certificate can modify it
2019-06-06 21:09:03 +01:00
jetstack-bot
4c199c90ca
Merge pull request #1717 from dobesv/patch-2
Fix solver selection logic to return the selected solver rather than always returning the last one
2019-06-06 13:29:03 +01:00
jetstack-bot
edd2225002
Merge pull request #1692 from cheukwing/issue-1001
Add metric to count number of sync calls
2019-06-05 11:20:39 +01:00
Michael Tsang
a2da614fd5 Remove old workerWg field from controller structs
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-06-05 10:35:38 +01:00
Dobes Vandermeer
bd8cd5441a Fix address to reference array element
The address of a for loop created variable does not change between loops - the variable is over-written with each new variable.  This fixes the code so that `d` references the array element instead of the local variable, which means that when `d` is assigned to `matchAll` or `specificMatch` it will work as intended.

Signed-off-by: Dobes Vandermeer <dobesv@gmail.com>
2019-05-28 09:00:04 +01:00
Michael Tsang
04139d587e Add comments to base controller
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-24 15:02:43 +01:00
Michael Tsang
089ff067ce Add more detailed logging
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-24 13:55:33 +01:00
Dobes Vandermeer
6d28bee388 Update matchAllDomainsNumLabels and numLabelsSpecificMatch
These variables seem like they should be updated when updating the thing they are supposed to be derived from.

Signed-off-by: Dobes Vandermeer <dobesv@gmail.com>
2019-05-24 09:57:53 +01:00
Michael Tsang
0add074b7f Add basecontroller to other controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-23 17:32:33 +01:00
Michael Tsang
9d8070d9af Add base controller
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-23 13:45:08 +01:00
Michael Tsang
35a4837b90 rebase
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-21 12:22:06 +01:00
Michael Tsang
b49912cdab Use IsControlledBy, clarify info message, fix tests
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-21 12:20:08 +01:00
Michael Tsang
606fed7bbb Add additional tests to test new strategy
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-21 12:20:08 +01:00
Michael Tsang
e0db53dc04 Fix tests to use ownerreference in certificates
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-21 12:20:08 +01:00
Michael Tsang
6aea622955 Ensure only the sole owner of a certificate can modify it
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-21 12:19:03 +01:00
Michael Tsang
0e677ee900 Break out of unnecessary checks for duplicates
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 15:44:52 +01:00
jetstack-bot
5a213cc5f0
Merge pull request #1698 from munnerz/ing-shim-copy-labels
Copy labels from Ingress to Certificate resource in ingress-shim
2019-05-20 13:30:58 +01:00
Michael Tsang
7d67ae466e Remove metrics field from controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 11:06:11 +01:00
James Munnelly
1d319f3cd4 Copy labels from Ingress to Certificate resource in ingress-shim
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-19 11:00:10 +02:00
James Munnelly
f77e5c1c89 Log warning Event if edit-in-place is enabled with new solver format
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-19 10:56:19 +02:00
Michael Tsang
455f6ebab4 Use ControllerName as label value
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 16:49:39 +01:00
Michael Tsang
840cba375b Bazel update scripts
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 14:39:39 +01:00
Michael Tsang
f2e57a1c95 Add ControllerSyncCallCount metric
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 14:22:16 +01:00
Michael Tsang
2691349ffc Add test for unique secret name
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-16 16:25:40 +01:00
Michael Tsang
da08563f2d Implement check for unique secretname
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-16 13:27:20 +01:00
Michael Tsang
a628b8f5a7 Use MaxConcurrentChallenges flag in scheduler
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-13 17:03:35 +01:00
Michael Tsang
2cc1c4df07 Add MaxConcurrentChallenges flag and associated structs to options
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-13 16:55:38 +01:00
James Munnelly
1268f76690 Make lastTransitionTime a pointer
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-02 14:59:52 +01:00
James Munnelly
6c3a5b3e73 Fix issue when migrating ingress-shim managed certificates from old to new format
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 18:45:59 +01:00
James Munnelly
7945a6b6a8 Remove anonymous function
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 17:14:34 +01:00
James Munnelly
55c6e6dda4 Update ingress-shim unit tests to handle new API config types
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 16:25:21 +01:00
James Munnelly
7e2bedbe17 Update ingress-shim unit tests to use test builder
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 16:25:17 +01:00
James Munnelly
bc52db91b6 Update ingress-shim to handle new format
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 15:21:50 +01:00
James Munnelly
fc6e3e5315 Remove extra check for certificate.spec.acme
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 14:24:37 +01:00
James Munnelly
220d39c17d Update acmeorders controller to support both formats
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 14:24:00 +01:00
jetstack-bot
331df1b381
Merge pull request #1602 from munnerz/fix-update-loop
Fix update loop due to changing notAfter struct
2019-05-01 12:44:25 +01:00
James Munnelly
064b710f02 Fix update loop due to changing notAfter struct
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 19:10:29 +01:00
James Munnelly
bbf4012e12 Handle expired challenge responses in acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 18:57:26 +01:00
jetstack-bot
570751236d
Merge pull request #1585 from munnerz/validate-caa-feature-gate
Add feature gate for ValidateCAA functionality and default it to off
2019-04-30 14:17:48 +01:00
James Munnelly
49f587c844 Set Reason field on ACME challenges during Present/CleanUp
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 10:25:33 +01:00
James Munnelly
9906c0d946 Add feature gate for ValidateCAA functionality and default it to off
To help avoid issues with the ValidateCAA functionality, this disables
the CAA check by default and adds a new --feature-gates=ValidateCAA=true
option to cert-manager-controller to allow enabling the previous
behaviour in v0.7.0 and v0.7.1.

Once issues with CNAMEd DNS names pointing to internal nameservers
are resolved, this option will be defaulted to on.

Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-25 15:10:05 +01:00
James Munnelly
25af59a0d5 Use v1beta1 API version in cainjector controller
This resolves issues when running the cainjector on Kubernetes 1.9,
as the 1.9 apiserver is not aware of the 'v1' API version.

Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-24 11:19:24 +01:00
James Munnelly
af9bce7221 Add 'webhook' DNS01 provider type
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-18 17:19:32 +01:00