James Munnelly
ec8d6e12e4
Add validation to ensure Order & Challenge fields are immutable
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-17 16:54:15 +01:00
James Munnelly
c5ee500a2e
Add unit tests for validation webhook handler
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-17 16:54:15 +01:00
James Munnelly
ed284084b3
Refactor validation handler to support updates
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-17 13:27:08 +01:00
James Munnelly
ca9e8f33b2
Clean up webhook handler interface
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-17 12:56:13 +01:00
jetstack-bot
ee9cbf25af
Merge pull request #2245 from munnerz/webhook-golang-httpserver
...
Use standard golang http server for webhook
2019-10-17 12:54:23 +01:00
James Munnelly
da8bf264fd
Use standard golang http server for webhook
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-17 12:29:34 +01:00
jetstack-bot
3fbcd95262
Merge pull request #2224 from answer1991/feature/support-kubeconfig
...
enable cert-manager using --kubeconfig to connect API Server with kubeconfig file
2019-10-17 09:48:23 +01:00
chenjun.cj
fe6e446f43
enable cert-manager using --kubeconfig to connect API Server with kubeconfig file
...
Signed-off-by: chenjun.cj <chenjun.cj@alibaba-inc.com>
2019-10-17 12:14:28 +08:00
jetstack-bot
87aedeb04c
Merge pull request #2225 from munnerz/wildcard-field-ptr
...
Make ACMEAuthorization.Wildcard field a pointer
2019-10-15 19:05:05 +01:00
jetstack-bot
f57ee108c3
Merge pull request #2146 from gottwald/clouddns-cleanup
...
Cleanup clouddns package
2019-10-15 16:04:04 +01:00
jetstack-bot
8d12d351e8
Merge pull request #2216 from JoshVanL/move-IngressEditInPlaceAnnotationKey-to-acme
...
Move IngressEditInPlaceAnnotationKey into acme API
2019-10-15 13:53:19 +01:00
James Munnelly
e9796e79f2
Update generated files
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:40:17 +01:00
James Munnelly
a365d1c19d
Remove old comment
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:35:25 +01:00
James Munnelly
56b1fdd379
Make ACMEAuthorization.Wildcard a *bool
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:35:11 +01:00
JoshVanL
536dc150ab
Move IngressEditInPlaceAnnotationKey into acme API
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-14 16:32:41 +02:00
James Munnelly
e0e4f9b5ea
Only construct ACME client once Issuer resource is Ready
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 10:52:50 +01:00
James Munnelly
ef55bd5807
Mark Order & Challenge resources as Errored if 4xx error is received
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 09:30:17 +01:00
jetstack-bot
1c424dd219
Merge pull request #2171 from dulltz/handle-error
...
Fix to handle error
2019-10-09 17:19:27 +01:00
James Munnelly
6b19892908
Fix regression in certificates controller setting owner references
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-09 11:33:21 +01:00
dulltz
bd6248805a
Fix to handle error
...
Signed-off-by: dulltz <isrgnoe@gmail.com>
2019-10-09 18:13:42 +09:00
JoshVanL
2e1a534642
The ingress shim checks certificate common names and ensures they are
...
empty
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 16:57:54 +01:00
jetstack-bot
482eac596a
Merge pull request #2085 from JoshVanL/certificate-URISANs
...
Adds URISANs field to Certificate
2019-10-03 10:59:47 +01:00
JoshVanL
7d615ff8e4
Remove getting secret from lister in matches spec func
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 10:01:57 +01:00
Ingo Gottwald
0e59c623a0
Cleanup clouddns package
...
- Replace deprecated dns.New function with dns.NewService
- Remove deprecated oauth2.NoContext
- Fix unused err value in test
Signed-off-by: Ingo Gottwald <in.gottwald@gmail.com>
2019-10-03 10:58:48 +02:00
Ingo Gottwald
be3f1e3fd2
Remove use of deprecated client.MatchingField
...
Signed-off-by: Ingo Gottwald <in.gottwald@gmail.com>
2019-10-02 20:47:58 +02:00
JoshVanL
dc7cc388e1
Converts acme test to UpdateStatus
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:51:37 +01:00
JoshVanL
7965be9b41
Adds from comments
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
9ba973abc8
Rephrase venafi error with no ObjectName
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
80236351f6
Set the venafi ObjectName with the CN->DNS->URI as precedence
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
b6bce10b2f
Adds CommonName e2e tests for new behaviour
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
334f90dfac
Adds uri_sans to vault parameters
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
66cda5cbd7
Only match for common name in DNS names if common name was given
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
54f8069a78
Make annotation of secret if nil to prevent panic
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
18e0dcdb63
Adds boilerplate copyright to util_test.go
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
13b0584838
Change behaviour to be more relaxed around common names
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
88cadca433
Adds proper checking for common name in e2e tests
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
5cdad4eed3
Updates api types
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
f249888112
Only add common-name annotation if commonName exists
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
dd7213866f
Adds validation for URIs to certificate validation
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
832e20ae29
Adds URISANs field to Certificate
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
jetstack-bot
b91b7d8d3f
Merge pull request #2097 from JoshVanL/status-subresource
...
Adds status sub resource and changes updates
2019-10-02 16:40:11 +01:00
James Munnelly
e3b1e9bdb9
Call UpdateStatus before Update when finalizing Challenges
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
9a807be80a
Fix not returning updateErr if updating status failed
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
8bf08237f7
Migrate acmechallenges and acmeorders to use UpdateStatus
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
259efac9bd
Remove 'IngressKey' from certmanager API in favour of a single const
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 10:04:55 +01:00
JoshVanL
5bb452f6e9
Fix info log typo
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-01 16:21:47 +01:00
JoshVanL
b6803a2185
Fully update challenge and order in controller sync instead of UpdateStatus
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
de07651142
Remote updatestatus todos and add minimal version to docs
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb
Adds status sub resource and changes updates
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
JoshVanL
1c4fcdf519
Updates bazel
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-27 13:54:39 +01:00