Commit Graph

85 Commits

Author SHA1 Message Date
Sathyanarayanan Saravanamuthu
9ffd83ee95 Fixing the documentation typo
Signed-off-by: Sathyanarayanan Saravanamuthu <sathya.chozhanaadan@gmail.com>
2022-09-28 14:30:55 +05:30
Ashley Davis
ab09488c22
timeouts proposal
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Co-authored-by: Maël Valais <mael@vls.dev>
2022-06-21 18:57:29 +01:00
irbekrm
1c4152d4cc Code review feedback
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-05-31 12:17:35 +01:00
irbekrm
c605685a29 Adds design template
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-05-26 10:19:29 +01:00
jetstack-bot
f4f40f689e
Merge pull request #4757 from irbekrm/exponential_backoff_design
Design for exponential backoff
2022-03-30 12:10:33 +01:00
jetstack-bot
0c454ea72e
Merge pull request #4758 from JoshVanL/design-server-side-apply
Design Server Side Apply
2022-03-22 10:14:46 +00:00
irbekrm
d7ccd6dd51 Reducing initial backoff period is a non-goal
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-18 10:26:00 +00:00
irbekrm
ae37a6ecbb Adds a note about denied CertificateRequests
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-18 10:26:00 +00:00
irbekrm
476a22b674 Remove reference to event that shows when the next issuance will be attempted
The event did not seem that useful. Manually triggered (and failed reissuance attempt can result in multiple events on a Certificate each showing different renewal timestamp which seems confusing. Also events are short lived, so not that useful to someone debugging few hours after failure

Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-18 10:26:00 +00:00
irbekrm
93cf3f7a2a Changing revision number should not reset backoff period
There is no particular reason why it should and applying backoff to all consecutive failed issuances makes this easier to reason about

Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-18 10:26:00 +00:00
irbekrm
184a16da10 Design for exponential backoff
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-18 10:26:00 +00:00
Ashley Davis
3a055cc2f5
rename all uses of github.com/jetstack/cert-manager
This was done by running the following command twice:

 ```bash
 grep -Ri "github.com/jetstack/cert-manager" . | \
 cut -d":" -f1 | \
 sort | \
 uniq | \
 xargs sed -i
 "s/github.com\/jetstack\/cert-manager/github.com\/cert-manager\/cert-manager/"
 ```

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-02 09:08:31 +00:00
joshvanl
bfcaa3dd55 Change APPLY->Apply, Server Side->Server-Side
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-31 13:42:50 +00:00
joshvanl
cf1bec13e6 Adds comments for force section
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-19 14:45:45 +00:00
joshvanl
cfa63f47fb Add section on Migration
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-19 10:48:48 +00:00
joshvanl
b64dcfff99 Update design with review comments
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-19 10:29:04 +00:00
joshvanl
24dfdc011f Add paragraph about adding tags on API types
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-18 16:26:11 +00:00
joshvanl
80c786d05d Adds design document for using server side apply in cert-manager
controllers

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-18 15:52:07 +00:00
Ashley Davis
4bc906ee8d
remove old draft release notes
this repo isn't the source of truth for release notes, and if these are
drafts anyway they don't need to be kept around

(and they will still be available in git history anyway!)

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-11-04 16:42:47 +00:00
joshvanl
696356b702 Update certificates.k8s.io-adoption design to include changes which have
been implemented

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 14:20:18 +01:00
joshvanl
68a065e34f Updates from meeting
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 13:29:50 +01:00
joshvanl
eeef422165 Adds some minor spelling and grammar
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 13:29:50 +01:00
joshvanl
52a2ae599d Updates the design proposal from team discussions
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 13:29:50 +01:00
joshvanl
686a33ca74 Add a section as to _why_ I am proposing this approach
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 13:29:49 +01:00
joshvanl
5f98ba69f4 Adds certificates.k8s.io Adoptions Design Document
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-07-26 13:29:49 +01:00
joshvanl
1e961c945b Changes some wording and adds some suggestions to the yaml text
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
b5a48f8dc8 Change strings to be the yaml equivalent
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
c09a092c96 Adds blank line under headings
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
7394d8da1e Change the SAR explanation in the webhook
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
bc0f822ca7 Change CR RBAC resource-name to resource-type
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
2c15fe376f Adds that requests should be updated with a False Ready condition when
Denied

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
0d7fa077f8 Update docs with word changes
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
2314c2c16a Updates the example enabled controllers flag to correctly disable just
the approver controller

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
9051a6d9b8 Updates table of contents
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
1740515064 Updates doc with correct signer syntax, using discovery API,
clarifications and spelling/grammar

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
c86cf31aaf Merges the approved/denied condition design with the master
CertificateRequest design doc

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
joshvanl
03f718a9ec Adds design document for the behaviour and implementation of CRs
Approved/Denied conditions

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-17 17:28:45 +01:00
jetstack-bot
03b3e2f20b
Merge pull request #3630 from JoshVanL/design-identity
DESIGN: CertificateRequest UserInfo fields
2021-03-15 17:06:16 +00:00
joshvanl
ceede2ccbe Change user info field design satus to implemented
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-15 09:39:47 +00:00
Josh Soref
6dc9d7cd97 spelling: certificate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-03-03 21:00:18 -05:00
joshvanl
c701a23f28 Removes TODO from design doc
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-12 10:33:24 +00:00
joshvanl
7e38aab32a Merge branch 'design-identity' of github.com:joshvanl/cert-manager into design-identity
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-11 17:24:56 +00:00
joshvanl
aeda0f23c0 Updates design document from comments
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-11 17:22:12 +00:00
Josh Van Leeuwen
fdc13a2841
Update design/20210203.certificate-request-identity.md
Co-authored-by: Jake Sanders <i@am.so-aweso.me>
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-02-04 17:41:51 +00:00
Josh Van Leeuwen
759249b113 Update design/20210203.certificate-request-identity.md
Co-authored-by: Jake Sanders <i@am.so-aweso.me>
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-02-04 17:41:06 +00:00
Josh Van Leeuwen
41dac7f9ee Update design/20210203.certificate-request-identity.md
Co-authored-by: Jake Sanders <i@am.so-aweso.me>
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-02-04 17:40:39 +00:00
joshvanl
d94880e693 First pass of identity design document
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-03 17:49:06 +00:00
Mateusz Gozdek
27fa2f1ec4
Fix various typos found by codespell
Found by running this command:

codespell -S .git,*.png,go.sum -L keypair,iam,ans,unknwon,tage,ths,creater

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
2020-11-07 14:55:13 +01:00
Josh Soref
08b5fe415c
Add closing quotes
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-09-09 13:38:06 -04:00
James Munnelly
bc881762ea WIP: draft of extensible certificates controller doc
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-04-15 12:25:18 +01:00