- Prior to this commit, regardless what was put for KIND_CLUSTER_NAME,
the name of the cluster was always "kind". Furthermore, when running
make clean, only clusters named "kind" were cleaned up. With a few
minor fixes, this commit solves the problem so that kind clusters with
different names can be used when running tests.
Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Cody Eilar <cody@codyeilar.com>
This will break anyone who relied on featureGates field to pass feature gates to webhook- they will need to use the new webhook.featureGates field
Signed-off-by: irbekrm <irbekrm@gmail.com>
When building Pebble, Go was mistakenly thinking that the go.work is the
Go Workspace in which the Pebble module resides:
main module (github.com/cert-manager/cert-manager) does not contain package github.com/cert-manager/cert-manager/_bin/downloaded/containers/amd64/pebble/pebble-ba5f81dd80fa870cbc19326f2d5a46f45f0b5ee3/cmd/pebble
At first, I thought that directories prefixed with _ would be ignored
(like what "go build" does), but it doesn't seem to work that way since
the go.work file is looked up recursively "upwards", not downwards.
The only workaround I could think of is to build Pebble outside of the
tree in which go.work resides.
Signed-off-by: Maël Valais <mael@vls.dev>
The main reason for bumping Vault's version is because 1.2.3 is not
compatible with the config parameter `disable_iss_validation`, which is
needed for accommodating the future tests [1] that rely on bound tokens
and static tokens.
For context, Vault 1.2.3 was released on Sep 9, 2019 [2] but
`disable_iss_validation` was only added on July 21st, 2020 in Vault
1.5.0.
Due to a breaking change that happened in Vault 1.5.0 [3] in which Vault
started loading the pod's token instead of using the same token (to be
reviewed) for authenticating. An alternative solution could have been to
prevent the service account from being mounted to the pod, but I figured
that having the two service accounts separated is a better practice.
[1]: https://github.com/cert-manager/cert-manager/pull/5502
[2]: https://github.com/hashicorp/vault/commit/c14bd9a2
[3]: https://github.com/hashicorp/vault/blob/main/CHANGELOG.md#150
Signed-off-by: Maël Valais <mael@vls.dev>
In #5473 we saw a user being confused by devel's continued existance.
No bazel stuff will work any more and there's value in having just one
place where our e2e setup scripts are located, and that's now in `make`.
It was considered that we might keep some of these scripts but
converting them to call make commands, but that might be a lot of work
for minimal reward.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
This adds multiple retries on every attempt we make to use curl, which
should help to reduce flakes. Uses a $(CURL) variable where possible so
that we have the same invocation everywhere.
Also switches to using the more verbose curl arguments, in an attempt to
make it easier to reason about how curl is configured.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
This is needed because go and other tools will ignore directories
starting with "_" or "." but would treat a dir called "bin" as a regular
directory.
This in turn meant that when we vendored Go in bin, these tools would by
default scan the whole stdlib included with the bundled vendored go.
See https://pkg.go.dev/cmd/go#hdr-Package_lists_and_patterns for details
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
