irbekrm
f2933be499
ECDSA instead of RSA keys generated for test Vault CA's root and intermediate
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-20 21:48:09 +01:00
irbekrm
63342c1d5e
Check that Vault certs' CA contains root cert if expected
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-20 13:05:38 +01:00
irbekrm
0ebce264f1
Allow to optionally configure Vault intermediate PKI with root CA
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-20 13:05:26 +01:00
irbekrm
ef627a13b6
Adds a few comments
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-20 11:31:01 +01:00
irbekrm
06f6b46f30
Implements feedback from code review
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:20:05 +01:00
irbekrm
bbfd2294f9
Integration test for ACME Orders controller
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:11:48 +01:00
irbekrm
d8c941da8e
Refactors creation of ACME Orders controller
...
So that it easier used with the existing test framework and also is more similar to how most other controllers are created
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:11:18 +01:00
Tamal Saha
6bfe640533
Update fakeSecretClient
...
Signed-off-by: Tamal Saha <tamal@appscode.com>
2021-05-17 08:52:59 -07:00
Tamal Saha
7b63788f52
Cleanup codegen script
...
Signed-off-by: Tamal Saha <tamal@appscode.com>
2021-05-17 08:11:19 -07:00
Tamal Saha
b1cb6422e4
Use controller-runtime v0.9.0-beta.0
...
Signed-off-by: Tamal Saha <tamal@appscode.com>
2021-05-17 08:11:19 -07:00
jetstack-bot
e941307bdc
Merge pull request #3938 from irbekrm/3879_test_acme_issuer_setup
...
3879 test acme issuer setup
2021-05-14 13:35:50 +01:00
irbekrm
3ef1643cd7
Re-enable e2e tests that connect to Venafi TPP.
...
This reverts commit 9d059a2425 .
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-13 11:50:29 +01:00
irbekrm
9d059a2425
Temporarily revert "Re-enable the Venafi TPP E2E tests"
...
These tests are currently failing- we should investigate and re-enable
them.
This reverts commit c769432db5 .
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-12 16:11:07 +01:00
Jake Sanders
79d8d9cb7b
Revert "Merge pull request #3724 from inteon/istio-virtualservice-for-http01"
...
This reverts commit 80f27739b5 , reversing
changes made to 96604d02a3 .
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-11 14:50:25 +01:00
irbekrm
284de092e9
Adds a few ACME-specific functions to issuer gen
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-10 09:53:39 +01:00
irbekrm
0c751f51e4
Adds functionality to generate issuer conditions to gen
...
So they can be generated in tests with less lines of code
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-10 09:53:20 +01:00
irbekrm
6318de527c
Adds a fake Secrets client
...
A simpler implementation than https://github.com/kubernetes/client-go/blob/master/kubernetes/typed/core/v1/fake/fake_secret.go and more suited for unit tests that don't spin up a controller
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-10 09:52:58 +01:00
Inteon
2299e8d8a6
Apply suggestions from code review
...
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:49 +02:00
Inteon
30634f154c
improve Certificate is Ready test
...
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:47 +02:00
Inteon
624e2b9e69
add ACME HTTP01 Istio support
...
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:19:53 +02:00
Erik Godding Boye
5d21410156
Add new unsupported feature to exclude root CA assert in Vault issuer e2e-tests
...
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-23 15:14:33 +02:00
Erik Godding Boye
1919e4cb3f
Add root CA certificate assert to e2e tests
...
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2021-04-23 15:14:33 +02:00
irbekrm
70f3d0b8c2
Temporarily revert "Enable the Venafi Cloud E2E tests"
...
This reverts commit 4ddfcbf96b .
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-20 12:19:43 +01:00
jetstack-bot
b5be5a8730
Merge pull request #3877 from irbekrm/move_crypto_fork
...
Use upstream golang/crypto for ACME EAB + move crypto fork to cert-manager org
2021-04-13 13:28:15 +01:00
Lars Lehtonen
635dc187f5
test/integration/certificates: fix dropped error
...
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
2021-04-12 05:45:57 -07:00
irbekrm
d213b4bfdb
Standardize deprecation warnings
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-12 09:38:49 +01:00
irbekrm
697836e446
Update comment for replace directive in go.mod
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-09 15:11:22 +01:00
irbekrm
2c2b3da2a7
Add e2e test cases for different ACME EAB configurations
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-09 10:28:34 +01:00
jetstack-bot
1dad685e48
Merge pull request #3873 from irbekrm/remove_legacy_functions
...
Remove legacy e2e util functions for Issuer creation
2021-04-09 10:24:45 +01:00
irbekrm
333f600661
Remove legacy e2e util functions for Issuer creation
...
Use test/util/gen instead
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-04-08 18:30:45 +01:00
Richard Wall
c769432db5
Re-enable the Venafi TPP E2E tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-08 18:23:48 +01:00
Richard Wall
4ddfcbf96b
Enable the Venafi Cloud E2E tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-08 18:23:48 +01:00
jetstack-bot
10a871dc62
Merge pull request #3444 from maelvls/bug-certificaterequest-not-updated
...
Bug: certificaterequest not updated after its certificate is updated
2021-04-06 20:17:57 +01:00
Maël Valais
dc99a5e8ca
acme-http01-e2e: PR comment: Equal -> ContainElements for DNS names
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-04-06 18:09:28 +02:00
Maël Valais
6cda600e42
acme-http01-e2e: PR comment: 30 seconds of wait is enough
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-04-06 18:09:28 +02:00
Maël Valais
98fe26b939
acme-http01-e2e: PR comment: check cert is unready before correcting it
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-04-06 18:09:28 +02:00
Maël Valais
85128f26ce
trigger-controller: PR comment: rephrase log about skipping issuance
...
The log message:
multiple CertificateRequests found for the 'next' revision 2,
skipping issuance until no more duplicate.
can be better phrased as:
multiple CertificateRequests are found for the 'next' revision 2,
issuance is skipped until there are no more duplicates.
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:28 +02:00
Maël Valais
3832f551aa
acme-http01-e2e: "validations" are not actually verifying the X.509 cert
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:27 +02:00
Maël Valais
78e2e7fdca
acme-http01-e2e: pebble was returning the same 400 as boulder
...
Pebble:
400 urn:ietf:params:acme:error:rejectedIdentifier: Order included an identifier for which issuance is forbidden by policy: "google.com"
Let's Encrypt's boulder:
400 urn:ietf:params:acme:error:rejectedIdentifier: Cannot issue for "google.com"
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:27 +02:00
Maël Valais
18a9461023
acme-http01-e2e: add a test case to show the cert update bug
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:27 +02:00
Maël Valais
89c3dc1afa
gen: document why we do not pass an entire Certificate
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 18:09:27 +02:00
jetstack-bot
e7333df106
Merge pull request #3838 from wallrj/3289-stable-api-versions
...
Update cainjector to use stable API versions
2021-04-06 15:19:57 +01:00
Richard Wall
3d7f370b21
Re-enable the cainjector E2E tests for apiregistration
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-06 14:04:26 +01:00
Richard Wall
20510e45f0
Update cainjector to use stable API versions
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-01 17:23:28 +01:00
Richard Wall
39ebccd0ba
Skip the Venafi Cloud conformance tests by default
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-01 09:13:36 +01:00
Richard Wall
a372e1afb6
Delete empty Venafi Cloud issuer tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-04-01 09:13:36 +01:00
jetstack-bot
e29a3df86d
Merge pull request #3785 from JoshVanL/approval-subject-access-review
...
Approval subject access review
2021-04-01 08:00:39 +01:00
irbekrm
81a8588b91
Bumps versions of Gazelle, go_rules, Kazel, protobuf
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
Bumps versions of Gazelle, go_rules, Kazel and protobuf
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-03-29 08:25:12 +01:00
joshvanl
820b8556a3
Fix go linting
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-26 17:41:42 +00:00
joshvanl
b75655fbb6
Updates approval e2e tests to include custom resource definitions
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-26 17:26:28 +00:00