Commit Graph

3304 Commits

Author SHA1 Message Date
SpectralHiss
d07dd3de5f Fix OtherName feature flag validation logic
* Improve test comments for UniversalValue

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2024-01-08 13:34:09 +00:00
jetstack-bot
e0189a6a30
Merge pull request #6607 from inteon/deprecate_util_function
Deprecate URLsFromStrings which is only used in other deprecated functions
2024-01-05 15:23:16 +00:00
Tim Ramlot
c584ee6dfb
use generics for mustAllSync variants
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-05 11:58:14 +01:00
Tim Ramlot
a49bc65b03
deprecate URLsFromStrings which is only used in other deprecated functions
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-05 11:50:13 +01:00
Richard Wall
7bda41c282 Use io instead of deprecated ioutil
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-04 15:05:24 +00:00
Tim Ramlot
8ca617a8ea
replace custom util function with k8s.io/apimachinery/util/sets
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-04 14:38:30 +01:00
jetstack-bot
24d0fddec5
Merge pull request #6593 from inteon/use_slices
Use slices go library
2024-01-04 13:36:02 +00:00
jetstack-bot
d2f3f12f47
Merge pull request #6592 from inteon/add_long_cert_chain_test
Add tests for the improvements made in #6561
2024-01-04 13:18:02 +00:00
Tim Ramlot
e157729991
fix typo in name and add comment explaining genericEqualUnsorted
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-04 14:02:36 +01:00
Tim Ramlot
950948e465
start using the new 'slices' library and deprecate old util functions
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-04 09:32:17 +01:00
Tim Ramlot
90dc8ccde0
disable APIPriorityAndFairness using config instead of feature flag
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 17:40:46 +01:00
Tim Ramlot
9547fbdf94
add tests for the improvements made in #6561
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 17:25:15 +01:00
Tim Ramlot
a0f2849425
run 'make update-codegen'
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 16:18:35 +01:00
Tim Ramlot
6458aaf518
stop using deprecated klog functions
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 16:18:35 +01:00
jetstack-bot
e9a4793ba4
Merge pull request #6589 from inteon/rename_feature_gates
Rename UseCertificateRequestNameConstraints to NameConstraints
2024-01-03 15:04:22 +00:00
Tim Ramlot
41404a7fd7
rename UseCertificateRequestNameConstraints to NameConstraints
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 15:49:18 +01:00
jetstack-bot
9d5ed5752f
Merge pull request #6120 from inteon/cleanup_test_context_builder
add comments explaining the Sync function & small test bugfix
2024-01-03 14:33:22 +00:00
jetstack-bot
cc8925ae9f
Merge pull request #6404 from SpectralHiss/hef/otherNameSANs
Other name sans support in Certificates
2024-01-03 14:16:23 +00:00
Houssem El Fekih
ddc1dffe87
Update pkg/util/pki/asn1_util.go
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
Signed-off-by: Houssem El Fekih <hassoum92@hotmail.com>
2024-01-03 13:30:42 +00:00
jetstack-bot
4af78fe98a
Merge pull request #6548 from snorwin/modern-pkcs12
New option to specify encryption and MAC algorithms for PKCS#12 keystores.
2024-01-03 12:54:22 +00:00
Tim Ramlot
8223df9e91
rename Algorithms to Profile
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 13:45:02 +01:00
Tim Ramlot
914c2dd169
add comments explaining the Sync function & small bugfixes
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-03 11:15:27 +01:00
Richard Wall
036e3a8e74 Replace all uses of sets.String with the generic sets.Set
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 17:24:38 +00:00
Richard Wall
19ade4b79e Replace all calls to RandStringBytes and RandStringRunes
With k8s.io/apimachinery/pkg/util/rand#String instead

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 15:41:07 +00:00
Richard Wall
4aa373b733 Deprecate RandStringBytes and RandStringRunes
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 15:02:14 +00:00
Richard Wall
d468830b23 Fix gosec G404
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 12:33:46 +00:00
Richard Wall
865063594d Fix gosec 501
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 11:20:16 +00:00
Richard Wall
0ea258327d Fix gosec G505
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 10:10:11 +00:00
jetstack-bot
5615de61ee
Merge pull request #6563 from inteon/hide_deprecated_flags
Hide deprecated CLI flags
2023-12-27 09:59:59 +00:00
jetstack-bot
5e09dd3059
Merge pull request #6561 from inteon/parse_certificate_chain
Certificate chain parsing
2023-12-27 09:59:53 +00:00
SpectralHiss
1b48cb664b Fix csr_test.go critical SAN on tests without Subjects
* Also fixed the conformance e2e test by including a Subject and
  matching the values

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 18:44:49 +00:00
SpectralHiss
c59037a19b Simplify e2e test fixture for otherName
* Fix Bug in critical on empty subject logic

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 17:48:50 +00:00
SpectralHiss
ae4249b9e2 Go style variable rename
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 14:54:08 +00:00
SpectralHiss
2f6dbc85d3 Change openssl SAN order to simplify test assetion
* Ordering does not matter for the GeneralNames as it is a tagged
  context

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 13:07:34 +00:00
SpectralHiss
8e2365dd54 Add UTF8 marshalling unit tests
* Add test names to pkg/util/pki/sans_test.go tests

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 11:58:26 +00:00
SpectralHiss
f4bbe66737 Fix IA5String test assertion
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-21 10:02:53 +00:00
jetstack-bot
c7714e65f0
Merge pull request #6551 from wallrj/gosec-601
Fix gosec G601: Implicit memory aliasing of items from a range statement
2023-12-20 18:21:37 +00:00
Richard Wall
4de9e956e5 Fix gosec G601: Implicit memory aliasing of items from a range statement
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-20 17:25:41 +00:00
Tim Ramlot
24794feac0
update API comments
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 11:26:52 +01:00
Tim Ramlot
f60a61bde1
hide deprecated flags
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:25:35 +01:00
Tim Ramlot
f2af5672ee
add additional validation checks
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:13:11 +01:00
Tim Ramlot
cd58042746
improve the algorithm and add prevent DOS
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:13:11 +01:00
Tim Ramlot
c81609cdef
move certificate chain parsing to seperate file
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:13:07 +01:00
SpectralHiss
e7f29f8bb3 UTF8Value -> utf8Value in CRD JSON schema
* Still following Go standard with UTF8Value for struct field name

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-20 08:30:54 +00:00
SpectralHiss
c87a2f6691 Add early feedback validation for otherName syntax and tests
* Fixed warning

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-19 20:02:02 +00:00
Adam Talbot
247a034116 feat: update gateway api to v1
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-18 21:00:42 +00:00
Norwin Schnyder
ebf58b9967 apply PR feedback
Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
2023-12-15 10:52:57 +01:00
Allen Mun
9b09aa87a7 Add flag and field to customize leaf duration on dynamic certificates
Signed-off-by: Allen Mun <allen.mun@capitalone.com>
2023-12-13 15:45:52 -05:00
SpectralHiss
95b9345a5d Make UTF8Value godoc comment more clear
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-13 17:05:12 +00:00
SpectralHiss
4bdee5f010 Rename otherNameSANs to otherNames
* Improve the CRD godoc comments

Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
2023-12-13 16:21:56 +00:00