Commit Graph

1230 Commits

Author SHA1 Message Date
Ashley Davis
a76003f737
Merge pull request #6056 from inteon/improve_pki_webhook
Improve CertificateRequest's CSR validation code
2023-07-11 16:31:37 +01:00
Tim Ramlot
4d7f6281d0
use pki validation code for CSR validation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-07-10 12:48:12 +02:00
Tim Ramlot
90f84b9c40
remove VCert fork dependency replace statement
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-07-10 11:26:16 +02:00
Tim Ramlot
7098c25a55
move e2e framework back to e2e module
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-07-07 19:26:10 +02:00
Tim Ramlot
dcf3c99e63
fix Kubernetes CSR tests, making sure the Usages match what is encoded in the CSR blob
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-07-05 13:04:21 +02:00
Tim Ramlot
5ba29272c0
add validation to pki CertificateTemplate function
and add support for add DontAllowInsecureCSRUsageDefinition featuregate
to use old behavior in controller

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-07-05 13:04:21 +02:00
Tim Ramlot
2f56c3c89a
add DontAllowInsecureCSRUsageDefinition feature gate to disable the strict CSR validation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-06-28 11:11:32 +02:00
Tim Ramlot
63387015d0
make CertificateRequest webhook validation more strict (the Usages array should always be the source of truth)
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-06-26 10:08:13 +02:00
Maël Valais
06b2ea6d48 Update cmd/cmctl's go.mod to v1.13.0-alpha.0
Signed-off-by: Maël Valais <mael@vls.dev>
2023-06-20 20:09:35 +02:00
jetstack-bot
c5e6bf39d6
Merge pull request #6054 from inteon/correct_versions
Use Version 3 for *x509.Certificate
2023-05-26 13:57:32 +01:00
Luca Comellini
8a5704635a
Bump sigs.k8s.io/controller-runtime to v0.15.0
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-23 17:34:28 -07:00
irbekrm
132ab27cec Updates cmctl to point at latest cert-manager
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-19 14:31:18 +01:00
Luca Comellini
bf6bbb19de
Bump k8s.io dependencies
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-18 21:55:47 -07:00
Tim Ramlot
0284d20a74
upgrade all our docker deps
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-12 15:32:09 +02:00
Tim Ramlot
d14ffca049
replace go.mod replace statements with require statements
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-12 14:38:32 +02:00
Tim Ramlot
2ba39e9ebc
allow importing the ctl cmd package
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-12 14:13:04 +02:00
irbekrm
16bfe33937 make update-licenses
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-11 13:04:03 +01:00
irbekrm
b67c68859d Bumps Helm to latest release
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-11 12:55:58 +01:00
irbekrm
5ee7b50ca8 Bumps c/r to latest commit
To ensure that there is as little diff as possible with c/r 0.15

Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-11 12:13:19 +01:00
Tim Ramlot
e7530880ce
use Version 3 for all Certificates and Version 0 for all CertificateRequests
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-11 10:21:55 +02:00
Tim Ramlot
0cf0f80b40
switch to non-deprecated functions in source code
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-10 19:22:49 +02:00
jetstack-bot
308c1472aa
Merge pull request #6031 from inteon/remove_deprecated_3
Replace deprecated wait.PollUntil and wait.Poll
2023-05-10 17:52:54 +01:00
Ashley Davis
9f1c1cf247
use a concrete cert-manager version for cmctl
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-05-10 15:45:45 +01:00
irbekrm
b094df3bd3 Add a comment about splitting this package
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-10 12:09:55 +01:00
irbekrm
97a3eb8697 Makes test framework accessible externally
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-10 12:09:35 +01:00
Ashley Davis
209c252005
Move webhook testing package to core module
This package was used by at least one external importer [1] and so the
change to make the webhook live in a separate package caused an issue
which @irbekrm reported on slack. [2]

This PR moves the webhook testing code into the core cert-manager module
so it'll be importable anywhere (albeit under a new name). This change
also requires moving the webhook options into the core cert-manager
module since they're required by the webhook testing logic.

[1] 268cd2fdba/test/env/env.go (L25)

[2] https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1683650224483169

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-05-09 18:40:03 +01:00
Tim Ramlot
e08a13496d
replace deprecated wait.PollUntil() and wait.Poll()
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-09 17:47:53 +02:00
jetstack-bot
3fee31c0c5
Merge pull request #6030 from inteon/remove_deprecated_2
Replace deprecated wait.PollImmediate
2023-05-09 15:31:55 +01:00
Tim Ramlot
e9c4cd9f3f
check that issuer is not nil before reading its field values on cleanup
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-09 15:21:46 +02:00
Tim Ramlot
f16a3f56d1
replace usage of wait.PollImmediate
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-09 15:20:45 +02:00
jetstack-bot
50ac858898
Merge pull request #6036 from irbekrm/fix_trivy_vulns
Fix trivy vulns
2023-05-09 11:09:48 +01:00
irbekrm
b8029dc758 Fix trivy vulnerabilities
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-09 09:51:09 +01:00
Tim Ramlot
d656b2d9da
replace deprecated PollImmediateUntil with PollUntilContextCancel
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-07 10:15:46 +02:00
Tim Ramlot
2687b02e3f
update dependencies and LICENSE files
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-05 18:08:42 +02:00
Tim Ramlot
5091a3bff4
use same logging flags for every cli and simplify flag logic
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-05 18:08:29 +02:00
irbekrm
7f0766e305 Update licenses
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-05 16:32:25 +01:00
irbekrm
0d64973359 Fix otel incompatibilities
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-05 16:32:25 +01:00
Luca Comellini
b52ed6303d Bump sigs.k8s.io/controller-runtime
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-05 16:32:25 +01:00
Luca Comellini
1bfc131e6a Bump sigs.k8s.io/controller-tools to v0.12.0
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-05 16:32:25 +01:00
Luca Comellini
a57c4abb14 Bump k8s.io dependencies
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-05 16:32:25 +01:00
jetstack-bot
a64088792d
Merge pull request #5991 from inteon/pr/JoshVanL/4810
Server Side Apply: Adds support for CA Injector controller
2023-05-05 14:21:07 +01:00
jetstack-bot
5035dda25e
Merge pull request #6006 from vidarno/cache-private-key-hash-on-issuer-status
Cache private key hash on issuer status
2023-05-05 08:05:07 +01:00
irbekrm
a45a8b3a39 Adds a package comment, fixes imports
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-04 12:53:50 +01:00
irbekrm
206b6def1e Make external DNS webhook tests importable again
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-04 12:40:06 +01:00
vidarno
a1f156c2b6 Merge branch 'cert-manager:master' into cache-private-key-hash-on-issuer-status
Signed-off-by: vidarno <>
2023-05-02 11:58:18 +02:00
vidarno
92da674e9a Update logic in function IsKeyCheckSumCached to compare private key with hash in status field of CRD instead of from Secret
Signed-off-by: vidarno <>
2023-04-29 09:13:54 +02:00
Tim Ramlot
349aaf666b
resolve feedback
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-04-28 15:07:28 +02:00
Tim Ramlot
29e22e3900
account for pod not yet existing
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-04-28 13:05:18 +02:00
Tim Ramlot
f69dc581ea
remove custom mount approle, since all approles are now custom mounts
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-04-28 13:05:18 +02:00
Tim Ramlot
42e6282d02
use cluster-wide shared Vault instance
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-04-28 13:05:18 +02:00