Commit Graph

48 Commits

Author SHA1 Message Date
James Munnelly
e7dea9f2a2 Replace all references to pkg/internal with internal
Signed-off-by: James Munnelly <jmunnelly@apple.com>
2021-10-21 12:27:04 +01:00
Ashley Davis
c67c2c4f47
static analysis: pkg/controller
fixes the following issues:

pkg/controller/acmeorders/util.go:84:6 deadcode `hashChallenge` is unused
pkg/controller/certificaterequests/approver/approver.go:72:14 staticcheck SA4021: x = append(y) is equivalent to x = y
pkg/controller/certificaterequests/vault/vault_test.go:535:21 errcheck Error return value of `controller.Register` is not checked
pkg/controller/certificates/trigger/policies/policies.go:121:26 gosimple S1039: unnecessary use of fmt.Sprintf
pkg/controller/clusterissuers/sync_test.go:55:12 errcheck Error return value of `c.Register` is not checked
pkg/controller/ingress-shim/sync.go:301:2 gosimple S1005: unnecessary assignment to the blank identifier

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2021-05-21 12:03:47 +01:00
irbekrm
a42771b7e4 Adds a bunch of comments for exported types
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 10:19:43 +01:00
joshvanl
e05adbf06b Remove expected events when Ready Denied condition set
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-09 18:20:07 +01:00
joshvanl
50a84eaf1d Sets the Ready condition to False when a request is Denied
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-09 15:34:32 +01:00
joshvanl
32d0c5af4e Updates Approved/Denied tests for new reasons
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-17 13:10:39 +00:00
joshvanl
a3e63b1787 Update CertificateRequest controllers to use new Denied type, and add
tests for when a CertificateRequest is denied

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-17 13:10:39 +00:00
joshvanl
e62e8c517b Updates CertificateRequest signer tests to check Approved behaviour
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-17 13:10:39 +00:00
Maartje Eyskens
ab0cd57dc5 Use The cert-manager Authors.
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens
1788a9d758 Update copyright to cert-manager project
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
Richard Wall
81eb53f597 ./hack/update-all.sh
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall
a70298180a Run a script to update v1alpha2 usage to v1
Script is available at https://github.com/jetstack/cert-manager/pull/3201

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
Maartje Eyskens
827ce9c5ad Revert log levels on errors
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:42 +02:00
Maartje Eyskens
86dee5ed41 Set error log levels
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:41 +02:00
Maartje Eyskens
fecd0b3518 Set all log levels for info
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:41 +02:00
JoshVanL
de7aaa84d3 Update CertificateRequest controller unit tests
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-19 22:09:01 +00:00
JoshVanL
d6248d20bd Make vault issuer to point to resource namespace over certificaterequest
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-13 11:02:43 +00:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
James Munnelly
f466aeea88 Fix govet warnings
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-27 12:07:08 +01:00
James Munnelly
973f4aa424 Update codebase for external dependencies
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-26 12:52:43 +01:00
JoshVanL
e1875bc8c5 Updates apis to v1alpha2/meta
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 18:20:56 +01:00
JoshVanL
f2f5fccb85 Addresses comments and makes vault auth pointers
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:54:48 +01:00
JoshVanL
05b5f44ff6 Updates vault certificaterequest controller test
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:43:19 +01:00
James Munnelly
bf9fbea23f Update codebase for new meta apigroup
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 19:25:04 +01:00
James Munnelly
58754abf37 Refactor codebase for v1alpha2
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
1b8a286206 Rename Setup->Init and use Start to start informers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-22 13:11:33 +01:00
James Munnelly
6052e0558e Refactor base controller and allow Running additional informers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-21 13:22:57 +01:00
JoshVanL
efe1d4e670 Use DefaultCertDuration in ./pkg/api/util
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-19 16:04:12 +01:00
JoshVanL
ec204def7e Updates vault CR controller tests to include Sync
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-14 23:40:37 +01:00
JoshVanL
6e983fd7e6 Refactors CA cr controller to use sync
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-14 18:17:26 +01:00
JoshVanL
b11d69afa6 Update reporter in vault CR controller to use new signature
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:40:59 +01:00
JoshVanL
d588d5feba Improve code flow and remove unused issuer helper in vault cr controller
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
5f70998acb Cleans up some code and clearer naming
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
25f374da19 Fix pkg/internal/vault/fake
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
f6075035ee Move pkg/internal/internal.go into ./pkg/internal/vault
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
ea84dfdb2b Code organisation and cleaning up code
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
1bbdd03bfe Move DefaultCertDuration to pkg/util/api
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
cefd45b7de Rebase vault CR controller to use new reporter
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:35 +01:00
JoshVanL
179fc0349b Adds issuer to CR sign function
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
635aae6ffc Fix vault duration panic + util.CertDuration to default
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
779c07baad Fix circular dependency
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
a8e7584b36 Adds unit tests to vault CR controller
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
bf133665a3 Both CR controller and legacy issuer use new vault client for signing
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
5923c0bdfe Adds new internal vault client pkg
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
ad5e109983 Adds initial cr vault unit tests
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
312a050560 Fixes CR sync api reporting
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:37:06 +01:00
JoshVanL
356953c476 Adds status reports to vault sign method
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:36:43 +01:00
JoshVanL
60b349e162 Adds initial vault CR controller
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-08-13 23:34:17 +01:00