Commit Graph

64 Commits

Author SHA1 Message Date
joshvanl
f21a947523 Adds comment as to why the GetAuthorization is called instead of
GetChallenge

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-16 14:44:38 +01:00
joshvanl
f83f02cc8b Replace GetChallenge call in acmechallenge controller to
GetAuthorization

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-15 16:05:37 +01:00
jetstack-bot
06b68d35e0
Merge pull request #3835 from RinkiyaKeDad/3620_constants_in_eventf
chore: used constants for string literals when recording new events
2021-04-13 15:14:11 +01:00
RinkiyaKeDad
0b87eeae97 added reason prefix for all
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-13 16:40:56 +05:30
RinkiyaKeDad
bba7c1011d added prefix and made constants public
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-08 12:17:15 +05:30
RinkiyaKeDad
ab912ef120 chore: added constants for non repeating ones also
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-01 15:46:54 +05:30
RinkiyaKeDad
067f6ac1e4 chore: used constants for repeated string literals in record.EventRecorder.Eventf function calls
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-01 13:00:40 +05:30
joshvanl
18ae2295f9 Pass context through to client calls in controllers and acme issuer
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-31 20:34:12 +01:00
Salman
572bfb9111 Replace reflect.DeepEqual with semantic equality check
Signed-off-by: salmanahmed404 <salmanahmed404@gmail.com>
2021-03-27 12:49:14 +05:30
Maartje Eyskens
ab0cd57dc5 Use The cert-manager Authors.
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens
1788a9d758 Update copyright to cert-manager project
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
Matthias Frey
2f2253afaf make propagation check period configurable
Signed-off-by: Matthias Frey <freym@users.noreply.github.com>
2020-09-24 11:28:49 +02:00
Maartje Eyskens
5aba6f956b Fix ACME
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-20 14:28:06 +01:00
Richard Wall
a70298180a Run a script to update v1alpha2 usage to v1
Script is available at https://github.com/jetstack/cert-manager/pull/3201

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
Maartje Eyskens
827ce9c5ad Revert log levels on errors
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:42 +02:00
Maartje Eyskens
86dee5ed41 Set error log levels
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:41 +02:00
Maartje Eyskens
fecd0b3518 Set all log levels for info
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:41 +02:00
JoshVanL
92eb8d0957
Refactor controllers to use new instrumented metrics that's baked into
all controllers

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:43:56 +01:00
James Munnelly
b126a0c0e5 Use acme AccountRegistry throughout and tidy up ACME setup code
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-13 13:14:46 +01:00
James Munnelly
881b886049 Update Kubernetes API client call-sites
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-03-26 12:58:50 +00:00
James Munnelly
641fe0da7c Switch to using upstream golang.org/x/crypto
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
00ad3446ef Surface ACME Challenge failure reason on Challenge resource if available
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-29 09:22:08 +00:00
James Munnelly
ef55bd5807 Mark Order & Challenge resources as Errored if 4xx error is received
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 09:30:17 +01:00
James Munnelly
e3b1e9bdb9 Call UpdateStatus before Update when finalizing Challenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
9a807be80a Fix not returning updateErr if updating status failed
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
8bf08237f7 Migrate acmechallenges and acmeorders to use UpdateStatus
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
b6803a2185 Fully update challenge and order in controller sync instead of UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
James Munnelly
2868b4a7b7 Update pkg/controllers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-23 10:07:53 +01:00
James Munnelly
58754abf37 Refactor codebase for v1alpha2
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
e8d1bc608e Update for ACMEChallengeType type
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-10 14:45:26 +01:00
James Munnelly
32bc10710e Update use of featuregate package
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-20 01:57:24 +01:00
James Munnelly
442789113a Refactor controllers to not reference BaseController
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-19 15:11:06 +01:00
jetstack-bot
48cd58b23f
Merge pull request #1722 from cheukwing/issue-1003
Add BaseController as a refactoring of common controller code
2019-06-17 19:27:57 +01:00
Michael Tsang
0add074b7f Add basecontroller to other controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-23 17:32:33 +01:00
Michael Tsang
7d67ae466e Remove metrics field from controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 11:06:11 +01:00
Michael Tsang
455f6ebab4 Use ControllerName as label value
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 16:49:39 +01:00
Michael Tsang
f2e57a1c95 Add ControllerSyncCallCount metric
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 14:22:16 +01:00
James Munnelly
bbf4012e12 Handle expired challenge responses in acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 18:57:26 +01:00
jetstack-bot
570751236d
Merge pull request #1585 from munnerz/validate-caa-feature-gate
Add feature gate for ValidateCAA functionality and default it to off
2019-04-30 14:17:48 +01:00
James Munnelly
49f587c844 Set Reason field on ACME challenges during Present/CleanUp
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 10:25:33 +01:00
James Munnelly
9906c0d946 Add feature gate for ValidateCAA functionality and default it to off
To help avoid issues with the ValidateCAA functionality, this disables
the CAA check by default and adds a new --feature-gates=ValidateCAA=true
option to cert-manager-controller to allow enabling the previous
behaviour in v0.7.0 and v0.7.1.

Once issues with CNAMEd DNS names pointing to internal nameservers
are resolved, this option will be defaulted to on.

Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-25 15:10:05 +01:00
James Munnelly
eaeefdf5b2 Update acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-03-12 14:24:51 +00:00
James Munnelly
2f30258f0e Switch to klog
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-22 12:34:02 +00:00
Daniel Morsing
a01514ad63 use configured nameservers for CAA validation
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-11 12:05:18 +00:00
Daniel Morsing
bb853e5e79 first draft CAA checking
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-05 14:25:10 +00:00
Daniel Morsing
b0a9b8276c surface self-check errors in challenge resource
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-21 11:49:46 +00:00
Daniel Morsing
88d811b34c change Check function signature
This makes the check function into a simple precondition

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-17 16:45:03 +00:00
James Munnelly
21c7b2e13f Increase ACME control loop max back-off. Increase create order back-off to 1h. Fire Event when Order fails.
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-10 22:07:48 +00:00
Daniel Morsing
cc946c0b45 Populate reason field regardless
If we have an error, then tell people about it.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:54:43 +00:00