weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
7,113 Commits 45 Branches 0 Tags 96 MiB
aeae4b35fc
Commit Graph

604 Commits

Author SHA1 Message Date
joshvanl
331e178f60 Wires up ctl x create csr command 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-06-15 15:37:28 +01:00
joshvanl
02666fde10 Adds create CertificateSingingRequest form Certificate command 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-06-15 15:17:35 +01:00
joshvanl
72800ae0f2 Wires up the SelfSigned CertificateSigningRequest controller 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-06-14 10:19:28 +01:00
irbekrm
4413774944 Removes unused Bazel deps 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-06-01 08:49:30 +01:00
irbekrm
d79a058b14 Allow controlling whether cgo is enabled via flags to Bazel 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-06-01 08:47:06 +01:00
joshvanl
9e1b0342d0 Updates with review comments 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-27 18:48:50 +01:00
joshvanl
60d5974115 Moves CertificateSigningRequest controller to feature gate flag 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-27 12:00:56 +01:00
joshvanl
62dee4783e Adds CertificateSigningRequest CA Issuer controller as optional 
controller

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-27 00:32:24 +01:00
irbekrm
b539cbea89 Use ConfigmapsLeases Multilock for controller's leader election 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-17 18:19:38 +01:00
Tamal Saha
7b63788f52 Cleanup codegen script 
Signed-off-by: Tamal Saha <tamal@appscode.com>
 2021-05-17 08:11:19 -07:00
Jake Sanders
79d8d9cb7b
Revert "Merge pull request #3724 from inteon/istio-virtualservice-for-http01" 
This reverts commit 80f27739b5, reversing
changes made to 96604d02a3.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-11 14:50:25 +01:00
Jake Sanders
423e82b65b
Revert "Merge pull request #3939 from JoshVanL/istio-api-to-internal-apis" 
This reverts commit f2a74ade5e, reversing
changes made to 7ff54e61e9.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-11 14:50:23 +01:00
joshvanl
01716e2907 Fixes stutter: istio.IsIstioInstalled -> istio.IsInstalled 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-29 11:42:21 +01:00
joshvanl
00ceff3421 Update bazel 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-29 11:36:49 +01:00
joshvanl
3af22cf6c6 Move istio util duncs to pkg/util/istio 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-04-29 11:35:41 +01:00
Inteon
2d7dfcb462 start DynamicSharedInformerFactory unconditionally; only listen for VirtualServices conditionally 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-04-28 09:20:49 +02:00
Inteon
624e2b9e69 add ACME HTTP01 Istio support 
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
 2021-04-28 09:19:53 +02:00
joshvanl
56a604c6f0 Init plugins in webhook cmd 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl
109b3e0b28 Rename Wehook's API server host flag from --master to --api-server-host 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl
59049ee58a Add SubjectAccessReview client to validation registration on webhook start. Make API address configurable 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 17:26:28 +00:00
joshvanl
8f5b03427c Fix options_test.go boilerplate header 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 11:28:01 +00:00
joshvanl
6ef840972c Change controller options to return a set of enabled controllers, and 
log enabled controllers on start

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 11:28:01 +00:00
joshvanl
5c3e02d7a5 Changes the controllers flag to allow disabling controllers. This is the 
same behaviour as kube-controller-manager

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 11:28:01 +00:00
joshvanl
0382c9d8b2 Adds a cert-manager-controller flag to disable controllers, for example, 
the certificaterequests-approver

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-26 11:28:01 +00:00
jetstack-bot
a8c75fab1a
Merge pull request #3773 from JoshVanL/certificate-revision-history-limit 
Certificate revision history limit
 2021-03-26 11:13:58 +00:00
joshvanl
9ab0a5a77c Fix command comments 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-25 19:08:21 +00:00
joshvanl
f25be73f73 Adds comments for the Reason and Message options of the ctl approve and 
deny commands

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-24 17:17:42 +00:00
joshvanl
db617f0772 Adds kubectl cert-manager [approve|deny] CLI commands 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-23 17:30:09 +00:00
joshvanl
6957bc31df Adds the CertificateRequest approver controller to 
cert-manager-controller

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-17 13:10:39 +00:00
joshvanl
c4b918c0aa Adds RevisionManager controller to default enabled controller 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-15 14:54:35 +00:00
jetstack-bot
70c66e02a0
Merge pull request #3641 from JoshVanL/certificate-request-identity 
CertificateRequest UserInfo fields
 2021-03-15 14:26:15 +00:00
joshvanl
39a50a1903 Updates unit certificate controller tests to include ObservedGeneration 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-03-04 17:04:09 +00:00
Jake Sanders
4c935a2706
Fix expired certificate test 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-02-26 11:06:25 +00:00
irbekrm
b852e97ffb Removes the deprecated renew-before-expiry flag 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-02-21 10:22:25 +00:00
joshvanl
33f3fe473c Rename webhook SchemeBackedMutator -> RegistryBackedMutator 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-02-10 09:39:52 +00:00
joshvanl
90f0869899 Updates webhook command to use new mutating registry 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-02-08 19:23:15 +00:00
irbekrm
34fd9e9fef Makes /cmd/cainjector/main more DRY 
reuses util.ContextWithStopCh to create a context with cancel func

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-01-27 13:32:23 +00:00
irbekrm
1abc7107ca Passes a single context with cancel func to all the kubectl plugin commands 
Signed-off-by: irbekrm <irbekrm@gmail.com>

Don't duplicate the existing ContextWithStopCh function

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-01-27 13:06:34 +00:00
jetstack-bot
26afeceb2b
Merge pull request #3457 from meyskens/inspect-secret 
Add `inspect secret` command
 2021-01-22 16:19:03 +01:00
Maartje Eyskens
b2bd401b91 Outuput error 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-20 10:32:45 +01:00
Maartje Eyskens
aa482212c1 Use templates (not fully yet) 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-19 18:13:26 +01:00
Maartje Eyskens
83881df0db Sort imports 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2021-01-19 15:42:25 +01:00
Julien ALEXANDRE
f8fbea38b3
Add flags to configure cainjector leader election 
This commit enables users to customize the behavior of the cainjector
regarding leader election by adding `--leader-election-lease-duration`,
`--leader-election-renew-deadline` and `--leader-election-retry-period`
flags. These flags are already available on the controller.

Prior to this change, the values of these options were inherited from
controller-runtime. This commit keeps the same defaults for the
cainjector, for backward compatibility, even though they differ from
those of the controller.

Signed-off-by: Julien ALEXANDRE <22328659+ndrpnt@users.noreply.github.com>
 2020-12-19 18:00:54 +01:00
Maartje Eyskens
a5732221f4 Fix tests 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:09:39 +01:00
Maartje Eyskens
d65a9a3479 Update copyright 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:04:08 +01:00
Maartje Eyskens
f7f766b077 Fix describe test 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:13 +01:00
Maartje Eyskens
dbf5dc6804 Add boilerplate 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:13 +01:00
Maartje Eyskens
df7bce9b33 Add tests 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:13 +01:00
Maartje Eyskens
214e607b07 Clean up code 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:13 +01:00
Maartje Eyskens
f671c811cf Improve logic 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:13 +01:00
Maartje Eyskens
bedb95a0a4 Add revocation checks 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:13 +01:00
Maartje Eyskens
654f16ec14 WIP add inspect secret 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-15 17:02:12 +01:00
jetstack-bot
cdc53b65cb
Merge pull request #3500 from meyskens/update-copy 
Update copyright to cert-manager project
 2020-12-15 10:12:31 +00:00
Maartje Eyskens
ab0cd57dc5 Use The cert-manager Authors. 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-11 19:04:13 +01:00
jetstack-bot
2c521609de
Merge pull request #3477 from tharun208/feat/profiling 
Added profiling for controller
 2020-12-11 14:11:10 +00:00
Maartje Eyskens
1788a9d758 Update copyright to cert-manager project 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-12-08 19:04:49 +01:00
Tharun
b67da63a4e Added profiling for controller 
Signed-off-by: Tharun <rajendrantharun@live.com>
 2020-11-22 12:15:52 +05:30
Richard Wall
a33abd2060 Plumb through the flag provided defaultRenewBeforeExpiryDuration 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 12:44:18 +00:00
Richard Wall
cc1412b252 Deprecate the --renew-before-expiry-duration flag 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-11-19 12:44:18 +00:00
Maartje Eyskens
7d1cd33081 Make resyncPeriod constant 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-10-22 10:25:10 +02:00
Maartje Eyskens
00d2b3b79e Set the resync period to 10 hours 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-10-21 15:19:22 +02:00
Maartje Eyskens
560eac4b06
Update cmd/controller/app/options/options.go 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>

Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
 2020-10-16 16:43:13 +02:00
Maartje Eyskens
232f21db26 Validate API values not being 0 + following k8s naming + defaults 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-10-16 13:08:26 +02:00
Maartje Eyskens
7c87e93950 update burst description 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-10-14 17:49:19 +02:00
Maartje Eyskens
ebadd4cd28 Fix defaults, description and add validation 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-10-14 17:46:09 +02:00
Maartje Eyskens
5dfb4d409b Make Kubernetes API QPS throtteling configurable 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-10-14 17:16:44 +02:00
Matthias Frey
2f2253afaf make propagation check period configurable 
Signed-off-by: Matthias Frey <freym@users.noreply.github.com>
 2020-09-24 11:28:49 +02:00
jetstack-bot
a4394510e2
Merge pull request #3275 from wallrj/3251-cainjector-3 
Load cainjector controllers independently
 2020-09-18 17:14:06 +01:00
Richard Wall
c3e79865ca Exit(1) and explain what causes the context to be cancelled 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-18 10:24:10 +01:00
Richard Wall
392ed06cfc Explain why we start the two controllers in separate goroutines 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-18 10:21:21 +01:00
Richard Wall
4fd5cd6b3c Avoid launching controller goroutines during shutdown of unelected 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-18 10:15:14 +01:00
Richard Wall
e2765f720a Remove debug log 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-18 10:04:28 +01:00
Richard Wall
b772f3295b Use cancellable contexts and errgroups 
...to control the starting and stopping of controllers and caches

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-17 09:37:05 +01:00
Richard Wall
81874895b0 Use NewUnmanaged and separate caches for each controller 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-11 10:09:27 +01:00
Richard Wall
bcff4edb0f Run both controllers in a single goroutine with a single manager 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-10 13:54:50 +01:00
Josh Soref
efd26e6b4f
Add missing quote to help 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
 2020-09-09 15:32:59 -04:00
Richard Wall
ba02ea4120 Revert "Refactor the cainjector to only have 1 leader election" 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-09-04 16:54:16 +01:00
jetstack-bot
57034dc1e4
Merge pull request #3213 from hzhou97/add_more_events_output 
Ctl command status certificate: Add Events of Issuer and Secret to output
 2020-08-27 16:04:36 +01:00
JoshVanL
c83ef5ee77 Fixes client-go logs to use infof 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-08-27 11:04:09 +02:00
Haoxiang Zhou
4ccf8ebdb7 Return error thrown when looking for events 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-26 16:29:33 +02:00
Haoxiang Zhou
5f423a442e Create Events for integration and unit tests 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-26 16:28:28 +02:00
Haoxiang Zhou
a1ce1cefb5 Add Events of Issuer and Secret to output 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-26 15:31:53 +02:00
jetstack-bot
85a9044c0c
Merge pull request #3205 from JoshVanL/ctl-convert-list 
Add support for ctl convert over a list
 2020-08-21 12:21:43 +01:00
JoshVanL
3ed1dfdc31
Updates deps 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-08-21 11:05:23 +01:00
JoshVanL
d3e27905eb
Remove bad error text output 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-08-21 10:48:21 +01:00
JoshVanL
1c9e955407
Add support for ctl covert with List 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-08-21 10:40:57 +01:00
Richard Wall
1254179f3a Use V1 API resources in ctl create certificaterequest tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-08-20 17:12:15 +01:00
Richard Wall
bd94bf92a5 cmapiv1 > cmapi 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-08-20 14:28:06 +01:00
Richard Wall
b638954b03 Fix ./cmd/ctl and tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-08-20 14:28:06 +01:00
Richard Wall
81eb53f597 ./hack/update-all.sh 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-08-20 14:28:06 +01:00
Richard Wall
a70298180a Run a script to update v1alpha2 usage to v1 
Script is available at https://github.com/jetstack/cert-manager/pull/3201

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-08-20 14:26:51 +01:00
Richard Wall
0388599674 Rename import to make way for corev1 and v1 api imports later 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2020-08-19 15:04:54 +01:00
jetstack-bot
fff2778ae2
Merge pull request #3187 from meyskens/cainject-le 
Refactor the cainjector to only have 1 leader election
 2020-08-18 10:49:43 +01:00
Haoxiang Zhou
6c26e0d821 Add Challenge output and update tests 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-17 16:15:28 +02:00
Haoxiang Zhou
a77f4be62b Use assert.Equals instead of reflect.DeepEquals to compare status structs 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-17 12:19:39 +02:00
Maartje Eyskens
8b7552cec1 Refactor the cainjector to only have 1 leader election 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-17 11:16:48 +02:00
Haoxiang Zhou
62700fceef Add unit tests testing building CertificateStatus struct from gathered Data 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-14 09:35:09 +02:00
Haoxiang Zhou
5a8f3371fa Refactor Run() into multiple functions for better testing 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-14 09:35:09 +02:00
Haoxiang Zhou
894745be7a Refactor out unnecessary helper functions for IssuerStatus 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-14 09:35:09 +02:00
Haoxiang Zhou
9a1da3ed71 Not creating OrderStatus at all if not ACME Issuer 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-14 09:35:09 +02:00
Haoxiang Zhou
d4877695da Use GenericIssuer to clean up Run function 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-14 09:35:09 +02:00
jetstack-bot
e1791b0b0e
Merge pull request #3154 from hzhou97/add_order_output 
Ctl command `status certificate`: Add order output
 2020-08-12 14:13:59 +01:00
Maartje Eyskens
3259fdfe9b Implement feedback 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:42 +02:00
Maartje Eyskens
827ce9c5ad Revert log levels on errors 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:42 +02:00
Maartje Eyskens
bdc8b346c6 Log NS as info 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:42 +02:00
Maartje Eyskens
5d4869b20e Fix formatted logs 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:41 +02:00
Maartje Eyskens
86dee5ed41 Set error log levels 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:41 +02:00
Maartje Eyskens
fecd0b3518 Set all log levels for info 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:41 +02:00
Maartje Eyskens
9dd00905e9 Update klog 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>

klog v2

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
 2020-08-12 10:59:41 +02:00
Haoxiang Zhou
a1f7a1fcc3 Review implementation 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-06 18:21:48 +01:00
Haoxiang Zhou
8c9eb43102 Clean up 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-06 16:37:07 +01:00
Haoxiang Zhou
196959a05f No output about Orders if non-ACME Issuer 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-06 14:37:54 +01:00
Haoxiang Zhou
3913fa981f Add output about Order of Certificate 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-06 12:02:26 +01:00
Haoxiang Zhou
8b6aad2c85 Populate CertificateStatus struct directly 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-04 12:55:33 +01:00
Haoxiang Zhou
f971e49400 Update unit test 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-03 12:07:14 +01:00
Haoxiang Zhou
6afc1d6cfa Change status cert to use structs 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-03 11:19:13 +01:00
Haoxiang Zhou
33bb65c9e1 Add NewTabWriter function 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-03 10:11:57 +01:00
Haoxiang Zhou
d490e52a5e Define builder and String functions for status struct 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-08-03 10:09:36 +01:00
Haoxiang Zhou
95a4f8f477 Define structs containing info for status command 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-31 12:17:29 +01:00
Haoxiang Zhou
25472462a3 Handle unknown values of Ext Key Usage if added in future 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-31 09:45:29 +01:00
Haoxiang Zhou
ef95d15642 Updated tests with output for secret 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-30 17:54:57 +01:00
Haoxiang Zhou
6ddcef818e Added unit test for key usage to string funtions 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-30 17:50:50 +01:00
Haoxiang Zhou
7bdc1eb237 Add output for secrets 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-29 12:24:04 +01:00
Haoxiang Zhou
f3bfc6d6ba Use Fprintf correctly 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-29 12:22:44 +01:00
jetstack-bot
ec6d2bb3e5
Merge pull request #3120 from hzhou97/add_issuer_output 
Ctl status certificate command: Add issuer output and creation time
 2020-07-29 12:13:20 +01:00
jetstack-bot
8434c6a941
Merge pull request #3094 from hzhou97/create_cr_new_test 
Create cr command: change and add integration tests
 2020-07-27 15:56:14 +01:00
Haoxiang Zhou
0c3eeaed96 Handle Issuers from non cert-manager groups 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-27 15:41:13 +01:00
Haoxiang Zhou
0d449ea76d Add tests for non-existing issuer; Review implementation 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-27 14:20:49 +01:00
Haoxiang Zhou
3b6b725c5d Added Certificate creation time to output 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-24 16:03:29 +01:00
Haoxiang Zhou
c4f7e27413 Add Issuer/ClusterIssuer output 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-24 15:32:34 +01:00
Haoxiang Zhou
cc40aad0ad Fix bug of using overwritten pointer when searching for CR 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-24 14:20:29 +01:00
Haoxiang Zhou
e9cdcbd3c4 Remove unnecessary PrefixWriter implementation 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-23 09:47:30 +01:00
Haoxiang Zhou
57ff60e35c Added more unit tests for Run function 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 17:29:47 +01:00
Haoxiang Zhou
d65e95eaeb Refactor TestCtlCreateCRBehaviourBeforeAnythingIsCreated to unit tests 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 16:51:48 +01:00
Haoxiang Zhou
8525a26bd2 Format the Events output with tabwriter 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 12:31:37 +01:00
Haoxiang Zhou
35e1d33ee4 Review implementations 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 09:45:17 +01:00
Haoxiang Zhou
f95251a5da Output Events of CR as well 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 09:45:17 +01:00
Haoxiang Zhou
a428472be7 Create implementation of PrefixWriter interface in describe package of kubectl 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 09:45:17 +01:00
Haoxiang Zhou
20c5e2696b Output the Events of Certificate 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-22 09:45:17 +01:00
Haoxiang Zhou
f061f15e93 Review implementations 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-21 15:57:02 +01:00
Haoxiang Zhou
f5aeb56400 Validate errors if from-certificate-file flag is empty 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-17 17:48:02 +01:00
Haoxiang Zhou
28b9e4ba48 Added unit tests for Validate 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-17 17:47:50 +01:00
Haoxiang Zhou
8b89873199 Smaller review implementations 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-17 13:53:39 +01:00
jetstack-bot
48eb68dd79
Merge pull request #3090 from hzhou97/add_cr_output 
Ctl command status certificate: Add CR output
 2020-07-16 10:31:48 +01:00
Haoxiang Zhou
7657b5e042 Add unit tests for string formatting functions 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-14 18:06:09 +01:00
Haoxiang Zhou
d808edaa08 Gather all CR info logic into function 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-14 17:43:06 +01:00
Haoxiang Zhou
69baa14a3e Add example use; cleanup and comments 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 15:49:32 +01:00
Haoxiang Zhou
cbf8da3197 Handle case where revision of cert not set yet 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:54:41 +01:00
Haoxiang Zhou
f5ebea1b27 Basic output for CR owned by Cert 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:54:41 +01:00
Haoxiang Zhou
864bb3ab59 Command output to stderr, check both ready condition and length of status.certificate 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
a9e84ded4b Removed output in util function 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
e74d0fd954 Refactor Fetch function to have no API call 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
16a1d927e4 Fixed bug of assigning to new variable instead of correct one 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
2a2c637d3a Error when Ready condition is true but status.certificate is empty 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
76272f8acd Inline polling/waiting for CR to be ready 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
492fd623ec Changed flag to output-certificate-file 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
735be40fdc Improved help output 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
c2c62fe124 Added flag to specify timeout when waiting on certificate 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
9583f7c0a3 Use %w to format errors, clean-up 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
6580010a14 Store certificate to file if flags are set 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
a421e5beb5 Added flags to wait for, fetch and store certificate from CR 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
Haoxiang Zhou
55070d32ba Add util package 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-10 13:23:52 +01:00
jetstack-bot
d4a7dfa730
Merge pull request #3026 from hzhou97/status_command 
Basic `status certificate` ctl command
 2020-07-10 11:07:08 +01:00
hzhou97
009b87431c Changed long description for command 
Co-authored-by: James Westby <jw+debian@jameswestby.net>
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-09 15:47:06 +01:00
jetstack-bot
f80d79c268
Merge pull request #2909 from JoshVanL/2952-move-to-cobra 
Move all commands into cobra
 2020-07-07 12:30:04 +01:00
Haoxiang Zhou
e0b4cb176e Small review changes 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-06 11:17:31 +01:00
Haoxiang Zhou
58ec3c0bc7 Output NotBefore and RenewalTime 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 15:45:40 +01:00
Haoxiang Zhou
25a771f985 Clean-up from reviews 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
e43ec083c0 Output multiple lines for dns names and added example usage; clean-up 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
ff71b2976c Handle non-set NotAfter in output 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
2f7fa5e419 Changed output for conditions 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
3e9c78dfc6 Restructure to 'status certificate' instead of 'certificate status' 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
5d09aa814f Output incrementally instead of using one big format 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
8804fd9171 Handling basic outputs for multiple Status.Conditions 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
0369c745b1 Output for ready and up-to-date certificates 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
Haoxiang Zhou
bc53b7b0aa Added scaffold for certificate status command 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-07-02 14:27:41 +01:00
James Munnelly
9e2d6a514b Move expcertificates into certificates package 
Signed-off-by: James Munnelly <james@munnelly.eu>
 2020-07-01 12:16:25 +01:00
James Munnelly
2280480c02 Remove old certificates controller 
Signed-off-by: James Munnelly <james@munnelly.eu>
 2020-07-01 11:46:13 +01:00
jetstack-bot
4018712a53
Merge pull request #3036 from hzhou97/create_cr_scheme 
Use ctl.Scheme in create cr ctl command
 2020-06-26 14:50:39 +01:00
JoshVanL
8f924151a3
Change acmesolver parameters and catch stopCh for server shutdown 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:47:37 +01:00
JoshVanL
d45847d302
Reverse webhook cmd run parameters 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:47:24 +01:00
JoshVanL
c3e2aae551
Fix binary names, printing errors, and help messages 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:47:11 +01:00
JoshVanL
7c831c537e
Add missing webhook flags and make options pointer 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:47:07 +01:00
JoshVanL
1107390b23
Fix webhook testing cmd 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:46:55 +01:00
JoshVanL
7c26448442
Fix controller bug for not exiting on option error 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:46:49 +01:00
JoshVanL
964a9b27dc
Move the webhook runtime into cobra 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:46:48 +01:00
JoshVanL
a6ae3418f6
Move the acmesolver runtime into cobra 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
 2020-06-26 13:46:45 +01:00
James Munnelly
1adfe16690 Bulk fix of non-test staticcheck failures 
Signed-off-by: James Munnelly <james@munnelly.eu>
 2020-06-26 12:25:08 +01:00
Haoxiang Zhou
8db33a0c43 Use ctl.Scheme instead of webhook.Scheme 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-26 12:02:49 +01:00
jetstack-bot
83f391c177
Merge pull request #3018 from hzhou97/fix-convert-cmd 
Fix ctl convert cmd
 2020-06-23 18:14:12 +01:00
jetstack-bot
2f4c57e178
Merge pull request #2957 from hzhou97/create_cr_cmd 
Add Create CertificateRequest ctl command
 2020-06-23 17:21:12 +01:00
Haoxiang Zhou
24404aa1eb Added new scheme to use for ctl commands 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-23 17:18:56 +01:00
Haoxiang Zhou
7e4fa1ab13 Removed unnecessary variables and 'AddToScheme's; Builder doesn't continue on error 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-19 10:29:42 +01:00
Haoxiang Zhou
a98240c6f9 Changed directory set-up for tests, review changes 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-18 16:47:10 +01:00
Haoxiang Zhou
12ef535648 Use webhook's scheme to read in objects in internal api version 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-18 10:22:25 +01:00
Haoxiang Zhou
a628f62f2c Changed flag to from-certificate-file 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-16 12:30:28 +01:00
Haoxiang Zhou
3b7284973c Wrtie key to file before creating CR and changed key file permission 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-16 12:24:18 +01:00
Haoxiang Zhou
1a01120fbd Make name of CR a required argument, changed tests accordingly 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-16 12:19:46 +01:00
Haoxiang Zhou
de787796b7 Review changes 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-15 14:22:55 +01:00
Haoxiang Zhou
5a5c3ce053 Change to only have -f flag 
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
 2020-06-11 17:30:59 +01:00