irbekrm
f5ea958317
Issuing controller fails issuances for denied/invalid CRs
...
This is not necessarily a breaking change as this appears to have been the current behaviour in most cases due to the race condition that this commit fixes
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-03-24 15:37:57 +00:00
irbekrm
4c901aefab
Code review comments
...
Adds test conditions to certs via patch API call instead of update to avoid conflicts
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-21 07:33:51 +00:00
irbekrm
739c3298e8
Trigger controller backs off from issuance with an exponential backoff
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-21 07:33:51 +00:00
irbekrm
9824ab0949
certificates-issuing controller sets status.issuanceAttempts when certificate issuance has failed
...
This field tracks the number of continuous failures and is used to implement exponential backoff
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-03-21 07:33:51 +00:00
Ashley Davis
3a055cc2f5
rename all uses of github.com/jetstack/cert-manager
...
This was done by running the following command twice:
```bash
grep -Ri "github.com/jetstack/cert-manager" . | \
cut -d":" -f1 | \
sort | \
uniq | \
xargs sed -i
"s/github.com\/jetstack\/cert-manager/github.com\/cert-manager\/cert-manager/"
```
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-02 09:08:31 +00:00
joshvanl
f1cafae95f
Refactor trigger policies to be more generic and be used by multiple
...
controllers
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-19 14:30:00 +00:00
joshvanl
64d78c6e10
Update certificates controller with new secret manager signatures and
...
tests
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-17 11:24:45 +00:00
irbekrm
ff67b2a9a0
Ignore failed CRs for previous issuance in certificates-issuing controller
...
Issuing controller should only look at 'current' CertificateRequests
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-12-22 14:51:25 +00:00
Jonathan Prates
6e8f74b4f8
tests: add Labels map to the expected secret
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
2021-08-03 01:19:11 +01:00
Maël Valais
26b074241a
issuing controller test: check w.Register error
...
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Richard Wall <richard.wall@jetstack.io>
2021-07-06 12:51:01 +02:00
Maël Valais
37bee71d68
static analysis party: fix errcheck warnings
...
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-06 12:51:01 +02:00
joshvanl
06cffcdf59
Adds Denied check to CertificateRequests in issuing controller to retry
...
denied requests
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-03 13:21:23 +01:00
joshvanl
39a50a1903
Updates unit certificate controller tests to include ObservedGeneration
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-04 17:04:09 +00:00
Maartje Eyskens
ab0cd57dc5
Use The cert-manager Authors.
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens
1788a9d758
Update copyright to cert-manager project
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
Maël Valais
62f8db6e6a
refactor(issuing): PR review: use MustCreateCryptoBundle directly
...
Signed-off-by: Maël Valais <mael.valais@gmail.com>
2020-12-06 14:22:02 +01:00
Maël Valais
17cd05ecab
test(issuing): new test: when req mismatches, cert can't be updated
...
This new unit test highlights an unexpected behavior of the issuing
controller: the issuing controller is updating the certificate's status
when the certificate request has a failure ("Reason = Failed"), but the
controller might have picked up an out-of-date certificate request.
The consequence is that the issuing controller would set the certificate
to "Issuing = False". That happens when a re-issuance is triggered with
an old failing certificate request.
Signed-off-by: Maël Valais <mael.valais@gmail.com>
2020-12-06 14:22:02 +01:00
Richard Wall
a70298180a
Run a script to update v1alpha2 usage to v1
...
Script is available at https://github.com/jetstack/cert-manager/pull/3201
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
JoshVanL
016b566689
Adds Issuer Group to Secret annotation
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-08-06 09:24:37 +01:00
James Munnelly
9e2d6a514b
Move expcertificates into certificates package
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-07-01 12:16:25 +01:00