Commit Graph

1296 Commits

Author SHA1 Message Date
James Munnelly
a365d1c19d Remove old comment
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:35:25 +01:00
James Munnelly
56b1fdd379 Make ACMEAuthorization.Wildcard a *bool
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:35:11 +01:00
James Munnelly
e0e4f9b5ea Only construct ACME client once Issuer resource is Ready
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 10:52:50 +01:00
James Munnelly
ef55bd5807 Mark Order & Challenge resources as Errored if 4xx error is received
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 09:30:17 +01:00
jetstack-bot
1c424dd219
Merge pull request #2171 from dulltz/handle-error
Fix to handle error
2019-10-09 17:19:27 +01:00
James Munnelly
6b19892908 Fix regression in certificates controller setting owner references
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-09 11:33:21 +01:00
dulltz
bd6248805a Fix to handle error
Signed-off-by: dulltz <isrgnoe@gmail.com>
2019-10-09 18:13:42 +09:00
JoshVanL
2e1a534642 The ingress shim checks certificate common names and ensures they are
empty

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 16:57:54 +01:00
jetstack-bot
482eac596a
Merge pull request #2085 from JoshVanL/certificate-URISANs
Adds URISANs field to Certificate
2019-10-03 10:59:47 +01:00
JoshVanL
7d615ff8e4 Remove getting secret from lister in matches spec func
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 10:01:57 +01:00
Ingo Gottwald
be3f1e3fd2 Remove use of deprecated client.MatchingField
Signed-off-by: Ingo Gottwald <in.gottwald@gmail.com>
2019-10-02 20:47:58 +02:00
JoshVanL
dc7cc388e1 Converts acme test to UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:51:37 +01:00
JoshVanL
7965be9b41 Adds from comments
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
9ba973abc8 Rephrase venafi error with no ObjectName
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
80236351f6 Set the venafi ObjectName with the CN->DNS->URI as precedence
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
b6bce10b2f Adds CommonName e2e tests for new behaviour
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
334f90dfac Adds uri_sans to vault parameters
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
66cda5cbd7 Only match for common name in DNS names if common name was given
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
54f8069a78 Make annotation of secret if nil to prevent panic
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
18e0dcdb63 Adds boilerplate copyright to util_test.go
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
13b0584838 Change behaviour to be more relaxed around common names
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
88cadca433 Adds proper checking for common name in e2e tests
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
5cdad4eed3 Updates api types
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
f249888112 Only add common-name annotation if commonName exists
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
dd7213866f Adds validation for URIs to certificate validation
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
832e20ae29 Adds URISANs field to Certificate
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
jetstack-bot
b91b7d8d3f
Merge pull request #2097 from JoshVanL/status-subresource
Adds status sub resource and changes updates
2019-10-02 16:40:11 +01:00
James Munnelly
e3b1e9bdb9 Call UpdateStatus before Update when finalizing Challenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
9a807be80a Fix not returning updateErr if updating status failed
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
8bf08237f7 Migrate acmechallenges and acmeorders to use UpdateStatus
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
259efac9bd Remove 'IngressKey' from certmanager API in favour of a single const
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 10:04:55 +01:00
JoshVanL
5bb452f6e9 Fix info log typo
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-01 16:21:47 +01:00
JoshVanL
b6803a2185 Fully update challenge and order in controller sync instead of UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
de07651142 Remote updatestatus todos and add minimal version to docs
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
JoshVanL
1c4fcdf519 Updates bazel
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-27 13:54:39 +01:00
JoshVanL
4eb6335c76 Support out of tree issuers in ingress-shim
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-27 13:54:39 +01:00
James Munnelly
f466aeea88 Fix govet warnings
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-27 12:07:08 +01:00
jetstack-bot
9cd00ce3f8
Merge pull request #2034 from JoshVanL/e2e-conformance-tests
Extends conformance tests
2019-09-27 00:10:55 +01:00
JoshVanL
869370e226 Cleans up code and naming
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-26 17:35:52 +01:00
JoshVanL
ced21c287f Conformance: Ensure if a certificate is deleted then a new certificate is signed with
same key

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-26 17:34:42 +01:00
James Munnelly
4b1a4fece8 Fix update-codegen for go 1.13
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-26 17:26:43 +01:00
James Munnelly
973f4aa424 Update codebase for external dependencies
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-26 12:52:43 +01:00
JoshVanL
e1875bc8c5 Updates apis to v1alpha2/meta
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 18:20:56 +01:00
JoshVanL
68f9546d05 Update generated
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 14:05:53 +01:00
JoshVanL
9ffaae5bfd Adds review comments
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 14:01:19 +01:00
JoshVanL
9b827ee128 Adds all vault Auth methods to secret checks and stops panic
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:54:48 +01:00
JoshVanL
f2f5fccb85 Addresses comments and makes vault auth pointers
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:54:48 +01:00
JoshVanL
05b5f44ff6 Updates vault certificaterequest controller test
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:43:19 +01:00
JoshVanL
452e42b1c7 Adds internal vault issuer Kubernetes auth types
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:42:02 +01:00