Krzysztof Ostrowski
e35cb361c8
add comments to satisfy linter
...
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
Co-authored-by: Irbe Krumina <irbekrm@gmail.com>
2021-11-04 18:15:46 +01:00
Igor Zibarev
f9ceb8a73e
Fix some lint issues regarding comments
...
References issue #4457
Signed-off-by: Igor Zibarev <zibarev.i@gmail.com>
2021-11-02 13:57:20 +03:00
Jake Sanders
486fc49545
Add fuzzing unit tests for JKS passwords
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-10-29 15:12:51 +01:00
jetstack-bot
f61d534975
Merge pull request #4550 from irbekrm/pprof
...
Pprof
2021-10-26 11:20:40 +01:00
irbekrm
7b6eeff457
Profiler address for controller can now be configured
...
Ensures that pprof is configured for controller in the same way as for cainjector
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-10-26 12:20:42 +03:00
irbekrm
73a696ddb3
Pprof addr for webhook defaults to localhost
...
Also whether it is enabled and the address can now be configured via commandline flags
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-10-26 12:18:32 +03:00
James Munnelly
b3159537e1
Remove unused codegen tags
...
Signed-off-by: James Munnelly <jmunnelly@apple.com>
2021-10-21 15:43:50 +01:00
James Munnelly
e7dea9f2a2
Replace all references to pkg/internal with internal
...
Signed-off-by: James Munnelly <jmunnelly@apple.com>
2021-10-21 12:27:04 +01:00
James Munnelly
f81703d9ab
Move pkg/internal/ to internal/
...
Signed-off-by: James Munnelly <jmunnelly@apple.com>
2021-10-21 12:24:28 +01:00
irbekrm
598ed35e4a
Uses go/crypto ListCertAlternates function to fetch alternative certificate chains
...
This allows us to use upstream go/crypto again instead of our own fork
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-10-07 15:21:26 +01:00
Richard Wall
5d91f0a3c4
Fix flaky test by using EqualUnsorted to compare Events
...
Supplants https://github.com/jetstack/cert-manager/pull/4297
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-10-01 12:41:15 +01:00
irbekrm
7e9753c92e
Fix CertificateRequest test
...
In Go 1.17 x509.CreateCertificate fails if public key doesn't match private key https://golang.org/doc/go1.17
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-09-30 10:08:40 +01:00
irbekrm
cb6a746726
Runs ./hack/update-all.sh
...
New format of Go build tags gets added
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-09-30 10:08:19 +01:00
Richard Wall
41ef0e3f2b
A note about testing the handling of errors relating to the ValidatingWebhook
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-09-29 13:05:53 +01:00
Richard Wall
b71eb11fd1
A note about the relevance of conversion webhook unit-tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-09-29 13:02:44 +01:00
Richard Wall
969ca6d91a
Use the v1 API rather than v1alpha2 in the API checker
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-09-29 12:54:42 +01:00
jetstack-bot
898dc0e254
Merge pull request #4419 from artificial-aidan/master
...
Add Certificate RenewBefore prometheus metrics
2021-09-27 17:51:46 +01:00
jetstack-bot
f4be63c208
Merge pull request #4465 from andrewmwhite/show-invalid-access-token
...
Clouldflare: Show API error messages (e.g., invalid access token)
2021-09-27 15:20:46 +01:00
jetstack-bot
5a8b970c97
Merge pull request #4456 from JoshVanL/vault-client-health-err-check
...
Vault internal client should check health conn err before checking response status
2021-09-27 13:07:46 +01:00
Jake Sanders
e58af020a6
go fmt
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-09-21 10:41:28 +01:00
Jake Sanders
745b4edaa3
Additional tests from code review feedback
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-09-21 09:55:59 +01:00
Jake Sanders
57e9e57fbf
Use IngressClassName field for v1 Ingresses
...
As of Kubernetes 1.18, the deprecated annotation should not be used. This coincides with the support for networking v1 Ingresses in the Kubernetes API.
This commit adds logic to the internal conversion code to add the annotation back on v1beta1 Ingresses, used on Kubernetes 1.16 and 1.17
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-09-21 09:24:15 +01:00
Jake Sanders
8b25cac161
Rename httpDomainCfg function to http01IngressCfg
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-09-21 09:24:12 +01:00
Andrew M. White
4e336d28f4
Cloudflare: output meaningful error message on request failure (e.g. for invalid access tokens).
...
Signed-off-by: Andrew M. White <andrewmwhite@gmail.com>
2021-09-16 19:35:27 -07:00
Andrew M. White
fe4945de6f
Support Cloudflare API token in live tests.
...
Previously only API keys were supported.
Signed-off-by: Andrew M. White <andrewmwhite@gmail.com>
2021-09-16 19:35:27 -07:00
joshvanl
f21a947523
Adds comment as to why the GetAuthorization is called instead of
...
GetChallenge
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-16 14:44:38 +01:00
joshvanl
f83f02cc8b
Replace GetChallenge call in acmechallenge controller to
...
GetAuthorization
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-15 16:05:37 +01:00
joshvanl
b75a68088c
Vault internal client should check health conn err before checking
...
response status
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-15 15:57:05 +01:00
jetstack-bot
fcf379d6e9
Merge pull request #4428 from mol-george/issue-4189-keystore-upgrade
...
Issue 4189 keystore upgrade
2021-09-13 10:45:56 +01:00
George Moldoveanu
b94b678f6d
reinstated keystore.go comment
...
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
2021-09-10 13:33:46 +01:00
George Moldoveanu
563aeb1789
fixed keystore.go and keystore_test.go modules imports
...
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
2021-09-10 13:28:45 +01:00
jetstack-bot
6e1b6bda56
Merge pull request #4429 from JoshVanL/acme-client-middleware-orders
...
Adds the ACME client middleware when create an ACME account
2021-09-03 18:35:22 +01:00
jetstack-bot
8f0225189e
Merge pull request #4332 from tomasfreund/feature/azure-dns-msi-id
...
Add option to specify managed identity id when using azure dns
2021-09-03 17:17:22 +01:00
joshvanl
0c96c54416
Adds the ACME client middleware when create an ACME account
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-03 13:47:43 +01:00
George Moldoveanu
0463681244
updates go deps and bazel files
...
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
2021-09-02 23:45:11 +01:00
George Moldoveanu
d0151f7175
fixed TestEncodeJKSKeystore tests to work with upgraded keystore-go api (v4)
...
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
2021-09-02 23:33:45 +01:00
George Moldoveanu
155e90d175
upgraded keystore-go to v4 and fixed code to use v4 api
...
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
2021-09-02 23:24:06 +01:00
Aidan Jensen
15d1ba96fe
Fix spelling error. Fix tests
...
Signed-off-by: Aidan Jensen <aidan@artificial.com>
2021-09-01 10:47:46 -07:00
Aidan Jensen
3bd35642a7
Use status.renewalTime instead of renewBefore
...
Signed-off-by: Aidan Jensen <aidan@artificial.com>
2021-09-01 10:07:21 -07:00
Aidan
d9dc7eff1b
Update pkg/metrics/certificates.go
...
Co-authored-by: Steven E. Harris <seh@panix.com>
Signed-off-by: Aidan Jensen <aidan@artificial.com>
2021-08-31 14:13:30 -07:00
Aidan Jensen
168a4b35a2
Update comment on UpdateCertificate metric from PR
...
Signed-off-by: Aidan Jensen <aidan@artificial.com>
2021-08-31 10:17:30 -07:00
Aidan Jensen
c6bc180f58
Add Certificate RenewBefore prometheus metrics
...
Signed-off-by: Aidan Jensen <aidan@artificial.com>
2021-08-30 10:52:21 -07:00
Charlie Haley
e06e208f9b
fix typo in error message
...
Signed-off-by: Charlie Haley <27928201+charlie-haley@users.noreply.github.com>
2021-08-28 00:15:07 +01:00
jetstack-bot
e5cc0be04b
Merge pull request #4399 from irbekrm/fix_renewal_issue
...
Fix renewalTime skew issue
2021-08-23 16:36:50 +01:00
irbekrm
ec1bdc4983
Adds a test case for renewal time skew and a comment
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-08-23 15:00:57 +01:00
Eng Zer Jun
54e70d2cc4
refactor: move from io/ioutil to io and os package
...
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2021-08-23 19:50:42 +08:00
irbekrm
50e90dfe6e
Fix renewalTime skew issue
...
Ensure the time returned by RenewalTime function is the same time as that which will be read from Certificate's status
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-08-20 17:57:35 +01:00
jetstack-bot
38ab6f4bdd
Merge pull request #4365 from jonathansp/master
...
fix: flaky test when comparing unordered elements
2021-08-20 13:02:44 +01:00
jetstack-bot
0ff741c9d2
Merge pull request #4392 from SgtCoDFish/fixversions
...
Fix manually specified Certificate and CertificateRequest versions
2021-08-20 12:16:45 +01:00
Jake Sanders
5df1dd4932
Update Docs on solver type to reflect default service type
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-08-19 14:55:50 +01:00