Maël Valais
e4f981da66
Revert "memory leak: clean up scheduler goroutine on cert deletion"
...
This reverts commit 641960b6 . The reason we decided to revert this is
that we are unsure about the implications of adding the
scheduledWorkQueue.Forget call. The new Forget call is left untested,
and it makes us nervous not to know exactly if it works as intended.
The "Forget" memory leak that we are reverting now is the cause of a
tiny fraction of the overall memory leakage that was fixed in the PR
in the scheduler itself. Reverting this means that some goroutines will
be leaked, but only when a Certificate gets removed and never recreated
with the same name.
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-28 19:19:39 +02:00
Maël Valais
641960b666
memory leak: clean up scheduler goroutine on certificate deletion
...
Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-23 16:57:10 +02:00
irbekrm
06f6b46f30
Implements feedback from code review
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:20:05 +01:00
irbekrm
d8c941da8e
Refactors creation of ACME Orders controller
...
So that it easier used with the existing test framework and also is more similar to how most other controllers are created
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:11:18 +01:00
irbekrm
1e235c79f2
Re-queue Order with finalized Challenges, but pending state
...
To avoid stuck Orders in case of a misbehaving ACME server
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:05:44 +01:00
irbekrm
a42771b7e4
Adds a bunch of comments for exported types
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 10:19:43 +01:00
Maartje Eyskens
ab0cd57dc5
Use The cert-manager Authors.
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens
1788a9d758
Update copyright to cert-manager project
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
Richard Wall
a70298180a
Run a script to update v1alpha2 usage to v1
...
Script is available at https://github.com/jetstack/cert-manager/pull/3201
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
James Munnelly
b126a0c0e5
Use acme AccountRegistry throughout and tidy up ACME setup code
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-13 13:14:46 +01:00
James Munnelly
822b9e17a0
Remove AdditionalRunFuncs from base controller
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-03-30 20:43:00 +01:00
James Munnelly
2868b4a7b7
Update pkg/controllers
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-23 10:07:53 +01:00
James Munnelly
58754abf37
Refactor codebase for v1alpha2
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
6052e0558e
Refactor base controller and allow Running additional informers
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-21 13:22:57 +01:00
James Munnelly
99bbc31386
Promote 'Clock' to be a field on controller context
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 12:30:23 +01:00
James Munnelly
442789113a
Refactor controllers to not reference BaseController
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-19 15:11:06 +01:00
Michael Tsang
0add074b7f
Add basecontroller to other controllers
...
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-23 17:32:33 +01:00
James Munnelly
871ed4283b
Allow controller constructors to return errors
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-18 14:22:04 +01:00
James Munnelly
708313ac4b
Update acmeorders controller
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-03-12 14:24:50 +00:00
James Munnelly
2f30258f0e
Switch to klog
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-22 12:34:02 +00:00
James Munnelly
0bde3dacba
Create pkg/api/util and re-arrange controller instantiation code
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:54 +00:00
jetstack-bot
c512319bfb
Merge pull request #1188 from kragniz/controller-namespace
...
Add --namespace flag
2019-01-11 15:14:11 +00:00
James Munnelly
21c7b2e13f
Increase ACME control loop max back-off. Increase create order back-off to 1h. Fire Event when Order fails.
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-10 22:07:48 +00:00
Louis Taylor
40b68a3e10
Fix more references to clusterIssuer
...
Signed-off-by: Louis Taylor <louis@kragniz.eu>
2019-01-10 13:52:52 +00:00
James Munnelly
0fcc0c666c
Update copyright header year
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-07 15:07:55 +00:00
James Munnelly
f8fe9ef21f
Remove requeue option and fix small race in controllers
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-29 12:23:21 +00:00
James Munnelly
2da01a0a01
Resync order resources when their issuers change
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-28 19:16:00 +00:00
James Munnelly
b103403ff7
Add default rate limiter used by all controllers
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-21 20:37:57 +00:00
James Munnelly
3eb8c486ce
acmeorders: instantiate real clock
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-13 15:22:44 +00:00
James Munnelly
eadbbc85c5
Add missing boilerplate headers
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James Munnelly
d323a1df0d
Add unit tests for acmeorders and acmechallenges
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James Munnelly
967a48e1dc
Add ACME Order & Challenge controllers
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:38 +01:00