Commit Graph

77 Commits

Author SHA1 Message Date
James Munnelly
641fe0da7c Switch to using upstream golang.org/x/crypto
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
00ad3446ef Surface ACME Challenge failure reason on Challenge resource if available
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-29 09:22:08 +00:00
James Munnelly
ef55bd5807 Mark Order & Challenge resources as Errored if 4xx error is received
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 09:30:17 +01:00
James Munnelly
e3b1e9bdb9 Call UpdateStatus before Update when finalizing Challenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
9a807be80a Fix not returning updateErr if updating status failed
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
8bf08237f7 Migrate acmechallenges and acmeorders to use UpdateStatus
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
b6803a2185 Fully update challenge and order in controller sync instead of UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
James Munnelly
973f4aa424 Update codebase for external dependencies
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-26 12:52:43 +01:00
James Munnelly
2868b4a7b7 Update pkg/controllers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-23 10:07:53 +01:00
James Munnelly
bf9fbea23f Update codebase for new meta apigroup
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 19:25:04 +01:00
James Munnelly
58754abf37 Refactor codebase for v1alpha2
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
99714943bc Remove deprecated code from acmechallenges controller (tests only)
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-19 13:07:59 +01:00
James Munnelly
e8d1bc608e Update for ACMEChallengeType type
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-10 14:45:26 +01:00
James Munnelly
1b8a286206 Rename Setup->Init and use Start to start informers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-22 13:11:33 +01:00
James Munnelly
6052e0558e Refactor base controller and allow Running additional informers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-21 13:22:57 +01:00
James Munnelly
d43fb909c4 Convert acmechallenges controller to use test builder directly
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 14:14:48 +01:00
James Munnelly
32bc10710e Update use of featuregate package
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-20 01:57:24 +01:00
James Munnelly
5f5811b81e Respect --namespace flag in rfc2136 provider
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-03 13:52:43 +01:00
James Munnelly
20b1343c88 Remove use of klog from more places
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 14:30:41 +02:00
James Munnelly
f8a798bd2b update bazel files
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-19 15:33:57 +01:00
James Munnelly
442789113a Refactor controllers to not reference BaseController
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-19 15:11:06 +01:00
jetstack-bot
48cd58b23f
Merge pull request #1722 from cheukwing/issue-1003
Add BaseController as a refactoring of common controller code
2019-06-17 19:27:57 +01:00
Michael Tsang
0add074b7f Add basecontroller to other controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-23 17:32:33 +01:00
Michael Tsang
7d67ae466e Remove metrics field from controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 11:06:11 +01:00
Michael Tsang
455f6ebab4 Use ControllerName as label value
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 16:49:39 +01:00
Michael Tsang
f2e57a1c95 Add ControllerSyncCallCount metric
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 14:22:16 +01:00
Michael Tsang
a628b8f5a7 Use MaxConcurrentChallenges flag in scheduler
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-13 17:03:35 +01:00
James Munnelly
bbf4012e12 Handle expired challenge responses in acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 18:57:26 +01:00
jetstack-bot
570751236d
Merge pull request #1585 from munnerz/validate-caa-feature-gate
Add feature gate for ValidateCAA functionality and default it to off
2019-04-30 14:17:48 +01:00
James Munnelly
49f587c844 Set Reason field on ACME challenges during Present/CleanUp
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 10:25:33 +01:00
James Munnelly
9906c0d946 Add feature gate for ValidateCAA functionality and default it to off
To help avoid issues with the ValidateCAA functionality, this disables
the CAA check by default and adds a new --feature-gates=ValidateCAA=true
option to cert-manager-controller to allow enabling the previous
behaviour in v0.7.0 and v0.7.1.

Once issues with CNAMEd DNS names pointing to internal nameservers
are resolved, this option will be defaulted to on.

Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-25 15:10:05 +01:00
James Munnelly
af9bce7221 Add 'webhook' DNS01 provider type
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-18 17:19:32 +01:00
James Munnelly
871ed4283b Allow controller constructors to return errors
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-18 14:22:04 +01:00
James Munnelly
eaeefdf5b2 Update acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-03-12 14:24:51 +00:00
James Munnelly
2f30258f0e Switch to klog
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-22 12:34:02 +00:00
James Munnelly
0bde3dacba Create pkg/api/util and re-arrange controller instantiation code
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-19 11:25:54 +00:00
jetstack-bot
1476aed737
Merge pull request #1293 from munnerz/test-builder-logger
Plumb testing.T through to test Builder
2019-02-13 13:48:26 +00:00
Daniel Morsing
a01514ad63 use configured nameservers for CAA validation
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-11 12:05:18 +00:00
Daniel Morsing
bb853e5e79 first draft CAA checking
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-05 14:25:10 +00:00
James Munnelly
d055d370bb Plumb testing.T through to test Builder
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-31 20:20:20 +00:00
James Munnelly
948a2cf77c Add more OWNERS files with auto-labels
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-24 19:38:31 +00:00
Daniel Morsing
99c16b77dc fix other test
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-21 13:33:34 +00:00
Daniel Morsing
b0a9b8276c surface self-check errors in challenge resource
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-21 11:49:46 +00:00
Daniel Morsing
88d811b34c change Check function signature
This makes the check function into a simple precondition

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-17 16:45:03 +00:00
jetstack-bot
c512319bfb
Merge pull request #1188 from kragniz/controller-namespace
Add --namespace flag
2019-01-11 15:14:11 +00:00
James Munnelly
21c7b2e13f Increase ACME control loop max back-off. Increase create order back-off to 1h. Fire Event when Order fails.
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-10 22:07:48 +00:00
Daniel Morsing
cc946c0b45 Populate reason field regardless
If we have an error, then tell people about it.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:54:43 +00:00
Daniel Morsing
1b921b1583 remove more strict validation
Turns out the ACME server can respond with different codes than the ones listed

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:35:30 +00:00
Daniel Morsing
ba240bbe4e Add reason when an order/challenge gets marked invalid
When an ACME server tells us that a challenge or an order is invalid, it's helpful to get some information on why that's the case. Populate the reason field with the error information so that these issues can be more easily debugged.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:05:15 +00:00