Josh Soref
81aaf3d7d2
spelling: signing
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 17:20:49 -05:00
Josh Soref
5e275cdacf
spelling: propagation
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 17:20:10 -05:00
Josh Soref
08f7e24c74
spelling: invalid
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 16:43:19 -05:00
Josh Soref
093d6eb504
spelling: indices
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 16:42:58 -05:00
Josh Soref
77ebc73cc7
spelling: existing
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 16:42:37 -05:00
Josh Soref
b4f28e5d04
spelling: deprecated
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 16:42:26 -05:00
Josh Soref
8d801fc100
spelling: certificate
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2020-02-24 16:15:51 -05:00
James Munnelly
eccd7b3faf
Only allow a single TLS entry per secret name in an Ingress resource
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-02-21 09:52:23 +00:00
James Munnelly
5ed2c55006
ingress-shim: add unit tests for events
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-02-18 18:14:44 +00:00
jetstack-bot
672f7654a7
Merge pull request #2573 from meyskens/venafi-custom-fields
...
Add venafi.cert-manager.io/custom-fields annnotation
2020-02-17 12:24:24 +00:00
Maartje Eyskens
d40f010180
Error on an invalid custom field type
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-12 11:34:28 +01:00
Maartje Eyskens
1ebc9ef56b
Properly sort imports
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-12 10:29:10 +01:00
Maartje Eyskens
292d7f1e61
Update vcert
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-07 09:19:24 +01:00
Maartje Eyskens
1eb4fc6846
Create internalvanafiapi to prevent cyclic imports
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-06 11:11:37 +01:00
Maartje Eyskens
e040d4f284
Implement feedback
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-06 10:32:06 +01:00
Maartje Eyskens
15b9a940e7
Add tests for custom fields inside internal/venafi
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-05 16:14:49 +01:00
Maartje Eyskens
ae742c588e
Add tests for custom fields inside certificaterequest controller
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-05 15:36:30 +01:00
Maartje Eyskens
93f0cfa717
Use internal CustomField to add json tags
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-05 14:12:16 +01:00
Maartje Eyskens
42f3bca6ef
Move annotation to apis
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-05 14:08:41 +01:00
JoshVanL
0e18ba7b1d
Run a First func for webhook secret bootstrap and catch recursive unit
...
test
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-02-05 11:49:31 +00:00
JoshVanL
e9c04b57d9
Adds a First function to controllers which run after initialisation
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-02-05 11:48:20 +00:00
JoshVanL
72d6d030c8
Adds Create expected action to webhook bootstrap tests due to always
...
Create being attempted
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-02-04 17:34:00 +00:00
JoshVanL
c940b30ac1
Added comment around recursive function call and cleans up Create/Update
...
code
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-02-04 16:59:48 +00:00
JoshVanL
fa75ced013
Updates webhook bootstrap tests to for new single reconcile key/cert
...
generation
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-02-04 14:49:26 +00:00
JoshVanL
e58022462e
Moves key generation to same reconcile as webhook certificate signing to
...
do single creation/update of Secret
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-02-04 14:48:45 +00:00
Maartje Eyskens
6ecc07ba26
Update bazel
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-04 15:37:40 +01:00
Maartje Eyskens
4452fbd9a8
Add venafi.cert-manager.io/custom-fields annnotation
...
This adds the venafi.cert-manager.io/custom-fields annotation to CertificateRequest.
The JSON decoded value of this annotation will be passed to the Venafi customfields on signing.
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-02-04 15:15:43 +01:00
James Munnelly
1f7f23895d
Ensure fetched certificate is valid for CSRs public key before issuing
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-01-22 16:42:58 +00:00
jetstack-bot
fbab741817
Merge pull request #2513 from munnerz/add-v1alpha3
...
Create v1alpha3 API version
2020-01-20 16:37:31 +00:00
jetstack-bot
b7e83b5382
Merge pull request #2508 from JoshVanL/cr-invalid-request
...
CertificateRequest InvalidRequest
2020-01-20 14:17:31 +00:00
James Munnelly
72ea226b41
Update controllers to use validation registry
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-01-20 10:05:54 +00:00
JoshVanL
2f3fe4c3d7
Reduce comments by removing invalid data in CR implementations doing
...
better InvalidRequest checking
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-17 14:11:25 +00:00
JoshVanL
b989f4e604
Remove cert-manager core issuers from marking CR as InvalidRequest
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-17 13:35:05 +00:00
Joshua Mathianas
cc802cc16e
made code review changes
...
Signed-off-by: Joshua Mathianas <mathianasj@gmail.com>
2020-01-17 07:31:25 -05:00
Joshua Mathianas
eed8f67587
fixed which namespace to find secret in based on if its a clusterissuer for venafi
...
Signed-off-by: Joshua Mathianas <mathianasj@gmail.com>
2020-01-16 12:19:49 -05:00
JoshVanL
c38466dc9c
Update certificate request controller sync_test.go
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-10 09:41:55 +00:00
JoshVanL
f9f8fbd311
Add InvalidRequest condition check to Certificate controller:
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-09 15:14:21 +00:00
JoshVanL
1c9557b729
Adds InvalidRequest condition set to CertificateRequest controllers
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-09 15:13:54 +00:00
James Munnelly
9daad6dd93
Update tests to ensure temporary certificates are not re-issued when dnsNames mismatch
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-16 15:11:07 +00:00
James Munnelly
7076041de6
Don't overwrite existing certificates when issuing a temporary certificate
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-16 13:53:38 +00:00
James Munnelly
ff8c68348a
Update checks.go for external account bindings
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-11 12:37:36 +00:00
jetstack-bot
4073080089
Merge pull request #2416 from munnerz/fixup-expiry-metrics
...
Fix certificate controller expiry metrics
2019-12-10 17:25:15 +00:00
James Munnelly
1f3b883cfd
Don't overwrite order.status.url if return Order's URI is empty
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
641fe0da7c
Switch to using upstream golang.org/x/crypto
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
698e7a522a
Fix certificate controller expiry metrics
...
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-11-29 18:29:23 +00:00
JoshVanL
232b1133fd
Adds more tests for deprecated secret annotations and update secret
...
annotations if deprecated ones exist
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-27 15:12:25 +00:00
JoshVanL
0d9d0eeb22
Allow secrets with legacy annotations for issuer name and kind to match
...
existing certificates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-26 12:13:58 +00:00
jetstack-bot
5ec141c107
Merge pull request #2382 from JoshVanL/cr-controller-issuer-ready
...
Check for Issuer readiness in CR controllers
2019-11-26 09:40:30 +00:00
JoshVanL
de7aaa84d3
Update CertificateRequest controller unit tests
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-19 22:09:01 +00:00
JoshVanL
3bcc038c09
Check for Issuer readiness in CR controllers
...
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-19 20:31:44 +00:00