Richard Wall
1ade01f819
Addressed code review feedback and simplified the unit-tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2022-05-14 14:24:13 +01:00
Richard Wall
557d14a0cd
Refactor the update and updateStatus to a single deferred function
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2022-05-12 16:51:30 +01:00
Richard Wall
6a4fffbedc
Test that the cleanup is performed
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2022-04-29 17:51:34 +01:00
Richard Wall
5f867bff37
Use a more reliable check for deletion
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2022-04-29 16:49:23 +01:00
Richard Wall
ee8c1cf738
Remove finalizer duties from the scheduling function and update and expand the tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2022-04-27 10:34:22 +01:00
Richard Wall
dd4fe97928
Set the finalizer as part of the Challenge Sync function
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2022-04-27 10:34:22 +01:00
lonelyCZ
53d8a07397
Add a unit test for challenges reScheduler
...
Signed-off-by: lonelyCZ <531187475@qq.com>
2022-04-08 14:35:41 +08:00
lonelyCZ
57a6d931a1
Fix the error is reported to null when it happens
...
Signed-off-by: lonelyCZ <531187475@qq.com>
2022-04-07 16:10:14 +08:00
irbekrm
0f74fc10fb
Removes unnecesary check for finalizer diff in challenge sync
...
No changes are made to finalizers in this function
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-04-01 11:53:44 +01:00
irbekrm
9a9ca2006a
Adds a challenge finalizer in challenges controller
...
This was previously applied in orders controller, which was causing issues when trying to remove it in challenges controller via server side apply
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-04-01 11:53:44 +01:00
joshvanl
82c068f0fd
Updates ACME challenge controllers to use apply
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-04-01 11:53:44 +01:00
Jake Sanders
c96d91d586
Update the sig-network Gateway API support to v1alpha2
...
Co-authored-by: Joakim Ahrlin <joakim.ahrlin@gmail.com>
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-03-01 15:05:17 +00:00
Ashley Davis
b084e5804c
fix violations of our coding conventions on import ordering
...
this is exposed by the rename when cert-manager internal imports are mixed in with
external imports
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-02 11:53:39 +00:00
Ashley Davis
3a055cc2f5
rename all uses of github.com/jetstack/cert-manager
...
This was done by running the following command twice:
```bash
grep -Ri "github.com/jetstack/cert-manager" . | \
cut -d":" -f1 | \
sort | \
uniq | \
xargs sed -i
"s/github.com\/jetstack\/cert-manager/github.com\/cert-manager\/cert-manager/"
```
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-02 09:08:31 +00:00
joshvanl
d89c3e71dc
Update rest of controllers with ControllerFactory
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-27 12:51:49 +00:00
James Munnelly
9c04a04c7c
Move feature package into internal/controller
...
Signed-off-by: James Munnelly <jmunnelly@apple.com>
2022-01-07 12:17:36 +00:00
James Munnelly
e7dea9f2a2
Replace all references to pkg/internal with internal
...
Signed-off-by: James Munnelly <jmunnelly@apple.com>
2021-10-21 12:27:04 +01:00
joshvanl
f21a947523
Adds comment as to why the GetAuthorization is called instead of
...
GetChallenge
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-16 14:44:38 +01:00
joshvanl
f83f02cc8b
Replace GetChallenge call in acmechallenge controller to
...
GetAuthorization
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-09-15 16:05:37 +01:00
Jake Sanders
deb9ccc5a9
HTTP01 solver support for the Gateway API
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-08-02 14:06:16 +01:00
Jake Sanders
83857fdc03
Remove stray reference to v1beta1 Ingress
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-07-26 20:29:35 +01:00
Jake Sanders
0d93b93fc5
Feature: Support both v1 and v1beta1 ingresses.
...
Kubernetes is removing support for the v1beta1 Ingress type in 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes
However, we still wish to support k8s v1.16 until mid 2022 when Openshift 3 becomes out of support.
cert-manager will now use v1 Ingress if available by using the discovery API.
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-07-26 18:29:42 +01:00
Jake Sanders
79d8d9cb7b
Revert "Merge pull request #3724 from inteon/istio-virtualservice-for-http01"
...
This reverts commit 80f27739b5 , reversing
changes made to 96604d02a3 .
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-11 14:50:25 +01:00
Jake Sanders
423e82b65b
Revert "Merge pull request #3939 from JoshVanL/istio-api-to-internal-apis"
...
This reverts commit f2a74ade5e , reversing
changes made to 7ff54e61e9 .
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-11 14:50:23 +01:00
Richard Wall
fc1f6ffea9
./hack/update-deps.sh
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-07 09:55:09 +01:00
Richard Wall
3811847872
Fail benchmark if scheduleN returns an error
...
pkg/controller/acmechallenges/scheduler/scheduler_test.go:84:16 errcheck Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:98:16 errcheck Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:112:16 errcheck Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:314:51 errcheck Error return value of `` is not checked
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-07 09:55:09 +01:00
joshvanl
c5e2184a4a
Moves /pkg/internal/apis/istio to /pkg/internal/istio
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 12:31:57 +01:00
joshvanl
00ceff3421
Update bazel
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:36:49 +01:00
joshvanl
3af22cf6c6
Move istio util duncs to pkg/util/istio
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:35:41 +01:00
Inteon
624e2b9e69
add ACME HTTP01 Istio support
...
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:19:53 +02:00
jetstack-bot
06b68d35e0
Merge pull request #3835 from RinkiyaKeDad/3620_constants_in_eventf
...
chore: used constants for string literals when recording new events
2021-04-13 15:14:11 +01:00
RinkiyaKeDad
0b87eeae97
added reason prefix for all
...
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-13 16:40:56 +05:30
RinkiyaKeDad
bba7c1011d
added prefix and made constants public
...
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-08 12:17:15 +05:30
RinkiyaKeDad
ab912ef120
chore: added constants for non repeating ones also
...
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-01 15:46:54 +05:30
RinkiyaKeDad
067f6ac1e4
chore: used constants for repeated string literals in record.EventRecorder.Eventf function calls
...
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-01 13:00:40 +05:30
joshvanl
18ae2295f9
Pass context through to client calls in controllers and acme issuer
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-31 20:34:12 +01:00
Salman
572bfb9111
Replace reflect.DeepEqual with semantic equality check
...
Signed-off-by: salmanahmed404 <salmanahmed404@gmail.com>
2021-03-27 12:49:14 +05:30
jetstack-bot
cdc53b65cb
Merge pull request #3500 from meyskens/update-copy
...
Update copyright to cert-manager project
2020-12-15 10:12:31 +00:00
Maartje Eyskens
ab0cd57dc5
Use The cert-manager Authors.
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens
c6e84d7c83
Switch informer to networking
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-09 16:36:11 +01:00
Maartje Eyskens
1788a9d758
Update copyright to cert-manager project
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
Maartje Eyskens
c0d88c28e4
Add a unit test for more challenges than previously allowed
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-22 14:45:02 +02:00
Maartje Eyskens
42803173cb
Fix a panic when changing the max concurrent challenges
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-20 15:45:45 +02:00
Matthias Frey
2f2253afaf
make propagation check period configurable
...
Signed-off-by: Matthias Frey <freym@users.noreply.github.com>
2020-09-24 11:28:49 +02:00
Richard Wall
3fb3db27ff
Fix ACME challenge type in unit tests
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Maartje Eyskens
5aba6f956b
Fix ACME
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-20 14:28:06 +01:00
Richard Wall
81eb53f597
./hack/update-all.sh
...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall
a70298180a
Run a script to update v1alpha2 usage to v1
...
Script is available at https://github.com/jetstack/cert-manager/pull/3201
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
Maartje Eyskens
827ce9c5ad
Revert log levels on errors
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:42 +02:00
Maartje Eyskens
86dee5ed41
Set error log levels
...
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:41 +02:00