Commit Graph

157 Commits

Author SHA1 Message Date
James Munnelly
1adfe16690 Bulk fix of non-test staticcheck failures
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-26 12:25:08 +01:00
jetstack-bot
46eaf3d1a4
Merge pull request #2923 from JoshVanL/new-metrics
Updates the metrics package + new metrics controller
2020-06-04 12:59:38 +01:00
Haoxiang Zhou
609eedacec Do not add ca.crt key to TLS secret if empty in expcertificates as well
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-05-26 14:37:40 +01:00
Haoxiang Zhou
dceae33364 Do not add ca.crt key to TLS secret if empty
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-05-26 12:16:20 +01:00
JoshVanL
92eb8d0957
Refactor controllers to use new instrumented metrics that's baked into
all controllers

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:43:56 +01:00
James Munnelly
7978fbe081 Address review feedback and include truststore.jks with JKS mode enabled
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-04-22 15:20:49 +01:00
James Munnelly
ba33c823a3 Add 'keystores' stanza to CertificateSpec to allow dynamic keystore configuration
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-04-21 17:58:18 +01:00
James Munnelly
881b886049 Update Kubernetes API client call-sites
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-03-26 12:58:50 +00:00
James Munnelly
98bc0d52f9 Add --experimental-issue-jks flag to enable JKS bundle generation
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-03-04 15:33:22 +00:00
James Munnelly
e9374730c9 Add --experimental-issue-pkcs12 flag to enable PKCS12 bundle generation
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-03-04 10:02:21 +00:00
James Munnelly
1f7f23895d Ensure fetched certificate is valid for CSRs public key before issuing
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-01-22 16:42:58 +00:00
JoshVanL
2f3fe4c3d7
Reduce comments by removing invalid data in CR implementations doing
better InvalidRequest checking

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-17 14:11:25 +00:00
JoshVanL
f9f8fbd311
Add InvalidRequest condition check to Certificate controller:
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-01-09 15:14:21 +00:00
James Munnelly
7076041de6 Don't overwrite existing certificates when issuing a temporary certificate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-16 13:53:38 +00:00
James Munnelly
698e7a522a Fix certificate controller expiry metrics
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-11-29 18:29:23 +00:00
JoshVanL
232b1133fd Adds more tests for deprecated secret annotations and update secret
annotations if deprecated ones exist

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-27 15:12:25 +00:00
JoshVanL
bca6ebc520 Ensure key usages are set on CertificateRequests created by the
Certificate controller

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-05 14:22:25 +00:00
James Munnelly
6b19892908 Fix regression in certificates controller setting owner references
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-09 11:33:21 +01:00
JoshVanL
7d615ff8e4 Remove getting secret from lister in matches spec func
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 10:01:57 +01:00
JoshVanL
13b0584838 Change behaviour to be more relaxed around common names
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
f249888112 Only add common-name annotation if commonName exists
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
James Munnelly
9a807be80a Fix not returning updateErr if updating status failed
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
JoshVanL
869370e226 Cleans up code and naming
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-26 17:35:52 +01:00
JoshVanL
ced21c287f Conformance: Ensure if a certificate is deleted then a new certificate is signed with
same key

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-26 17:34:42 +01:00
James Munnelly
bf9fbea23f Update codebase for new meta apigroup
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 19:25:04 +01:00
James Munnelly
58754abf37 Refactor codebase for v1alpha2
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
80cbcb35fb Add issue-temporary-certificate annotation to control temporary cert issuance
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 15:26:41 +01:00
James Munnelly
7e1312794c Set certificate-name annotation on CertificateRequest resources
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-19 17:05:02 +01:00
James Munnelly
79f2cd60f4 Pass down annotations from Certificate resources to Orders via CertificateRequests
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-19 16:38:43 +01:00
James Munnelly
51bf98581e Remove deprecated code from certificates controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-19 13:07:59 +01:00
James Munnelly
c4e00311ba Set certificate name annotation in certificates controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-03 11:20:51 +01:00
James Munnelly
73d66c44ab Move API validations package
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-21 13:11:01 +01:00
James Munnelly
ce475e1640 Move TLSCAKey to v1alpha1 package
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-14 01:21:15 +01:00
James Munnelly
3bb5fb1897 Fix concurrent map write panic
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-13 12:07:41 +01:00
James Munnelly
1da47b9e68 Add DisableDeprecatedACMECertificates feature gate
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 16:17:59 +01:00
jetstack-bot
4dc46d68cd
Merge pull request #1910 from JoshVanL/ca-issuer-sign-migration
Move CA signer into ./pkg/controller/certificaterequests/ca
2019-07-25 14:48:28 +01:00
JoshVanL
f8c511a705 Address ca sign returning error
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-07-23 12:06:30 +01:00
JoshVanL
294d8ae93d Move IssuerKind to ./pkg/util
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-07-23 09:27:22 +01:00
James Munnelly
32bc10710e Update use of featuregate package
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-20 01:57:24 +01:00
James Munnelly
7edbd829c4 Refactor certificates controller to make methods shareable
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-17 10:04:40 +01:00
Michael Tsang
f3baab085e Add UpdateCertificateStatus call, comment implementation
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-07-10 08:54:06 +01:00
JoshVanL
e41a8f1892 Adds not certmanager group ref bailout for certificates controller
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-07-09 13:14:58 +01:00
Artem Yarmoluk
9197acfefe
Allow disabling issuing temporary certificates
Signed-off-by: Artem Yarmoluk <koolgen@gmail.com>
2019-06-30 21:57:57 +03:00
James Munnelly
20b1343c88 Remove use of klog from more places
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 14:30:41 +02:00
James Munnelly
442789113a Refactor controllers to not reference BaseController
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-19 15:11:06 +01:00
jetstack-bot
043a88cdd8
Merge pull request #1689 from cheukwing/issue-1558
Validate that only one Certificate is using a secretName per namespace
2019-06-17 20:21:57 +01:00
Michael Tsang
089ff067ce Add more detailed logging
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-24 13:55:33 +01:00
Michael Tsang
0e677ee900 Break out of unnecessary checks for duplicates
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 15:44:52 +01:00
Michael Tsang
7d67ae466e Remove metrics field from controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 11:06:11 +01:00
Michael Tsang
455f6ebab4 Use ControllerName as label value
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 16:49:39 +01:00