Commit Graph

1660 Commits

Author SHA1 Message Date
James Munnelly
1adfe16690 Bulk fix of non-test staticcheck failures
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-26 12:25:08 +01:00
jetstack-bot
63b7ca26b8
Merge pull request #3027 from munnerz/expcerts-renewal
expcertificates: fix bug renewing certificates automatically near expiry
2020-06-26 09:21:39 +01:00
James Munnelly
86b8cab328 expand out 'clearCertificateFields' function
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-25 10:44:08 +01:00
jetstack-bot
83f391c177
Merge pull request #3018 from hzhou97/fix-convert-cmd
Fix ctl convert cmd
2020-06-23 18:14:12 +01:00
Haoxiang Zhou
24404aa1eb Added new scheme to use for ctl commands
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-06-23 17:18:56 +01:00
James Munnelly
ba26d65c68 schedule resyncs once renewalTime has passed to handle certificate renewals in the future
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:48:33 +01:00
James Munnelly
b3300b8673 update trigger policies unit tests for status.renewalTime field
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:48:33 +01:00
James Munnelly
fe51a02227 use status.renewalTime in trigger policies and correctly plumb through clock
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:37:50 +01:00
James Munnelly
8bb4bb389a use correct PolicyChain in readiness controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:37:50 +01:00
James Munnelly
7cf74ec442 set notBefore and renewalTime status fields in certificate readiness controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:23:42 +01:00
James Munnelly
cbe5f5dfb5 generated files
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:23:42 +01:00
James Munnelly
2d5901df3f pkg/apis: add 'notBefore' and 'renewalTime' fields to Certificate status
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:23:42 +01:00
James Munnelly
1d6424b8f2 Use 'clock' package in pkg/scheduler
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:23:42 +01:00
James Munnelly
281b9ffcbd add RenewBeforeExpiryDuration function
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-06-23 16:23:42 +01:00
Haoxiang Zhou
6c72193678 Handle keyEncoding for temporary Certificates
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-06-23 10:17:41 +01:00
Haoxiang Zhou
5bcea49921 Issuing controller encodes private keys to PKCS1/PKCS8 as requested by user
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-06-18 15:26:14 +01:00
jetstack-bot
abd13992c8
Merge pull request #2839 from meyskens/update-miekg-dns
Update to the latest miekg/dns
2020-06-11 15:26:23 +01:00
jetstack-bot
89c8fc3c8d
Merge pull request #2898 from diversario/2159-remove-custom-retryer
Remove custom retry logic from route53 package
2020-06-11 13:58:23 +01:00
jetstack-bot
46eaf3d1a4
Merge pull request #2923 from JoshVanL/new-metrics
Updates the metrics package + new metrics controller
2020-06-04 12:59:38 +01:00
jetstack-bot
485e2e59a4
Merge pull request #2947 from hzhou97/no_empty_cacrt
Do not add empty ca.crt
2020-05-29 09:13:01 +01:00
Maartje Eyskens
c867bc7d36 Implement MessageAcceptFunc
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-05-27 17:42:34 +02:00
Maartje Eyskens
c9fbbdbde8 Update to the latest miekg/dns
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-05-27 17:42:34 +02:00
jetstack-bot
78ee463a98 Merge pull request #2946 from meyskens/fix-venafi-dn
Add default DN back in Venafi issuer
2020-05-27 10:35:22 +01:00
JoshVanL
e465329b80
Revert vault free port and expose listener port from metrics server
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-26 23:01:55 +01:00
Haoxiang Zhou
7229741505 Changed tests for issuing controller to expect no ca.crt instead of nil
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-05-26 15:30:43 +01:00
Maartje Eyskens
3fa7f038b3 Check for empty Organizations instead
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-05-26 16:03:42 +02:00
Haoxiang Zhou
609eedacec Do not add ca.crt key to TLS secret if empty in expcertificates as well
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-05-26 14:37:40 +01:00
Haoxiang Zhou
3591de614d Changed unit tests to expect no ca.crt instead of nil
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-05-26 12:16:55 +01:00
Haoxiang Zhou
dceae33364 Do not add ca.crt key to TLS secret if empty
Signed-off-by: Haoxiang Zhou <haoxiang.zhou@jetstack.io>
2020-05-26 12:16:20 +01:00
Maartje Eyskens
96cf8c717e Add default DN back in Venafi issuer
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-05-25 11:30:35 +02:00
JoshVanL
9c9fe56f0b
Update new files to use 2020 copyright
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-21 10:52:56 +01:00
JoshVanL
5539bf3495
Moves metrics controller into sub-package of ./controller/certificates
and fix metrics listen address flag description

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-21 10:47:52 +01:00
JoshVanL
63c5e5f5c6
Cleans up metrics pkg to not require locks, and split out resources into
different files

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-21 10:47:00 +01:00
JoshVanL
db24ca052b
Remove the Factory interface from ACME accounts, in favour of using
package level funcs. This exposes BuildHTTPClient that instruments
metrics, which is passed to NewClient. ACME issuer has reference to
plumbed in metrics

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-21 10:44:37 +01:00
JoshVanL
3e7f7eb87e
Expose Prometheus listen address as a controller command line flag
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 18:21:03 +01:00
JoshVanL
92eb8d0957
Refactor controllers to use new instrumented metrics that's baked into
all controllers

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:43:56 +01:00
JoshVanL
4dd70a6fe7
Adds new metrics controller to reconcile over Certificates and its
Status (Ready and Expiry)

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:43:18 +01:00
JoshVanL
54eb9da7af
Adds 'Factory' interface to consume the instrumented acme client
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:42:47 +01:00
JoshVanL
fd7aa8f41c
Refactor acme client to metrics and adds a 'Factory' interface
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:42:19 +01:00
JoshVanL
9e98d7b948
Updates metrics package to be better consumable
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-05-18 17:41:14 +01:00
James Munnelly
38aa959f95 accounts: Use RWMutex instead of regular Mutex
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-13 14:33:49 +01:00
James Munnelly
b126a0c0e5 Use acme AccountRegistry throughout and tidy up ACME setup code
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-13 13:14:46 +01:00
James Munnelly
81b6c74e63 Add ACME account registry structure
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-13 10:08:06 +01:00
Ilya Shaisultanov
280aa2654d
Remove unused retryer
Signed-off-by: Ilya Shaisultanov <ilya.shaisultanov@gmail.com>
2020-05-07 11:41:13 +02:00
Ilya Shaisultanov
bebd82c1f8
Remove custom retry logic from route53 package
ACME challenges controller already handles retry logic. This
avoid an issue where cert-manager can spam Route53 under certain
conditions, leading to throttling.

Fixes #2159.

Signed-off-by: Ilya Shaisultanov <ilya.shaisultanov@gmail.com>
2020-05-07 00:14:05 +02:00
James Munnelly
982b21bb06 Fix bug that could lead to validation to fail when attempting to update immutable field
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-01 12:33:14 +01:00
James Munnelly
3e8649abc2 Handle ACME orders with already valid authorizations upon first fetch through new 'initialState' field
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-01 12:33:14 +01:00
James Munnelly
9cb68d1d91 Remove serverAuth default usage & remove unused DefaultKeyUsage functions
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-04-30 15:57:12 +01:00
jetstack-bot
c0c74216d5
Merge pull request #2843 from JoshVanL/certificate-issuing-controller-temporary-certificate
Issuing controller temporary certificate support
2020-04-30 12:30:55 +01:00
JoshVanL
a4cfd41ce7
Updates comments to proper working/capitalisation
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2020-04-30 11:53:42 +01:00