Commit Graph

43 Commits

Author SHA1 Message Date
irbekrm
06f6b46f30 Implements feedback from code review
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:20:05 +01:00
irbekrm
d8c941da8e Refactors creation of ACME Orders controller
So that it easier used with the existing test framework and also is more similar to how most other controllers are created

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:11:18 +01:00
irbekrm
8d55b69796 Unit test pending ACME order with valid challenges
Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:06:12 +01:00
irbekrm
1e235c79f2 Re-queue Order with finalized Challenges, but pending state
To avoid stuck Orders in case of a misbehaving ACME server

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 13:05:44 +01:00
irbekrm
881fb2ddea Make tests fail if controller registration fail
Part of work towards fixing errors discovered by static analysis tools

Signed-off-by: irbekrm <irbekrm@gmail.com>
2021-05-19 10:16:59 +01:00
Josh Soref
4d84a7fbb1 spelling: preferred
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-03-04 13:04:38 -05:00
Maartje Eyskens
ab0cd57dc5 Use The cert-manager Authors.
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens
1788a9d758 Update copyright to cert-manager project
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
Maartje Eyskens
542b329914 Implement feedback
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens
9452327d1b Add test in order sync
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens
824e075bf8 fmt
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-24 17:45:52 +02:00
Maartje Eyskens
75e31fe54c Add a unit test for alt chains
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-24 17:33:27 +02:00
Richard Wall
758131ada2 Fix tests in github.com/jetstack/cert-manager/pkg/controller/acmeorders
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall
a70298180a Run a script to update v1alpha2 usage to v1
Script is available at https://github.com/jetstack/cert-manager/pull/3201

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
James Munnelly
8b9ab18849 Add test for unknown challenge types
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-07-06 16:39:31 +01:00
James Munnelly
09d5121713 Update acmeorders controller for new field type
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-07-06 16:25:46 +01:00
James Munnelly
b126a0c0e5 Use acme AccountRegistry throughout and tidy up ACME setup code
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-13 13:14:46 +01:00
James Munnelly
3e8649abc2 Handle ACME orders with already valid authorizations upon first fetch through new 'initialState' field
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-05-01 12:33:14 +01:00
James Munnelly
019f64e841 Fix test failures
Signed-off-by: James Munnelly <james@munnelly.eu>
2020-04-21 10:25:56 +01:00
James Munnelly
641fe0da7c Switch to using upstream golang.org/x/crypto
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-12-03 16:49:31 +00:00
James Munnelly
8bf08237f7 Migrate acmechallenges and acmeorders to use UpdateStatus
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
b6803a2185 Fully update challenge and order in controller sync instead of UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
James Munnelly
2868b4a7b7 Update pkg/controllers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-23 10:07:53 +01:00
James Munnelly
bf9fbea23f Update codebase for new meta apigroup
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 19:25:04 +01:00
James Munnelly
58754abf37 Refactor codebase for v1alpha2
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-20 16:22:43 +01:00
James Munnelly
20840b552d Remove deprecated code from acmeorders controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-19 13:07:59 +01:00
James Munnelly
d59f21da7e Separate sync_test.go into util_test.go
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-11 10:23:33 +01:00
James Munnelly
b92ffbe649 Update tests
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-10 14:45:26 +01:00
James Munnelly
1b8a286206 Rename Setup->Init and use Start to start informers
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-08-22 13:11:33 +01:00
James Munnelly
5aeee11598 Add unit tests for deprecated config feature flag
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 17:18:48 +01:00
James Munnelly
ff0a2c00a1 Don't manually init issuer helper
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 15:24:41 +01:00
James Munnelly
57315074f7 acmeorders: remove util_test.go and refactor to use builder directly
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-07-26 12:30:23 +01:00
Michael Tsang
adfb8703c8 Fix bug where solver with no selector causes nil pointer
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-07-10 15:34:24 +01:00
James Munnelly
cf8c12c5ea Add unit tests for dnsZone selectors
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 15:18:30 +02:00
James Munnelly
fc24b9afc9 Add unit tests for challengeSpecForAuthorization function
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-06-25 15:17:17 +02:00
James Munnelly
220d39c17d Update acmeorders controller to support both formats
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-05-01 14:24:00 +01:00
James Munnelly
0fcc0c666c Update copyright header year
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-07 15:07:55 +00:00
James Munnelly
34c3590052 Store a copy of the signed certificate on the Order resource after Finalize
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-29 12:11:42 +00:00
James Munnelly
ad0971288e Run update-gofmt
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-06 11:10:21 +00:00
James Munnelly
eadbbc85c5 Add missing boilerplate headers
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James Munnelly
d323a1df0d Add unit tests for acmeorders and acmechallenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James Munnelly
967a48e1dc Add ACME Order & Challenge controllers
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:38 +01:00