Commit Graph

965 Commits

Author SHA1 Message Date
Tim Ramlot
6fc8034870
fix tenv linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-30 10:47:21 +02:00
Tim Ramlot
dd4f5f4e39
fix unparam linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-30 10:47:21 +02:00
Tim Ramlot
d6404482e3
fix loggercheck linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 16:48:59 +02:00
Tim Ramlot
ae98ba806b
fix gocritic linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 15:50:47 +02:00
Tim Ramlot
31eec1f8ab
fix bodyclose linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 15:26:34 +02:00
Tim Ramlot
085136068a
fix misspell linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 15:21:07 +02:00
Tim Ramlot
9db044b232
fix gci linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 13:47:25 +02:00
cert-manager-prow[bot]
2ca75ccc32
Merge pull request #6923 from inteon/fix_dns_test_flake
Fix flaky dns test
2024-04-22 14:13:45 +00:00
Tim Ramlot
0f69abd561
fix flaky dns test, make sure dns server has started before sending requests
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-22 14:54:17 +02:00
Youngjun
237dfd9f0d refectoring: remove unnecessary code
Signed-off-by: Youngjun <yj.yoo@okestro.com>
2024-04-22 14:24:59 +09:00
jetstack-bot
d073db1648
Merge pull request #6875 from SgtCoDFish/dodo
Limit DigitalOcean records for cleanup to TXT only
2024-04-10 15:31:22 +02:00
Ashley Davis
d17c9cc513
limit DigitalOcean records for cleanup to TXT only
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-03-26 10:27:54 +00:00
Richard Wall
30db9e2ad5 Link to upstream vcert issues that would allow us to simplify the cert-manager code
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 14:16:38 +00:00
Richard Wall
dd0762e71b Refactor the httpClientForVcert function so that it can also be used for Venafi Cloud
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 13:19:56 +00:00
Richard Wall
cca333d1db Supply User-Agent string to the Venafi controllers
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 11:35:10 +00:00
Richard Wall
04ee7fe0e9 Set the User-Agent header in all Venafi API requests
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 11:02:18 +00:00
Tim Ramlot
6c6d18d0b8
remove the github.com/pkg/errors as a direct dependency
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-02-22 19:52:00 +01:00
Tim Ramlot
ffb47e52fa
remove dead & deprecated code from cert-manager codebase
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-02-10 17:22:23 +01:00
Tim Ramlot
c3b8cbd608
improve comment that explains what removeReqID does and when it fails
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-02-08 17:20:36 +01:00
Tim Ramlot
06b3cd3372
add testcase for nested errors
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-02-08 17:15:28 +01:00
Tim Ramlot
deab9548c0
use errors.Is instead of errors.As
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-02-08 17:15:28 +01:00
Tim Ramlot
893d30d938
migrate to github.com/aws/aws-sdk-go-v2
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-02-08 17:15:28 +01:00
Tim Ramlot
5b8c1213b6
redact the body of failed authentication requests
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-31 10:05:00 +01:00
jetstack-bot
0b33337f1d
Merge pull request #6679 from wallrj/remove-DisableInstanceDiscovery-field
Remove unnecessary Azure workload identity setting: DisableInstanceDiscovery: true
2024-01-30 19:45:27 +00:00
Richard Wall
67e06fce78 A hack to DisableInstanceDiscovery during tests
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-30 18:03:05 +00:00
Tim Ramlot
b9dd4903ad
improve error message logging
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-30 16:55:37 +01:00
Richard Wall
420d3114df Remove unnecessary Azure workload identity setting: DisableInstanceDiscovery: true
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-30 15:50:05 +00:00
Tim Ramlot
90cbbc9d87
replace the azcore.ResponseError error message to make it stable across retries
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-30 16:20:52 +01:00
Richard Wall
ee5cba487a Stop using the deprecated SingleInflight field of miekg/dns
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-26 17:53:50 +00:00
Tim Ramlot
9a049532d0
Update Azure SDK and remove deprecated autorest dependency
Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Philip Laine <philip.laine@gmail.com>
2024-01-12 12:06:34 +01:00
jetstack-bot
4edb4b0ad0
Merge pull request #6619 from ThatsMrTalbot/feat/http-max-body-size
feat: limit the size of the body read back from http requests
2024-01-08 20:41:08 +00:00
Adam Talbot
d0ec66237c feat: limit the size of the body read back from http requests
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2024-01-08 20:28:01 +00:00
Richard Wall
7bda41c282 Use io instead of deprecated ioutil
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-04 15:05:24 +00:00
Tim Ramlot
950948e465
start using the new 'slices' library and deprecate old util functions
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-01-04 09:32:17 +01:00
Richard Wall
865063594d Fix gosec 501
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 11:20:16 +00:00
Richard Wall
0ea258327d Fix gosec G505
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 10:10:11 +00:00
jetstack-bot
c7714e65f0
Merge pull request #6551 from wallrj/gosec-601
Fix gosec G601: Implicit memory aliasing of items from a range statement
2023-12-20 18:21:37 +00:00
Richard Wall
4de9e956e5 Fix gosec G601: Implicit memory aliasing of items from a range statement
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-20 17:25:41 +00:00
Adam Talbot
247a034116 feat: update gateway api to v1
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-18 21:00:42 +00:00
Richard Wall
8bed166858 Add ReadHeaderTimeout to all http.Server where that setting is missing
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-07 11:42:22 +00:00
jetstack-bot
6fddbe538f
Merge pull request #6433 from vinny-sabatini/issue-5782
fix error message when setting up vault issuer
2023-11-14 16:30:01 +01:00
Richard Wall
9b5dd86084 Configure HTTP01 solver Pod with readOnlyRootFilesystem
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-10-31 14:47:24 +00:00
Vinny Sabatini
d15e55a16c
Update pkg/issuer/vault/setup.go
Co-authored-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Vinny Sabatini <vincent.sabatini@gmail.com>
2023-10-24 09:52:52 -05:00
Vinny Sabatini
ef6ef1f0db additional improvements to vault issuer error messages
When initializing a Vault issuer:

* Create different error messages depending on if Vault is sealed or not initialized
* Do not explicitly parse the Vault server URL (this is covered when trying to access health endpoint)

Signed-off-by: Vinny Sabatini <vincent.sabatini@kohls.com>
2023-10-20 16:36:11 -05:00
Vincent Sabatini
298ceb3b2a fix error message when setting up vault issuer
* Ensure Vault URL can be parsed
* Separate generic http errors from vault specific errors when checking
health endpoint

Signed-off-by: Vincent Sabatini <vincent.sabatini@gmail.com>
2023-10-19 08:23:04 -05:00
Maël Valais
d1d92b6398 venafi: ResetCertificate wasn't working
Signed-off-by: Maël Valais <mael@vls.dev>
2023-10-06 16:24:15 +02:00
Tim Ramlot
ef3bd7d3b2
upgrade all dependencies
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-09-28 12:07:27 +02:00
Josh Soref
05117f5f75 Add cluster-autoscaler.kubernetes.io/safe-to-evict
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-09-14 12:47:04 -04:00
Eng Zer Jun
c274d7e929
refactor: remove redundant nil check
From the Go specification:

  "3. If the map is nil, the number of iterations is 0." [1]

Therefore, an additional nil check for before the loop is unnecessary.

[1]: https://go.dev/ref/spec#For_range

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-09-05 19:05:59 +08:00
Tim Ramlot
cf8e37291a
replace k8s.io/utils/pointer with k8s.io/utils/ptr
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-08-28 09:33:10 +02:00