Commit Graph

548 Commits

Author SHA1 Message Date
JoshVanL
232b1133fd Adds more tests for deprecated secret annotations and update secret
annotations if deprecated ones exist

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-27 15:12:25 +00:00
JoshVanL
0d9d0eeb22 Allow secrets with legacy annotations for issuer name and kind to match
existing certificates

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-26 12:13:58 +00:00
jetstack-bot
5ec141c107
Merge pull request #2382 from JoshVanL/cr-controller-issuer-ready
Check for Issuer readiness in CR controllers
2019-11-26 09:40:30 +00:00
JoshVanL
de7aaa84d3 Update CertificateRequest controller unit tests
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-19 22:09:01 +00:00
JoshVanL
3bcc038c09 Check for Issuer readiness in CR controllers
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-19 20:31:44 +00:00
James Munnelly
fdce8c6406 Fix Sync() method to allow time for testing informers to sync
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-11-14 19:43:02 +00:00
JoshVanL
d6248d20bd Make vault issuer to point to resource namespace over certificaterequest
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-13 11:02:43 +00:00
jetstack-bot
f46029b999
Merge pull request #2324 from CoaxVex/master
Correct order api group owner reference when creating challenges
2019-11-07 17:39:34 +00:00
jetstack-bot
57e045fd96
Merge pull request #2316 from JoshVanL/2312-check-all-vault-secrets
Ensure we check all the secrets that vault cluster issuers may be
2019-11-07 17:39:25 +00:00
Nils Cant
765a0cb21d Correct order api group owner reference when creating challenges
Signed-off-by: Nils Cant <nils.cant@vargen.io>
2019-11-05 15:22:32 +01:00
JoshVanL
bca6ebc520 Ensure key usages are set on CertificateRequests created by the
Certificate controller

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-05 14:22:25 +00:00
JoshVanL
3406f5a465 Ensure we check all the secrets that vault cluster issuers may be
watching

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-11-01 16:02:57 +00:00
James Munnelly
00ad3446ef Surface ACME Challenge failure reason on Challenge resource if available
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-29 09:22:08 +00:00
jetstack-bot
87aedeb04c
Merge pull request #2225 from munnerz/wildcard-field-ptr
Make ACMEAuthorization.Wildcard field a pointer
2019-10-15 19:05:05 +01:00
jetstack-bot
8d12d351e8
Merge pull request #2216 from JoshVanL/move-IngressEditInPlaceAnnotationKey-to-acme
Move IngressEditInPlaceAnnotationKey into acme API
2019-10-15 13:53:19 +01:00
James Munnelly
56b1fdd379 Make ACMEAuthorization.Wildcard a *bool
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-15 12:35:11 +01:00
JoshVanL
536dc150ab Move IngressEditInPlaceAnnotationKey into acme API
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-14 16:32:41 +02:00
James Munnelly
ef55bd5807 Mark Order & Challenge resources as Errored if 4xx error is received
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-11 09:30:17 +01:00
James Munnelly
6b19892908 Fix regression in certificates controller setting owner references
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-09 11:33:21 +01:00
JoshVanL
2e1a534642 The ingress shim checks certificate common names and ensures they are
empty

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 16:57:54 +01:00
jetstack-bot
482eac596a
Merge pull request #2085 from JoshVanL/certificate-URISANs
Adds URISANs field to Certificate
2019-10-03 10:59:47 +01:00
JoshVanL
7d615ff8e4 Remove getting secret from lister in matches spec func
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-03 10:01:57 +01:00
Ingo Gottwald
be3f1e3fd2 Remove use of deprecated client.MatchingField
Signed-off-by: Ingo Gottwald <in.gottwald@gmail.com>
2019-10-02 20:47:58 +02:00
JoshVanL
dc7cc388e1 Converts acme test to UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:51:37 +01:00
JoshVanL
7965be9b41 Adds from comments
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
b6bce10b2f Adds CommonName e2e tests for new behaviour
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
66cda5cbd7 Only match for common name in DNS names if common name was given
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
54f8069a78 Make annotation of secret if nil to prevent panic
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
18e0dcdb63 Adds boilerplate copyright to util_test.go
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
13b0584838 Change behaviour to be more relaxed around common names
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
f249888112 Only add common-name annotation if commonName exists
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
dd7213866f Adds validation for URIs to certificate validation
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
JoshVanL
832e20ae29 Adds URISANs field to Certificate
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-02 17:48:37 +01:00
jetstack-bot
b91b7d8d3f
Merge pull request #2097 from JoshVanL/status-subresource
Adds status sub resource and changes updates
2019-10-02 16:40:11 +01:00
James Munnelly
e3b1e9bdb9 Call UpdateStatus before Update when finalizing Challenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
9a807be80a Fix not returning updateErr if updating status failed
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 14:09:24 +01:00
James Munnelly
8bf08237f7 Migrate acmechallenges and acmeorders to use UpdateStatus
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-10-02 12:38:29 +01:00
JoshVanL
5bb452f6e9 Fix info log typo
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-10-01 16:21:47 +01:00
JoshVanL
b6803a2185 Fully update challenge and order in controller sync instead of UpdateStatus
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
de07651142 Remote updatestatus todos and add minimal version to docs
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:51 +01:00
JoshVanL
94d077a5fb Adds status sub resource and changes updates
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-30 13:47:50 +01:00
JoshVanL
1c4fcdf519 Updates bazel
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-27 13:54:39 +01:00
JoshVanL
4eb6335c76 Support out of tree issuers in ingress-shim
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-27 13:54:39 +01:00
James Munnelly
f466aeea88 Fix govet warnings
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-27 12:07:08 +01:00
JoshVanL
869370e226 Cleans up code and naming
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-26 17:35:52 +01:00
JoshVanL
ced21c287f Conformance: Ensure if a certificate is deleted then a new certificate is signed with
same key

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-26 17:34:42 +01:00
James Munnelly
973f4aa424 Update codebase for external dependencies
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-09-26 12:52:43 +01:00
JoshVanL
e1875bc8c5 Updates apis to v1alpha2/meta
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 18:20:56 +01:00
JoshVanL
9b827ee128 Adds all vault Auth methods to secret checks and stops panic
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:54:48 +01:00
JoshVanL
f2f5fccb85 Addresses comments and makes vault auth pointers
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
2019-09-23 13:54:48 +01:00