From ff0a2c00a1d0e0f8bd6cdceefda9f774f134a77e Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Fri, 26 Jul 2019 15:12:03 +0100 Subject: [PATCH] Don't manually init issuer helper Signed-off-by: James Munnelly --- pkg/controller/acmeorders/BUILD.bazel | 1 - pkg/controller/acmeorders/sync_test.go | 5 ----- 2 files changed, 6 deletions(-) diff --git a/pkg/controller/acmeorders/BUILD.bazel b/pkg/controller/acmeorders/BUILD.bazel index 1e3a827d6..8855adcc3 100644 --- a/pkg/controller/acmeorders/BUILD.bazel +++ b/pkg/controller/acmeorders/BUILD.bazel @@ -47,7 +47,6 @@ go_test( "//pkg/acme/fake:go_default_library", "//pkg/apis/certmanager/v1alpha1:go_default_library", "//pkg/controller/test:go_default_library", - "//pkg/issuer:go_default_library", "//test/unit/gen:go_default_library", "//third_party/crypto/acme:go_default_library", "//vendor/github.com/kr/pretty:go_default_library", diff --git a/pkg/controller/acmeorders/sync_test.go b/pkg/controller/acmeorders/sync_test.go index f9c75ce61..ac0a7e952 100644 --- a/pkg/controller/acmeorders/sync_test.go +++ b/pkg/controller/acmeorders/sync_test.go @@ -33,7 +33,6 @@ import ( acmefake "github.com/jetstack/cert-manager/pkg/acme/fake" "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1alpha1" testpkg "github.com/jetstack/cert-manager/pkg/controller/test" - "github.com/jetstack/cert-manager/pkg/issuer" "github.com/jetstack/cert-manager/test/unit/gen" acmeapi "github.com/jetstack/cert-manager/third_party/crypto/acme" ) @@ -295,10 +294,6 @@ func runTest(t *testing.T, test testT) { c := &controller{} c.Register(test.builder.Context) - c.helper = issuer.NewHelper( - test.builder.SharedInformerFactory.Certmanager().V1alpha1().Issuers().Lister(), - test.builder.SharedInformerFactory.Certmanager().V1alpha1().ClusterIssuers().Lister(), - ) c.acmeHelper = &acmefake.Helper{ ClientForIssuerFunc: func(iss v1alpha1.GenericIssuer) (acmecl.Interface, error) { return test.acmeClient, nil