From fe4f4e4aa633dde4a7ed0ecabf1e553b9a024a87 Mon Sep 17 00:00:00 2001 From: Tim Ramlot <42113979+inteon@users.noreply.github.com> Date: Wed, 14 Jun 2023 14:51:39 +0200 Subject: [PATCH] re-add TODO comment and make the message more clear Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --- pkg/controller/certificates/issuing/internal/secret.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/controller/certificates/issuing/internal/secret.go b/pkg/controller/certificates/issuing/internal/secret.go index dd728420c..d2047b4f5 100644 --- a/pkg/controller/certificates/issuing/internal/secret.go +++ b/pkg/controller/certificates/issuing/internal/secret.go @@ -173,6 +173,8 @@ func (s *SecretsManager) setValues(crt *cmapi.Certificate, secret *corev1.Secret if len(data.Certificate) > 0 { var err error certificate, err = utilpki.DecodeX509CertificateBytes(data.Certificate) + // TODO: handle InvalidData here? Maybe we should still patch the secret + // when we detect that the certificate bytes are invalid. if err != nil { return err }