From f96d31e465551a79dfe6494a457dfc601276effa Mon Sep 17 00:00:00 2001 From: Tim Ramlot <42113979+inteon@users.noreply.github.com> Date: Mon, 29 Apr 2024 20:00:01 +0200 Subject: [PATCH] fix exportloopref linter Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --- .golangci.yaml | 1 - .../generates_new_private_key_per_request_test.go | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.golangci.yaml b/.golangci.yaml index 321093a00..06eb16dc5 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -13,7 +13,6 @@ issues: - nilnil - nakedret - musttag - - exportloopref - gomoddirectives text: ".*" - linters: diff --git a/test/integration/certificates/generates_new_private_key_per_request_test.go b/test/integration/certificates/generates_new_private_key_per_request_test.go index 2a05bbec7..97058529b 100644 --- a/test/integration/certificates/generates_new_private_key_per_request_test.go +++ b/test/integration/certificates/generates_new_private_key_per_request_test.go @@ -136,7 +136,7 @@ func TestGeneratesNewPrivateKeyIfMarkedInvalidRequest(t *testing.T) { t.Fatalf("failed to update certificate: %v", err) } - var secondReq *cmapi.CertificateRequest + var secondReq cmapi.CertificateRequest if err := wait.PollUntilContextTimeout(ctx, time.Millisecond*500, time.Second*10, true, func(ctx context.Context) (bool, error) { reqs, err := cmCl.CertmanagerV1().CertificateRequests(namespace).List(ctx, metav1.ListOptions{}) if err != nil { @@ -151,7 +151,7 @@ func TestGeneratesNewPrivateKeyIfMarkedInvalidRequest(t *testing.T) { continue } - secondReq = &req // #nosec G601 -- False positive. See https://github.com/golang/go/discussions/56010 + secondReq = req return true, nil } @@ -273,7 +273,7 @@ func TestGeneratesNewPrivateKeyPerRequest(t *testing.T) { t.Fatalf("failed to update certificate: %v", err) } - var secondReq *cmapi.CertificateRequest + var secondReq cmapi.CertificateRequest if err := wait.PollUntilContextTimeout(ctx, time.Millisecond*500, time.Second*10, true, func(ctx context.Context) (bool, error) { reqs, err := cmCl.CertmanagerV1().CertificateRequests(namespace).List(ctx, metav1.ListOptions{}) if err != nil { @@ -288,7 +288,7 @@ func TestGeneratesNewPrivateKeyPerRequest(t *testing.T) { continue } - secondReq = &req // #nosec G601 -- False positive. See https://github.com/golang/go/discussions/56010 + secondReq = req return true, nil }