weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Only update resource status if a change has occurred

Browse Source
This commit is contained in:
James Munnelly 2017-09-11 00:55:25 +01:00
parent 5872bbe6d2
commit f28afd00ac
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/controller/certificates/sync.go
View File

@ -3,6 +3,7 @@ package certificates
import (
"crypto/x509"
"fmt"
"reflect"
"time"
api "k8s.io/api/core/v1"
@ -314,12 +315,15 @@ func (c *Controller) renew(issuer issuer.Interface, crt *v1alpha1.Certificate) e
return nil
}
func (c *Controller) updateCertificateStatus(iss *v1alpha1.Certificate, status v1alpha1.CertificateStatus) error {
updateCertificate := iss.DeepCopy()
func (c *Controller) updateCertificateStatus(crt *v1alpha1.Certificate, status v1alpha1.CertificateStatus) error {
updateCertificate := crt.DeepCopy()
updateCertificate.Status = status
if reflect.DeepEqual(crt.Status, updateCertificate.Status) {
return nil
}
// TODO: replace Update call with UpdateStatus. This requires a custom API
// server with the /status subresource enabled and/or subresource support
// for CRDs (https://github.com/kubernetes/kubernetes/issues/38113)
_, err := c.cmClient.CertmanagerV1alpha1().Certificates(iss.Namespace).Update(updateCertificate)
_, err := c.cmClient.CertmanagerV1alpha1().Certificates(crt.Namespace).Update(updateCertificate)
return err
}

5
pkg/controller/issuers/sync.go
View File

@ -1,6 +1,8 @@
package issuers
import (
"reflect"
"github.com/golang/glog"
"k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/util/errors"
@ -47,6 +49,9 @@ func (c *Controller) Sync(iss *v1alpha1.Issuer) (err error) {
func (c *Controller) updateIssuerStatus(iss *v1alpha1.Issuer, status v1alpha1.IssuerStatus) error {
updateIssuer := iss.DeepCopy()
updateIssuer.Status = status
if reflect.DeepEqual(iss.Status, updateIssuer.Status) {
return nil
}
// TODO: replace Update call with UpdateStatus. This requires a custom API
// server with the /status subresource enabled and/or subresource support
// for CRDs (https://github.com/kubernetes/kubernetes/issues/38113)