From dc8a4cb95e3a17e69cd9312eda2fbe3b16c4520e Mon Sep 17 00:00:00 2001 From: Daniel Morsing Date: Thu, 17 Jan 2019 14:09:15 +0000 Subject: [PATCH] Avoid connection leaking An empty transport will by default keep connections alive indefinitely. Signed-off-by: Daniel Morsing --- pkg/issuer/acme/http/http.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/issuer/acme/http/http.go b/pkg/issuer/acme/http/http.go index 47d1ef1c4..fcee34983 100644 --- a/pkg/issuer/acme/http/http.go +++ b/pkg/issuer/acme/http/http.go @@ -157,6 +157,9 @@ func testReachability(ctx context.Context, url string, key string) (bool, error) // TODO(dmo): figure out if we need to add a more specific timeout for // individual checks transport := &http.Transport{ + // we're only doing 1 request, make the code around this + // simpler by disabling keepalives + DisableKeepAlives: true, TLSClientConfig: &tls.Config{ InsecureSkipVerify: true, },