weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Update some CSR comments

Browse Source 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
This commit is contained in:
joshvanl 2021-06-21 11:00:02 +01:00
parent a6a394236b
commit d0e7ccd805
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/controller/certificatesigningrequests/vault/vault.go
View File

@ -61,7 +61,6 @@ type Vault struct {
}
func init() {
// create certificate signing request controller for vault issuer
controllerpkg.Register(CSRControllerName, func(ctx *controllerpkg.Context) (controllerpkg.Interface, error) {
return controllerpkg.NewBuilder(ctx, CSRControllerName).
For(certificatesigningrequests.New(apiutil.IssuerVault, NewVault(ctx))).
@ -80,9 +79,9 @@ func NewVault(ctx *controllerpkg.Context) *Vault {
}
// Sign attempts to sign the given CertificateSigningRequest based on the
// provided Vault Issuer or ClusterIssuer. This function will update the
// resource if signing was successful. Returns an error which, if not nil,
// should trigger a retry.
// provided Vault Issuer or ClusterIssuer. This function updates the
// CertificateSigningRequest resource if signing was successful. Returns an
// error which, if not nil, should trigger a retry.
func (v *Vault) Sign(ctx context.Context, csr *certificatesv1.CertificateSigningRequest, issuerObj cmapi.GenericIssuer) error {
log := logf.FromContext(ctx, "sign")
log = logf.WithRelatedResource(log, issuerObj)
@ -128,6 +127,10 @@ func (v *Vault) Sign(ctx context.Context, csr *certificatesv1.CertificateSigning
log.V(logf.DebugLevel).Info("certificate issued")
// Kubernetes sub-resources, namely 'status', are separate API endpoints.
// We don't want to fire another re-sync of this CertificateSigningRequest
// before the `status.Certificate` field has been set as this will fire
// another sign call.
// Update the status.certificate first so that the sync from updating will
// not cause another issuance before setting the CA.
csr.Status.Certificate = certPEM