From cbc61ef7f9a70fdb3921f44c51ef9cda5f615ae3 Mon Sep 17 00:00:00 2001 From: Louis Taylor Date: Thu, 5 Jul 2018 12:41:33 +0100 Subject: [PATCH] Fix tests --- pkg/issuer/acme/dns/dns_test.go | 1 + pkg/issuer/acme/dns/util/wait_test.go | 2 +- pkg/issuer/acme/util_test.go | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/issuer/acme/dns/dns_test.go b/pkg/issuer/acme/dns/dns_test.go index eb5c07c25..220732da0 100644 --- a/pkg/issuer/acme/dns/dns_test.go +++ b/pkg/issuer/acme/dns/dns_test.go @@ -104,6 +104,7 @@ func (f *fixture) solver() *Solver { f.ResourceNamespace, dnsProvider.constructors, f.Ambient, + []string{"8.8.8.8:53"}, } } diff --git a/pkg/issuer/acme/dns/util/wait_test.go b/pkg/issuer/acme/dns/util/wait_test.go index 58abcb7b4..9fa25a46a 100644 --- a/pkg/issuer/acme/dns/util/wait_test.go +++ b/pkg/issuer/acme/dns/util/wait_test.go @@ -83,7 +83,7 @@ var checkResolvConfServersTests = []struct { func TestPreCheckDNS(t *testing.T) { // TODO: find a better TXT record to use in tests - ok, err := PreCheckDNS("google.com.", "v=spf1 include:_spf.google.com ~all") + ok, err := PreCheckDNS("google.com.", "v=spf1 include:_spf.google.com ~all", []string{"8.8.8.8:53"}) if err != nil || !ok { t.Errorf("preCheckDNS failed for acme-staging.api.letsencrypt.org: %s", err.Error()) } diff --git a/pkg/issuer/acme/util_test.go b/pkg/issuer/acme/util_test.go index b65aefccb..0bb8ff43a 100644 --- a/pkg/issuer/acme/util_test.go +++ b/pkg/issuer/acme/util_test.go @@ -79,6 +79,7 @@ func buildFakeAcme(f *unit.Fixture, client *client.FakeACME, issuer v1alpha1.Gen f.KubeInformerFactory().Extensions().V1beta1().Ingresses().Lister(), // TODO: support overriding this field false, + []string{"8.8.8.8:53"}, ) if err != nil { f.T.Errorf("error creating fake Acme: %v", err)