From c890913fb194670f4c5e198e1b00fca684ddfa61 Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Fri, 30 Nov 2018 10:42:33 +0000 Subject: [PATCH] Don't update Certificate status condition upon issuance Signed-off-by: James Munnelly --- pkg/controller/certificates/sync.go | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/pkg/controller/certificates/sync.go b/pkg/controller/certificates/sync.go index c5004229d..f47488c03 100644 --- a/pkg/controller/certificates/sync.go +++ b/pkg/controller/certificates/sync.go @@ -55,12 +55,6 @@ const ( successCertificateRenewed = "CertRenewed" messageErrorSavingCertificate = "Error saving TLS certificate: " - - messageIssuingCertificate = "Issuing certificate..." - messageRenewingCertificate = "Renewing certificate..." - - messageCertificateIssued = "Certificate issued successfully" - messageCertificateRenewed = "Certificate renewed successfully" ) const ( @@ -365,11 +359,7 @@ func (c *Controller) issue(ctx context.Context, issuer issuer.Interface, crt *v1 } if len(resp.Certificate) > 0 { - s := messageCertificateIssued - glog.Info(s) - c.Recorder.Event(crt, corev1.EventTypeNormal, successCertificateIssued, s) - crt.UpdateStatusCondition(v1alpha1.CertificateConditionReady, v1alpha1.ConditionTrue, successCertificateIssued, s, true) - + c.Recorder.Event(crt, corev1.EventTypeNormal, successCertificateIssued, "Certificate issued successfully") // as we have just written a certificate, we should schedule it for renewal c.scheduleRenewal(crt) }