weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

spelling: nameserver

Browse Source 
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
This commit is contained in:
Josh Soref 2020-02-24 16:44:01 -05:00
parent 713696e329
commit c36e58f999
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/internal/apis/certmanager/validation/util/nameserver.go
View File

@ -32,7 +32,7 @@ func ValidNameserver(nameserver string) (string, error) {
}
// SplitHostPort Behavior
// namserver host port err
// nameserver host port err
// 8.8.8.8 "" "" missing port in address
// 8.8.8.8: "8.8.8.8" "" <nil>
// 8.8.8.8.8:53 "8.8.8.8" 53 <nil>

20
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go
View File

@ -150,53 +150,53 @@ func TestRFC2136InvalidNameserverFQDNWithPort2(t *testing.T) {
assert.Error(t, err)
}
func TestRFC2136NamserverWithoutPort(t *testing.T) {
func TestRFC2136NameserverWithoutPort(t *testing.T) {
nameserver := "127.0.0.1"
dnsProvider, err := NewDNSProviderCredentials(nameserver, "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.NoError(t, err)
if dnsProvider.nameserver != nameserver+":"+defaultPort {
t.Errorf("dnsProvider.namserver to be %v:%v, but it is %v", nameserver, defaultPort, dnsProvider.nameserver)
t.Errorf("dnsProvider.nameserver to be %v:%v, but it is %v", nameserver, defaultPort, dnsProvider.nameserver)
}
}
func TestRFC2136NamserverWithoutPort2(t *testing.T) {
func TestRFC2136NameserverWithoutPort2(t *testing.T) {
nameserver := "127.0.0.1:"
dnsProvider, err := NewDNSProviderCredentials(nameserver, "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.NoError(t, err)
if dnsProvider.nameserver != nameserver+defaultPort {
t.Errorf("dnsProvider.namserver to be %v%v, but it is %v", nameserver, defaultPort, dnsProvider.nameserver)
t.Errorf("dnsProvider.nameserver to be %v%v, but it is %v", nameserver, defaultPort, dnsProvider.nameserver)
}
}
func TestRFC2136NamserverWithPort(t *testing.T) {
func TestRFC2136NameserverWithPort(t *testing.T) {
nameserver := "127.0.0.1:12345"
dnsProvider, err := NewDNSProviderCredentials(nameserver, "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.NoError(t, err)
if dnsProvider.nameserver != nameserver {
t.Errorf("dnsProvider.namserver to be %v, but it is %v", nameserver, dnsProvider.nameserver)
t.Errorf("dnsProvider.nameserver to be %v, but it is %v", nameserver, dnsProvider.nameserver)
}
}
func TestRFC2136NamserverWithPortNoIP(t *testing.T) {
func TestRFC2136NameserverWithPortNoIP(t *testing.T) {
_, err := NewDNSProviderCredentials(":53", "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.Error(t, err)
}
func TestRFC2136NamserverEmpty(t *testing.T) {
func TestRFC2136NameserverEmpty(t *testing.T) {
_, err := NewDNSProviderCredentials("", "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.Error(t, err)
}
func TestRFC2136NamserverIPInvalid(t *testing.T) {
func TestRFC2136NameserverIPInvalid(t *testing.T) {
_, err := NewDNSProviderCredentials("900.65.3.64", "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.Error(t, err)
}
func TestRFC2136NamserverIPInvalid2(t *testing.T) {
func TestRFC2136NameserverIPInvalid2(t *testing.T) {
_, err := NewDNSProviderCredentials(":", "", rfc2136TestTsigKeyName, rfc2136TestTsigSecret)
assert.Error(t, err)
}