weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #166 from munnerz/fix-http01

Browse Source 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Error if existing presented key and expected key do not match

**What this PR does / why we need it**:

A type in the HTTP01 solver caused it to not return an error if the key presented by the ingress and the expected key do not match.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

Fixes #163 

**Special notes for your reviewer**:

**Release note**:

```release-note
Fix bug in ACME HTTP01 solver causing self-check to return true before paths have propagated
```
This commit is contained in:
jetstack-bot 2017-10-26 22:07:31 +01:00 committed by GitHub
commit bc44f708dd
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/issuer/acme/http/http.go
View File

@ -465,9 +465,7 @@ func testReachability(ctx context.Context, domain, path, key string) error {
}
if string(presentedKey) != key {
if err != nil {
return fmt.Errorf("presented key (%s) did not match expected (%s)", presentedKey, key)
}
return fmt.Errorf("presented key (%s) did not match expected (%s)", presentedKey, key)
}
return nil