diff --git a/pkg/issuer/acme/issue.go b/pkg/issuer/acme/issue.go index 5e0ed2e92..acca01f45 100644 --- a/pkg/issuer/acme/issue.go +++ b/pkg/issuer/acme/issue.go @@ -305,7 +305,7 @@ func (a *Acme) createNewOrder(ctx context.Context, crt *v1alpha1.Certificate, te log.V(4).Info("Creating new Order resource for Certificate") - csr, err := pki.GenerateCSR(a.issuer, crt) + csr, err := pki.GenerateCSR(crt) if err != nil { // TODO: what errors can be produced here? some error types might // be permanent, and we should handle that properly. diff --git a/pkg/issuer/vault/issue.go b/pkg/issuer/vault/issue.go index efb8f5e3e..a5b03da60 100644 --- a/pkg/issuer/vault/issue.go +++ b/pkg/issuer/vault/issue.go @@ -72,7 +72,7 @@ func (v *Vault) Issue(ctx context.Context, crt *v1alpha1.Certificate) (*issuer.I /// BEGIN building CSR // TODO: we should probably surface some of these errors to users - template, err := pki.GenerateCSR(v.issuer, crt) + template, err := pki.GenerateCSR(crt) if err != nil { return nil, err } diff --git a/pkg/util/pki/csr.go b/pkg/util/pki/csr.go index c4f4e87a2..792310c12 100644 --- a/pkg/util/pki/csr.go +++ b/pkg/util/pki/csr.go @@ -113,7 +113,7 @@ var serialNumberLimit = new(big.Int).Lsh(big.NewInt(1), 128) // by issuers that utilise CSRs to obtain Certificates. // The CSR will not be signed, and should be passed to either EncodeCSR or // to the x509.CreateCertificateRequest function. -func GenerateCSR(issuer v1alpha1.GenericIssuer, crt *v1alpha1.Certificate) (*x509.CertificateRequest, error) { +func GenerateCSR(crt *v1alpha1.Certificate) (*x509.CertificateRequest, error) { commonName := CommonNameForCertificate(crt) dnsNames := DNSNamesForCertificate(crt) iPAddresses := IPAddressesForCertificate(crt)