weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Do not validate issuerRef's Kind field if group is not recognised

Browse Source 
Signed-off-by: James Munnelly <james@munnelly.eu>
This commit is contained in:
James Munnelly 2019-08-01 18:41:14 +01:00
parent 7975c92442
commit b3aadba2b7
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/apis/certmanager/validation/certificate.go
View File

@ -123,13 +123,14 @@ func validateIssuerRef(issuerRef v1alpha1.ObjectReference, fldPath *field.Path)
if issuerRef.Name == "" {
el = append(el, field.Required(issuerRefPath.Child("name"), "must be specified"))
}
switch issuerRef.Kind {
case "":
case "Issuer", "ClusterIssuer":
default:
el = append(el, field.Invalid(issuerRefPath.Child("kind"), issuerRef.Kind, "must be one of Issuer or ClusterIssuer"))
if issuerRef.Group == "" || issuerRef.Group == v1alpha1.SchemeGroupVersion.Group {
switch issuerRef.Kind {
case "":
case "Issuer", "ClusterIssuer":
default:
el = append(el, field.Invalid(issuerRefPath.Child("kind"), issuerRef.Kind, "must be one of Issuer or ClusterIssuer"))
}
}
return el
}