From b0e65f84c7d72e854b870283c6407ae77f653eee Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Wed, 4 Apr 2018 11:30:15 +0100 Subject: [PATCH] Add TODO for domain label values --- pkg/issuer/acme/http/pod.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/issuer/acme/http/pod.go b/pkg/issuer/acme/http/pod.go index c28f32624..8754d5087 100644 --- a/pkg/issuer/acme/http/pod.go +++ b/pkg/issuer/acme/http/pod.go @@ -17,7 +17,11 @@ import ( func podLabels(crt *v1alpha1.Certificate, domain string) map[string]string { return map[string]string{ certNameLabelKey: crt.Name, - domainLabelKey: domain, + // TODO: we need to support domains longer than 63 characters + // this value should probably be hashed, and then the full plain text + // value stored as an annotation to make it easier for users to read + // see #425 for details: https://github.com/jetstack/cert-manager/issues/425 + domainLabelKey: domain, } }