Merge pull request #5966 from irbekrm/transform_controller

Clean up cached Secret resources
This commit is contained in:
jetstack-bot 2023-04-20 11:33:58 +01:00 committed by GitHub
commit b0255651fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 2 deletions

View File

@ -164,9 +164,11 @@ type filteredSecretInformer struct {
func (f *filteredSecretInformer) Informer() Informer {
typedInformer := f.typedInformerFactory.InformerFor(&corev1.Secret{}, f.newTyped)
// TODO: set any possible transforms
metadataInformer := f.metadataInformerFactory.ForResource(secretsGVR).Informer()
// TODO: set transform on metadataInformer to remove last applied annotation etc
if err := metadataInformer.SetTransform(partialMetadataRemoveAll); err != nil {
panic(fmt.Sprintf("internal error: error setting transfomer on the metadata informer: %v", err))
}
return &informer{
typedInformer: typedInformer,
metadataInformer: metadataInformer,

View File

@ -0,0 +1,40 @@
/*
Copyright 2023 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package informers
import (
"fmt"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/cache"
)
var _ cache.TransformFunc = partialMetadataRemoveAll
// partialMetadataRemoveAll implements a cache.TransformFunc that removes
// labels, annotations and managed
// fields from PartialObjectMetadata.
func partialMetadataRemoveAll(obj interface{}) (interface{}, error) {
partialMeta, ok := obj.(*metav1.PartialObjectMetadata)
if !ok {
return nil, fmt.Errorf("internal error: cannot cast object %#+v to PartialObjectMetadata", obj)
}
partialMeta.Annotations = nil
partialMeta.ManagedFields = nil
partialMeta.Labels = nil
return partialMeta, nil
}