data race: fix certificate requests in cache being mutated

Signed-off-by: Maël Valais <mael@vls.dev>
2021-07-20 16:04:27 +02:00 · 2021-07-20 16:04:27 +02:00 · af9a1e434f
commit af9a1e434f
parent a96dc55e1e
1 changed files with 1 additions and 0 deletions
--- a/pkg/controller/certificaterequests/approver/sync.go
+++ b/pkg/controller/certificaterequests/approver/sync.go
@ -53,6 +53,7 @@ func (c *Controller) Sync(ctx context.Context, cr *cmapi.CertificateRequest) (er
 	}

 	// Update the CertificateRequest approved condition to true.
+	cr = cr.DeepCopy()
 	apiutil.SetCertificateRequestCondition(cr,
 		cmapi.CertificateRequestConditionApproved,
 		cmmeta.ConditionTrue,