From ac5745d8f093c4c11b1bdb039daf1831dcc5fa4d Mon Sep 17 00:00:00 2001 From: Daniel Morsing Date: Thu, 17 Jan 2019 14:25:19 +0000 Subject: [PATCH] Remove need for provider config in DNS self-check Signed-off-by: Daniel Morsing --- pkg/issuer/acme/dns/dns.go | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/pkg/issuer/acme/dns/dns.go b/pkg/issuer/acme/dns/dns.go index 9c4f307af..8a7bb3f8a 100644 --- a/pkg/issuer/acme/dns/dns.go +++ b/pkg/issuer/acme/dns/dns.go @@ -92,17 +92,8 @@ func (s *Solver) Present(ctx context.Context, issuer v1alpha1.GenericIssuer, ch // Check verifies that the DNS records for the ACME challenge have propagated. func (s *Solver) Check(ctx context.Context, issuer v1alpha1.GenericIssuer, ch *v1alpha1.Challenge) (bool, error) { - providerName := ch.Spec.Config.DNS01.Provider - if providerName == "" { - return false, fmt.Errorf("dns01 challenge provider name must be set") - } - providerConfig, err := issuer.GetSpec().ACME.DNS01.Provider(providerName) - if err != nil { - return false, err - } - - fqdn, value, ttl, err := util.DNS01Record(ch.Spec.DNSName, ch.Spec.Key, s.DNS01Nameservers, followCNAME(providerConfig.CNAMEStrategy)) + fqdn, value, ttl, err := util.DNS01Record(ch.Spec.DNSName, ch.Spec.Key, s.DNS01Nameservers, false) if err != nil { return false, err }