weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix panic in certificates controller

Browse Source
This commit is contained in:
James Munnelly 2017-11-04 00:27:22 +00:00
parent 7f656f9ed4
commit a5b954658c
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/controller/certificates/sync.go
View File

@ -91,6 +91,15 @@ func (c *Controller) Sync(ctx context.Context, crt *v1alpha1.Certificate) (err e
return err
}
expectedCN, err := pki.CommonNameForCertificate(crt)
if err != nil {
return err
}
expectedDNSNames, err := pki.DNSNamesForCertificate(crt)
if err != nil {
return err
}
// grab existing certificate and validate private key
cert, err := kube.SecretTLSCert(c.secretLister, crt.Namespace, crt.Spec.SecretName)
if err != nil {
@ -111,14 +120,6 @@ func (c *Controller) Sync(ctx context.Context, crt *v1alpha1.Certificate) (err e
defer c.scheduleRenewal(crt)
crtCopy := crt.DeepCopy()
expectedCN, err := pki.CommonNameForCertificate(crtCopy)
if err != nil {
return err
}
expectedDNSNames, err := pki.DNSNamesForCertificate(crtCopy)
if err != nil {
return err
}
// if the certificate was not found, or the certificate data is invalid, we
// should issue a new certificate.